Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757837AbXJKOuj (ORCPT ); Thu, 11 Oct 2007 10:50:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754294AbXJKOuc (ORCPT ); Thu, 11 Oct 2007 10:50:32 -0400 Received: from ms-smtp-04.nyroc.rr.com ([24.24.2.58]:52997 "EHLO ms-smtp-04.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbXJKOub convert rfc822-to-8bit (ORCPT ); Thu, 11 Oct 2007 10:50:31 -0400 Date: Thu, 11 Oct 2007 10:49:14 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: =?UTF-8?B?U8OpYmFzdGllbiBEdWd1w6k=?= cc: Ingo Molnar , Thomas Gleixner , Linux RT Users , linux-kernel , Daniel Walker Subject: Re: [PATCH] RT: fix spin_trylock_irq In-Reply-To: <20071011142417.1d965820@bull.net> Message-ID: References: <20071011142417.1d965820@bull.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 42 -- When I'm asked what language is my mother tongue, I simply answer "C". On Thu, 11 Oct 2007, [UTF-8] Sébastien Dugué wrote: > --- > include/linux/spinlock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.23-rc9-rt2/include/linux/spinlock.h > =================================================================== > --- linux-2.6.23-rc9-rt2.orig/include/linux/spinlock.h > +++ linux-2.6.23-rc9-rt2/include/linux/spinlock.h > @@ -501,7 +501,7 @@ do { \ > > #define spin_trylock_irq(lock) \ > __cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irq, \ > - __spin_trylock_irq, lock)) > + _spin_trylock_irq, lock)) > > #define spin_trylock_irqsave(lock, flags) \ > __cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irqsave, \ Thanks! Applied. Daniel, this BUG was introduced by your conversion to PICK_FUNCTION patch. Please be more careful, and do an audit of your patch. (I don't have time ATM). This could also be the source of other bugs I've been chasing. I might be pulling the PICK_FUNCTION patches if there's more bugs like this. -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/