Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f232be95-74aa-8beb-0413-3dcc7e541ba5@redhat.com>
Date:   Fri, 26 May 2023 21:42:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] mm/gup_test:fix ioctl fail for compat task
Content-Language: en-US
To:     Haibo Li <haibo.li@mediatek.com>, linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, xiaoming.yu@mediatek.com
References: <20230526022125.175728-1-haibo.li@mediatek.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230526022125.175728-1-haibo.li@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26.05.23 04:21, Haibo Li wrote:

Nit: "mm/gup_test: fix ioctl fail for compat task"

> When tools/testing/selftests/mm/gup_test.c is compiled as 32bit,
> then run on arm64 kernel,
> it reports "ioctl: Inappropriate ioctl for device".
> 
> Fix it by filling compat_ioctl in gup_test_fops
> 
> Signed-off-by: Haibo Li <haibo.li@mediatek.com>
> ---
>   mm/gup_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/gup_test.c b/mm/gup_test.c
> index 8ae7307a1bb6..c0421b786dcd 100644
> --- a/mm/gup_test.c
> +++ b/mm/gup_test.c
> @@ -381,6 +381,7 @@ static int gup_test_release(struct inode *inode, struct file *file)
>   static const struct file_operations gup_test_fops = {
>   	.open = nonseekable_open,
>   	.unlocked_ioctl = gup_test_ioctl,
> +	.compat_ioctl = compat_ptr_ioctl,
>   	.release = gup_test_release,
>   };
>   

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb