Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp100300rwd; Fri, 26 May 2023 15:47:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6FeS753BVum+VaMv0thD7Tw2xSY4mDHcBEBPm8ng2aQgo7FWPtHKdDyVLkUKmFe4bfuHZY X-Received: by 2002:a05:6a20:914c:b0:ff:1df3:51dd with SMTP id x12-20020a056a20914c00b000ff1df351ddmr1046002pzc.37.1685141220596; Fri, 26 May 2023 15:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685141220; cv=none; d=google.com; s=arc-20160816; b=MqP44TjXP9ksvl+AMdvc7BbG0B5I/2+nfLxQxkE/as/NLKIGBtMOnqSOAwuigPxKYN L7QSUwmcN3R4WPzwGARtAxrs8+Mk5/nXxXuHHnaxmCNRmeHFWJnnsTrcayBJAk3QjjZ8 ZiuEGHTgtT72o2XNYfg2Vv6704Y0KerlSM30FFQ8SJYB1mUnlMc6jGkrZjP6BwzUc542 52er+IjhaCTS+g2LuCWomA3iLThwAeXH/r5TON7i4lgIoj5t25sDjLHdnar1xyvC53Wj YV9pT/DsOY06ieJ9M8ybAPFhZ8wHfv8JaRiys8cHd7dokSKhvSQxUIEeNb3eXkigsQ5U QFGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:date:from; bh=EwZ2mDnK15eU52DcKuNW/fgVb5KtWFPBinG3vEN02Bo=; b=Od2IywZlFCuPQPPqRV8RujMjBDrGjAXRLhKvRTt0NZnqltyJzCRQ/pm2xqtVakXmK0 455KoPXtL/AlAJacs3PJJRtU8dNQi7YNEgHUBhps9NzH81J0DzANDiqN/NaR8mUXg6cN VTWsjUtnT2quZyMfAS5LGKUQ2rleck+zutLJlAim9DeppbUtkKkJFg6+ghLUCBLQeqXI mf1gb925ixzOgyA1B/orsj19a+Rkw+kYT3BLiOsDUmTkp5RsmbkN72/fySsIVeWm9UQ9 tYTvma5pGBxlCZu8d1y4E5QxR2LAADdgzH3DH/1QoWwHMMybbhe5RY+17HsKaUFDtw9d qhVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a056a00004a00b006281ec442absi4970420pfk.309.2023.05.26.15.46.48; Fri, 26 May 2023 15:47:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244197AbjEZWYI (ORCPT + 99 others); Fri, 26 May 2023 18:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244270AbjEZWYE (ORCPT ); Fri, 26 May 2023 18:24:04 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B18FE50 for ; Fri, 26 May 2023 15:23:38 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id f192b364-fc10-11ed-b3cf-005056bd6ce9; Sat, 27 May 2023 01:02:02 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Sat, 27 May 2023 01:02:01 +0300 To: Mukesh Ojha Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v6 2/5] pinctrl: qcom: Use qcom_scm_io_update_field() Message-ID: References: <1680076012-10785-1-git-send-email-quic_mojha@quicinc.com> <1680076012-10785-3-git-send-email-quic_mojha@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1680076012-10785-3-git-send-email-quic_mojha@quicinc.com> X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Mar 29, 2023 at 01:16:49PM +0530, Mukesh Ojha kirjoitti: > Use qcom_scm_io_update_field() exported function introduced > in last commit. ... > u32 val; > + u32 mask; Swapping their order may help with readability. ... > + mask = (7 << g->intr_target_bit); Why not GENMASK(2, 0) at the same time? -- With Best Regards, Andy Shevchenko