Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758061AbXJKPjl (ORCPT ); Thu, 11 Oct 2007 11:39:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752751AbXJKPjd (ORCPT ); Thu, 11 Oct 2007 11:39:33 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:33889 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752684AbXJKPjd (ORCPT ); Thu, 11 Oct 2007 11:39:33 -0400 Date: Thu, 11 Oct 2007 08:31:55 -0700 (PDT) From: Linus Torvalds To: Kevin cc: Greg KH , Olof Johansson , Greg KH , "Rafael J. Wysocki" , "Theodore Ts'o" , Zwane Mwaikambo , Justin Forbes , Linux Kernel Mailing List , Chris Wedgwood , Domenico Andreoli , Mark Lord , Randy Dunlap , Michael Krufky , Chuck Ebbert , Dave Jones , akpm@linux-foundation.org, Chuck Wolber , stable@kernel.org, alan@lxorguk.ukuu.org.uk, BDFL , Stephen Rothwell Subject: Re: ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMP poweroff hangs) In-Reply-To: <200710102005.02184.spaceman__spiff@cox.net> Message-ID: References: <20071008180406.052382073@mini.kroah.org> <200710092359.47144.spaceman__spiff@cox.net> <200710102005.02184.spaceman__spiff@cox.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 45 On Wed, 10 Oct 2007, Kevin wrote: > > The last kernel I used was 6.2.22 the "dmesg" the file is attached: > > dmesg 2.6.22 line 158 > apm: overridden by ACPI. > > dmesg, APM on, has no line > apm: overridden by ACPI. Ok, this is the real reason. The APM code does: if (PM_IS_ACTIVE()) { printk(KERN_NOTICE "apm: overridden by ACPI.\n"); apm_info.disabled = 1; return -ENODEV; } and in previous kernels that would notice that you have ACPI enabled, and APM gets shut out, and you never see your buggy APM BIOS. In 2.6.23, this apparently doesn't happen for some reason. And I think I see the problem: it's a config change. You don't have PM_LEGACY enabled. Your config file diff shows: -CONFIG_PM_LEGACY=y +# CONFIG_PM_LEGACY is not set I suspect we should make CONFIG_APM either depend on, or select, PM_LEGACY. But as far as I can see, nothing has actually changed in this area in the kernel, and this bug has been there before - just your config change made it appear. Rafael? Stephen? Opinions? I'd think that making APM depend on CONFIG_PM_LEGACY is the right thing to do these days.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/