Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp209312rwd; Fri, 26 May 2023 18:04:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GCvi237hOPlFCTmqcsWUyXe1F30lhvw13eNghzFqsQsGJgBtnQPU+RxRbMe/4ygBKHbqJ X-Received: by 2002:a05:6a20:244f:b0:10c:37ed:3e94 with SMTP id t15-20020a056a20244f00b0010c37ed3e94mr764755pzc.28.1685149456112; Fri, 26 May 2023 18:04:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685149456; cv=none; d=google.com; s=arc-20160816; b=R768aO7pDihakvUMJKHZz74vQheUeCp09Cdja2M3Yzqw/Pyi/WN2wckGiaTbAn44LV 6LtXq5+45J1tZv0NP1M2lktITa5FyVJDJTamION/93LXyfs8iM6ayDmIEU/gumP6eS4D b6xvInsdzueJfacyC1s9tB8Xt7Bm9AfIuHIA2ZBAsXNvibEXLbZc3igdyXC7mw5sEsqq 7+I/MFzzdKB9ouCZwjocnt4HSjhZolssXvJOnBxUXKZwSMz2chUHBL0yyc8ni2J8ar0/ bPBBEz3IxZ9rTLCD2RfvrdFua+oH3U26rzSJ8RFOWvj9irx7hCFL/5lkWSdhx4eBsiUf RJyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=rUdtr6r3PmoAaW6qIy5abu2LwEp/uvxptQKJhnykm/I=; b=KBFA+eIoitT0QeqD2SFo9TG4rZN6pUexoFxVMGKLrf0iwRPq8RPMq4HSFOnc8rRHKv 3WSrDlOXl0x1Ung2e2Q/HYrMfkzGLihgAL1KkfgEFk3nZiKAcCIIljkiFZVGxASzjwXG l0FKuSUPEAPFQCRXoGA6gcYkZhrV048ozjfCPjKroB+XRlTyVl3EvuOCbgliFR0GTc5T 9M/WYKoH4FMZyF12zdn69XpAnHVawXRvNCFiuUslgsvfWhtgYDRYxvrHSbAQytxrSH2C R8pfs7p7QtAVBX7fQ0E825gX/59n89oc19SYSmiR2f+VAU5z+NIN9nsDCFSu3+J+NfYx jYuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aLfMMwQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h130-20020a636c88000000b00513522ea60asi4594482pgc.615.2023.05.26.18.04.03; Fri, 26 May 2023 18:04:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aLfMMwQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236265AbjE0A5l (ORCPT + 99 others); Fri, 26 May 2023 20:57:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjE0A5k (ORCPT ); Fri, 26 May 2023 20:57:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 829DB135 for ; Fri, 26 May 2023 17:57:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 161AA654BF for ; Sat, 27 May 2023 00:57:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E64BC433D2; Sat, 27 May 2023 00:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685149058; bh=3vBQ3hNzB1htnPz205IbCSBNbcAAWMD/jc/FlGUItp8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aLfMMwQjdwdNcKtVFIzBBfhEKhzY8608s+2D5qjQ0I+cctckwK72Fr7Ero4sCyOay M/qiFF+9oqlrfB5lFVHgvB/IQFsOfaf9ms4w4pJrRSwroXILirP80J7tw+IvtlmrB6 C+axsiXhIPb8oG6HjqUu7w30SCHCFMI12quWVnGd07HNn5WSmjsVZ80qw6vSUhzlYV EFiVNxsX5sNgu7rqArJbv4j1C2nsqWjTEvKw/tWgLNDZQKKWCIFaxsDirhg7FmbgbK bcJ2BPiFi68edlfm+RtL/oOWB1hkdQHSRtYO/JKM041QmrEIOMfmOFV+oB8n4stFXo EfbKoqmE3Uf6w== Date: Fri, 26 May 2023 17:57:36 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, Alexander Duyck Subject: Re: [PATCH net-next 05/12] mm: Make the page_frag_cache allocator handle __GFP_ZERO itself Message-ID: <20230526175736.7e75dcf9@kernel.org> In-Reply-To: <20230524153311.3625329-6-dhowells@redhat.com> References: <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 May 2023 16:33:04 +0100 David Howells wrote: > Make the page_frag_cache allocator handle __GFP_ZERO itself rather than > passing it off to the page allocator. There may be a mix of callers, some > specifying __GFP_ZERO and some not - and even if all specify __GFP_ZERO, we > might refurbish the page, in which case the returned memory doesn't get > cleared. I think it's pretty clear that page frag allocator was never supposed to support GFP_ZERO, as we don't need it in networking.. So maybe you're better off adding the memset() in nvme? CCing Alex, who I think would say something along those lines :) IDK how much we still care given that most networking drivers are migrating to page_poll these days.