Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp330180rwd; Fri, 26 May 2023 21:06:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6eJ4ocS6P6FP2uQQKqkJau8xTSZQPPT2nMom8vfWLYq473RrHfybds1Jfi2kc7/iqfJBN4 X-Received: by 2002:a05:6a20:4286:b0:10f:bb1:ca50 with SMTP id o6-20020a056a20428600b0010f0bb1ca50mr2246397pzj.10.1685160399325; Fri, 26 May 2023 21:06:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685160399; cv=none; d=google.com; s=arc-20160816; b=tXvd6/mOV2SGlfnrldWf96CwkvIX6SRb2mnXkxyDqDUS7VHDrcNdWNT424vex/gDWJ wEW5KxDlbWc1P8cFZJmyh2IUPUoEK043//GD8z8omYmMQ7GG8C2cF1Grsd9qIm3eJ3Cw ZwsYYBrTQmX/YBy19n0l3NXYWhBJP57akqQKeJtK5mpSwp0FIvaJWMX+llI8fo/Rutbh e++/+hAJgaVrAd4/Fm4ll2D1TegCnYuZFp9Y/hOfxQReAnm4z1/iY/fWD4J5kmH7xHHG 3ssqbNyliesMg36hF2hV0zC8VaQ10fO6rvhSSzoUxIrUyJ6u4xQ8VwlhCqAIrpZ4q5Mk 1Exw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a2xCe7O7+yP7S2jBW94Ky2TVFSCOtAAD8aGSKVZyuo8=; b=hmNlRemMQgxR30KQm5lH4LIaVwuFECtoZAWFl/AHNsfVCuhJzSojxV8M1V+SthWBjJ 1VW6ysSefr+kjoHnXfnhZx+Oe9kf9PKboLS0hjJprv2ZgnWWHMBxrjo+N9+csc1lm2QP uxYiqzFsus30EF/OI+f1DQ4yL3gngK8nVhbWp7uKpejcDSfyQOVnq8Y+W1kAr3IfRvno lqEnRkNBncCZCHiYnh6Me9Sw//JsW6xp/pmqVBVhHX6ApyrJu3FXuD5C0DaTqBxyujYz ev7FT9tqCpMJeu7vDNyRoXXqByMVaTl4C5y9g+rrHnvUCFSjKDi1rjP1SFiDRXlYbIgx ukfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vtTBlbTi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f30-20020a63381e000000b005347efdfecbsi5039855pga.111.2023.05.26.21.06.27; Fri, 26 May 2023 21:06:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vtTBlbTi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbjE0EBJ (ORCPT + 99 others); Sat, 27 May 2023 00:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjE0EBI (ORCPT ); Sat, 27 May 2023 00:01:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23F97A3; Fri, 26 May 2023 21:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a2xCe7O7+yP7S2jBW94Ky2TVFSCOtAAD8aGSKVZyuo8=; b=vtTBlbTiGVU/kW7m0r2iZikpWF uHBfF2vaPo90m14jsnj8E/gfDUNom13R2UQzaU9KK8HjdYfF+YfzCOsLAD/7giYmZfBf4Opg6+RpV kopdXnQtBJdG+sH/CJDrY0A5IYTbRoxymJVHlmEZVHQtSxyJ8cc6dwVIPuxkQkjfhyir+UY1GB9/3 Bm1GXtLYPJhxL55jGH4HFVOO3u2Wm4u1QKsr2ZZs+hp4LQTCttR4KEecxjjypBV7hyDknRnrVIL0O 7c8ufJqP4v2QyS/LZtTwwYojlqhYIBiX84U0Rf40AjON56IPWAfOj8X1EL8J2xsQCulIkFRstpunW 1qhvegUg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2l6n-003VTr-DT; Sat, 27 May 2023 04:00:49 +0000 Date: Sat, 27 May 2023 05:00:49 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: Vasily Averin , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: remove unused mem_cgroup_from_obj() Message-ID: References: <20230527103126.398267-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230527103126.398267-1-linmiaohe@huawei.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2023 at 06:31:26PM +0800, Miaohe Lin wrote: > The function mem_cgroup_from_obj() is not used anymore. Remove it and > clean up relevant comments. You should have looked at the git history to see why it was created and who used it. Shakeel, Vasily, are you going to retry adding commit 1d0403d20f6c?