Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202305250056.oZhsJmdD-lkp@intel.com> <DM4PR21MB344103E6766B9D586C0D11B1E441A@DM4PR21MB3441.namprd21.prod.outlook.com>
 <CAH2r5mteP0kHJN8SJzhU60q+TreP3AaMhVntEuXBiLQb49mBhw@mail.gmail.com>
In-Reply-To: <CAH2r5mteP0kHJN8SJzhU60q+TreP3AaMhVntEuXBiLQb49mBhw@mail.gmail.com>
From:   Steve French <smfrench@gmail.com>
Date:   Sat, 27 May 2023 03:49:55 -0500
Message-ID: <CAH2r5mujTOvAdu2uu=ypRA4ZUPjcMUdefF3b59WMwoUvJrDxRg@mail.gmail.com>
Subject: Re: [EXTERNAL] [samba-ksmbd:for-next 4/7] fs/smb/client/ioctl.c:324:17:
 warning: variable 'caps' set but not used
To:     CIFS <linux-cifs@vger.kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
Content-Type: multipart/mixed; boundary="000000000000be618905fca8f028"
Precedence: bulk

--000000000000be618905fca8f028
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Fix attached:

Fix trivial unused variable warning (when SMB1 support disabled)

"ioctl.c:324:17: warning: variable 'caps' set but not used
[-Wunused-but-set-variable]"

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202305250056.oZhsJmdD-lkp@int=
el.com/

> From: kernel test robot <lkp@intel.com>
> Sent: Wednesday, May 24, 2023 7:01:39 AM
> To: Steven French <Steven.French@microsoft.com>
> Cc: oe-kbuild-all@lists.linux.dev <oe-kbuild-all@lists.linux.dev>
> Subject: [EXTERNAL] [samba-ksmbd:for-next 4/7] fs/smb/client/ioctl.c:324:=
17: warning: variable 'caps' set but not used
>
> Hi Steve,
>
> First bad commit (maybe !=3D root cause):
>
> tree:   git://git.samba.org/ksmbd.git for-next
> head:   d58a8a27a7cac75e82383c2a25704bd15b0045d5
> commit: e3adc6b1f0d12b80a7a81fd4f345890a4fb483d6 [4/7] smb: move client a=
nd server files to common directory fs/smb
> config: i386-randconfig-i003-20230524
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> reproduce (this is a W=3D1 build):
>         git remote add samba-ksmbd git://git.samba.org/ksmbd.git
>         git fetch --no-tags samba-ksmbd for-next
>         git checkout e3adc6b1f0d12b80a7a81fd4f345890a4fb483d6
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=3D1 O=3Dbuild_dir ARCH=3Di386 olddefconfig
>         make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash fs/smb/cli=
ent/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%=
2F%2Flore.kernel.org%2Foe-kbuild-all%2F202305250056.oZhsJmdD-lkp%40intel.co=
m%2F&data=3D05%7C01%7CSteven.French%40microsoft.com%7Caf0e1ee950724b4eb2ce0=
8db5c78aca3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638205445595592058=
%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW=
wiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DmoaptwMZutTbXzs%2F65jeBFL8bJmVzWsj=
oLBeuDAQaMc%3D&reserved=3D0
>
> All warnings (new ones prefixed by >>):
>
>    fs/smb/client/ioctl.c: In function 'cifs_ioctl':
> >> fs/smb/client/ioctl.c:324:17: warning: variable 'caps' set but not use=
d [-Wunused-but-set-variable]
>      324 |         __u64   caps;
>          |                 ^~~~
>
>
> vim +/caps +324 fs/smb/client/ioctl.c
>
> 7ba3d1cdb7988c fs/cifs/ioctl.c Steve French    2021-05-02  312
> f9ddcca4cf7d95 fs/cifs/ioctl.c Steve French    2008-05-15  313  long cifs=
_ioctl(struct file *filep, unsigned int command, unsigned long arg)
> ^1da177e4c3f41 fs/cifs/ioctl.c Linus Torvalds  2005-04-16  314  {
> 496ad9aa8ef448 fs/cifs/ioctl.c Al Viro         2013-01-23  315   struct i=
node *inode =3D file_inode(filep);
> 7e7db86c7e1088 fs/cifs/ioctl.c Steve French    2019-09-19  316   struct s=
mb3_key_debug_info pkey_inf;
> ^1da177e4c3f41 fs/cifs/ioctl.c Linus Torvalds  2005-04-16  317   int rc =
=3D -ENOTTY; /* strange error - but the precedent */
> 6d5786a34d98bf fs/cifs/ioctl.c Pavel Shilovsky 2012-06-20  318   unsigned=
 int xid;
> ba00ba64cf0895 fs/cifs/ioctl.c Jeff Layton     2010-09-20  319   struct c=
ifsFileInfo *pSMBFile =3D filep->private_data;
> 96daf2b09178d8 fs/cifs/ioctl.c Steve French    2011-05-27  320   struct c=
ifs_tcon *tcon;
> a77592a70081ed fs/cifs/ioctl.c Ronnie Sahlberg 2020-07-09  321   struct t=
con_link *tlink;
> d26c2ddd335696 fs/cifs/ioctl.c Steve French    2020-02-06  322   struct c=
ifs_sb_info *cifs_sb;
> f654bac2227adc fs/cifs/ioctl.c Steve French    2005-04-28  323   __u64   =
ExtAttrBits =3D 0;
> 618763958b2291 fs/cifs/ioctl.c Jeff Layton     2010-11-08 @324   __u64   =
caps;
>
> :::::: The code at line 324 was first introduced by commit
> :::::: 618763958b2291a09057dbfa553da6ded93dcfad cifs: make cifs_ioctl han=
dle NULL filp->private_data correctly
>
> :::::: TO: Jeff Layton <jlayton@redhat.com>
> :::::: CC: Steve French <sfrench@us.ibm.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu=
b.com%2Fintel%2Flkp-tests%2Fwiki&data=3D05%7C01%7CSteven.French%40microsoft=
.com%7Caf0e1ee950724b4eb2ce08db5c78aca3%7C72f988bf86f141af91ab2d7cd011db47%=
7C1%7C0%7C638205445595592058%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC=
JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D4S7ypb=
EmVEH0ItLaFq6203nT%2FVUHq%2FI%2B0DPIw8MLllw%3D&reserved=3D0


--=20
Thanks,

Steve

--000000000000be618905fca8f028
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-cifs-address-unused-variable-warning.patch"
Content-Disposition: attachment; 
	filename="0001-cifs-address-unused-variable-warning.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_li5r27q50>
X-Attachment-Id: f_li5r27q50

RnJvbSBmZGQ3ZDFmZmY0ZTNiOTdjNDcwNmY0YzBlMDAwYTM4YjEzNGI3YWU1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBGcmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5jb20+
CkRhdGU6IFNhdCwgMjcgTWF5IDIwMjMgMDM6MzM6MjMgLTA1MDAKU3ViamVjdDogW1BBVENIXSBj
aWZzOiBhZGRyZXNzIHVudXNlZCB2YXJpYWJsZSB3YXJuaW5nCgpGaXggdHJpdmlhbCB1bnVzZWQg
dmFyaWFibGUgd2FybmluZyAod2hlbiBTTUIxIHN1cHBvcnQgZGlzYWJsZWQpCgoiaW9jdGwuYzoz
MjQ6MTc6IHdhcm5pbmc6IHZhcmlhYmxlICdjYXBzJyBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNl
ZC1idXQtc2V0LXZhcmlhYmxlXSIKClJlcG9ydGVkLWJ5OiBrZXJuZWwgdGVzdCByb2JvdCA8bGtw
QGludGVsLmNvbT4KQ2xvc2VzOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9vZS1rYnVpbGQtYWxs
LzIwMjMwNTI1MDA1Ni5vWmhzSm1kRC1sa3BAaW50ZWwuY29tLwpTaWduZWQtb2ZmLWJ5OiBTdGV2
ZSBGcmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5jb20+Ci0tLQogZnMvc21iL2NsaWVudC9pb2N0
bC5jIHwgNiArKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVsZXRp
b24oLSkKCmRpZmYgLS1naXQgYS9mcy9zbWIvY2xpZW50L2lvY3RsLmMgYi9mcy9zbWIvY2xpZW50
L2lvY3RsLmMKaW5kZXggY2IzYmU1OGNkNTVlLi5mZmYwOTJiYmM3YTMgMTAwNjQ0Ci0tLSBhL2Zz
L3NtYi9jbGllbnQvaW9jdGwuYworKysgYi9mcy9zbWIvY2xpZW50L2lvY3RsLmMKQEAgLTMyMSw3
ICszMjEsMTEgQEAgbG9uZyBjaWZzX2lvY3RsKHN0cnVjdCBmaWxlICpmaWxlcCwgdW5zaWduZWQg
aW50IGNvbW1hbmQsIHVuc2lnbmVkIGxvbmcgYXJnKQogCXN0cnVjdCB0Y29uX2xpbmsgKnRsaW5r
OwogCXN0cnVjdCBjaWZzX3NiX2luZm8gKmNpZnNfc2I7CiAJX191NjQJRXh0QXR0ckJpdHMgPSAw
OworI2lmZGVmIENPTkZJR19DSUZTX1BPU0lYCisjaWZkZWYgQ09ORklHX0NJRlNfQUxMT1dfSU5T
RUNVUkVfTEVHQUNZCiAJX191NjQgICBjYXBzOworI2VuZGlmIC8qIENPTkZJR19DSUZTX0FMTE9X
X0lOU0VDVVJFX0xFR0FDWSAqLworI2VuZGlmIC8qIENPTkZJR19DSUZTX1BPU0lYICovCiAKIAl4
aWQgPSBnZXRfeGlkKCk7CiAKQEAgLTMzMSw5ICszMzUsOSBAQCBsb25nIGNpZnNfaW9jdGwoc3Ry
dWN0IGZpbGUgKmZpbGVwLCB1bnNpZ25lZCBpbnQgY29tbWFuZCwgdW5zaWduZWQgbG9uZyBhcmcp
CiAJCQlpZiAocFNNQkZpbGUgPT0gTlVMTCkKIAkJCQlicmVhazsKIAkJCXRjb24gPSB0bGlua190
Y29uKHBTTUJGaWxlLT50bGluayk7Ci0JCQljYXBzID0gbGU2NF90b19jcHUodGNvbi0+ZnNVbml4
SW5mby5DYXBhYmlsaXR5KTsKICNpZmRlZiBDT05GSUdfQ0lGU19QT1NJWAogI2lmZGVmIENPTkZJ
R19DSUZTX0FMTE9XX0lOU0VDVVJFX0xFR0FDWQorCQkJY2FwcyA9IGxlNjRfdG9fY3B1KHRjb24t
PmZzVW5peEluZm8uQ2FwYWJpbGl0eSk7CiAJCQlpZiAoQ0lGU19VTklYX0VYVEFUVFJfQ0FQICYg
Y2FwcykgewogCQkJCV9fdTY0CUV4dEF0dHJNYXNrID0gMDsKIAkJCQlyYyA9IENJRlNHZXRFeHRB
dHRyKHhpZCwgdGNvbiwKLS0gCjIuMzQuMQoK
--000000000000be618905fca8f028--