Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Sat, 27 May 2023 05:19:14 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Joaquin Aramendia <samsagax@gmail.com>
Cc:     "Derek J. Clark" <derekjohn.clark@gmail.com>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (oxp-sensors) Differentiate new BIOS for the Mini
Message-ID: <f10a1c61-bc8b-420f-988d-ba0ebfccf00f@roeck-us.net>
References: <20230526215621.16075-1-samsagax@gmail.com>
 <430e7be0-26a9-43b0-a61f-66cb8dfc805e@roeck-us.net>
 <CABgtM3jNVp63XB5A8Cf0KhB4So2==HLGa9_meuTn0vHYy=gBzQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABgtM3jNVp63XB5A8Cf0KhB4So2==HLGa9_meuTn0vHYy=gBzQ@mail.gmail.com>
Precedence: bulk

On Fri, May 26, 2023 at 08:42:51PM -0300, Joaquin Aramendia wrote:
> > On Fri, May 26, 2023 at 06:56:22PM -0300, Joaqu?n Ignacio Aramend?a wrote:
> > > Newer BIOS got some other changes aside from string changes. Add a board
> > > enum to differentiate it from the old OneXplayer Mini AMD BIOS.
> > >
> >
> > I see no functional difference. What is the point of this change ?
> >
> > Thanks,
> > Guenter
> 
> It is nothing right now, honestly. But is necessary for a later change
> i have queued and a bit of OCD on my part. Should I add this to the
> other change?
> 

It can stay as separate patch, but please resubmit it together with
the patch(es) actually using it.

Guenter