Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Otavio Salvador <otavio.salvador@ossystems.com.br>
MIME-Version: 1.0
References: <20230523212829.2539417-1-otavio@ossystems.com.br>
 <b8166ed7-2d3b-4bdd-b597-f0aeddb7ecdc@app.fastmail.com> <20230527124428.GT528183@dragon>
In-Reply-To: <20230527124428.GT528183@dragon>
Date:   Sat, 27 May 2023 10:29:04 -0300
Message-ID: <CAP9ODKociRAi9WP-R_-JoKmMWtSN2JwJJ+7n-cn4u-G-vktS3A@mail.gmail.com>
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Otavio Salvador <otavio@ossystems.com.br>,
        linux-arm-kernel@lists.infradead.org,
        Alistair Francis <alistair@alistair23.me>,
        Fabio Estevam <festevam@gmail.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Mark Brown <broonie@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Russell King <linux@armlinux.org.uk>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Stefan Hansson <newbie13xd@gmail.com>,
        Stefan Wahren <stefan.wahren@chargebyte.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Shawn,

Em s=C3=A1b., 27 de mai. de 2023 =C3=A0s 09:44, Shawn Guo <shawnguo@kernel.=
org> escreveu:
>
> On Wed, May 24, 2023 at 08:48:26AM +0200, Arnd Bergmann wrote:
> > On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote:
> > > The KERNEL_GZIP is used in most config and is the default, there is n=
o
> > > clear reason to diverge so let default be used.
> > >
> > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >
> > I don't mind that change, but it seems odd to single this one out, as
> > there are many other options in that particular defconfig that
> > stick out more, picking LZO seems like a reasonable choice for slightly
> > faster booting, though ZSTD would be the more modern choice.
> >
> > If you are looking into cleaning up this file, maybe see if we can
> > kill off these options:
> >
> > CONFIG_EXPERT=3Dy
> > CONFIG_ARCH_FORCE_MAX_ORDER=3D13
> > CONFIG_CMDLINE=3D"noinitrd console=3Dttymxc0,115200"
> > CONFIG_CS89x0_PLATFORM=3Dy # none of these four are in dts files
> > CONFIG_SMC91X=3Dy
> > CONFIG_SMC911X=3Dy
> > CONFIG_SMSC911X=3Dy
> > CONFIG_STAGING=3Dy
> > CONFIG_STAGING_MEDIA=3Dy
> > CONFIG_VIDEO_IMX_MEDIA=3Dy # not graduated from staging after 6 years
> > CONFIG_EXT2_FS=3Dy
> > CONFIG_EXT3_FS=3Dy # select EXT4 instead
> > CONFIG_ISO9660_FS=3Dm
> >
> > I have not investigated why any of them were added originally,
> > so it's likely that some are actually needed.
>
> Would you investigate the suggested options and see if we can clean up
> more than just KERNEL_LZO?

Sure. I'll view them. I'll prepare more patches for it.

--=20
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750