Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bharat Bhushan <bbhushan2@marvell.com>
To:     Conor Dooley <conor@kernel.org>
CC:     "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: RE: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI
 system watchdog driver
Thread-Topic: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI
 system watchdog driver
Thread-Index: AQHZj5sOTdsKm/MUPEiPdp8HUff0C69s87YAgAE8q+A=
Date:   Sat, 27 May 2023 14:53:25 +0000
Message-ID: <DM5PR1801MB188350DD9CFDBB3E240AC838E3449@DM5PR1801MB1883.namprd18.prod.outlook.com>
References: <20230526062626.1180-1-bbhushan2@marvell.com>
 <20230526-bondless-slather-5de0a5659353@spud>
In-Reply-To: <20230526-bondless-slather-5de0a5659353@spud>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nKdCchO+eSab48VOfX4CqkZ/5nMPp4ETLpMxbYSO6Qxqi2iuRpMk2jZHY+2M?=
 =?us-ascii?Q?IGBJRM9lJl/zg5wtCkZq79fnEBXu69WhA0JTkJa+Mu2DUWNjwzhw73Ajz+0/?=
 =?us-ascii?Q?5P9ZFwn/exHkh6Nt3BKnmYHrhQLjn28VEZjxxsa6IQqFtVw9QkXv6K+BEY8D?=
 =?us-ascii?Q?Uk5i56gfa4gq2pFz7klWuGLL9NoupZ92gtXDAADJW+luq6clwI2vETI9H7if?=
 =?us-ascii?Q?5h7OJNifmbpGoxtnQXZhJyMROrxSi5TvHNT6/HnJN4HtNX8hwaNodzkUk8TA?=
 =?us-ascii?Q?x8skoJfp7EtuGovau+3OXtFN5XutvWKrWJoc1WNtYwTogHK/dqmIFB25VZAy?=
 =?us-ascii?Q?SdGOWSlFCtNUVom/vlZiJ1CdPnecPlKyBy3xjTjDR0XkSCpUGvG1arDs6038?=
 =?us-ascii?Q?eVeSWqXBkXIZW04CHcnuzpjbBFM08KGKYWZIfzHf9sFWpUuyjDuts+j6Wcqc?=
 =?us-ascii?Q?OX91ElGCi0TRlgknzQzjzkBnf60ZmJxPmUOU+yOE11nfrD/mxgC+azKROxF2?=
 =?us-ascii?Q?sz7rvgl1bltMxxaF4ZGGEQ+UsemWifV+mhENeJJEIi1BK+iOPuzogPz3Dwd2?=
 =?us-ascii?Q?AFaOtkT9Aic1zyfKDFRuO1kgNkjRhg5PjpQ3571KjrlEhhrJPvXySs1/xZft?=
 =?us-ascii?Q?tKtkv1WJ55TYU1BjAi7NpB/i0JypIfamfHu/pS4IJRuAlARBTK4yGn93xIp8?=
 =?us-ascii?Q?FBLM0UFq3YLrt2BQORJwZ72nfzJQj21x65fTnoyEtX07+dJr8be0aPAwiQVW?=
 =?us-ascii?Q?nYMKJ5FIbjOtOeJQv135Wg8XapxKynT14HOF/qVHM9387L+omjfC8Yp7Lx/D?=
 =?us-ascii?Q?u8Mdt5pYQ8v/vckNNNplKEfrinUzIbaB2BXZsBIu2sUp3qjV7cmibjxahfL9?=
 =?us-ascii?Q?6ZLGBY+Q3r72Qi0hOTyluHbrao3nOt//jyx8MRfox1ft6yp2YbCc6qQ9ETCb?=
 =?us-ascii?Q?mabKM8DAwgtIhnkF5vrwCyZ+rYlfJrPmos00zh0CzJ2c/b1ITBtWhTDX10k0?=
 =?us-ascii?Q?9B55PUnxZnfH/g7b3rHCKnoKUgs19kvTG/2GS0zGfY9rAScosiyqErgS/1OZ?=
 =?us-ascii?Q?aw5qDVY5N9eUWP/VgeTvMT1ji7sWg0TI9n4XYdFnc+hvxTGwGQeVU8b4wfqi?=
 =?us-ascii?Q?eQdbsl5u9d9dMQqOSnIchc3oC16eZz5cRYrgvzvRadqA5vrjmA5tGC2zUwHM?=
 =?us-ascii?Q?Alq+wQj6UY6tLXLYmVJfpNBBtYjioutrq8oG1n+X9rF8oUryv8RGyEEszxTA?=
 =?us-ascii?Q?RPW4LzBwUSyA9vKqOAwx1on5K6grlYRr/jal1TWMDD8uXoumzY9Ug/P3XlWU?=
 =?us-ascii?Q?5sgo8TyaPWU/8hIg9IWQ/eO6iqSCnN3CJLChHJG2g41OgT++SNEB+hCF70W1?=
 =?us-ascii?Q?GFVzValpkBDxshH1p569qXY0tECFotQvWPiqzLBtIBwHBBJcCPFPW+ub4tON?=
 =?us-ascii?Q?Kpz9yyRNOOZrHuwR76SzO46gthQLJulpNIEKDLNjiyKl6ZrZH8PxR+SCHQm0?=
 =?us-ascii?Q?w0Q331AmsE13noGgD3ySKh72YybXkeVlTE+RsiSJZk0t4gsA9F5GpL7lzQfZ?=
 =?us-ascii?Q?Qt4sP7jeIxRwEWP828elr76IjejecfvnnoD2Sc6b?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1883.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2cef74c-7739-4ab7-b0e5-08db5ec22039
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2023 14:53:25.9782
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /hR7RYxggBHt0C31DvJzWyoID5CODR7NLvVl+mq1m40/uBeHdrArR9NTSVoQ5gou4USIUyqCxqpuQvOW8PGIvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR18MB4247
X-Proofpoint-GUID: B2hYBAXsTARIYQ45YNfZk9UFJINNmGA2
X-Proofpoint-ORIG-GUID: B2hYBAXsTARIYQ45YNfZk9UFJINNmGA2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-27_10,2023-05-25_03,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Conor,

Please see inline=20

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Saturday, May 27, 2023 1:07 AM
> To: Bharat Bhushan <bbhushan2@marvell.com>
> Cc: wim@linux-watchdog.org; linux@roeck-us.net; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; linux-watchdog@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>
> Subject: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI syst=
em
> watchdog driver
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> Yo Bharat,
>=20
> On Fri, May 26, 2023 at 11:56:25AM +0530, Bharat Bhushan wrote:
> > Add binding documentation for the Marvell GTI system watchdog driver.
> >
> > Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> > ---
> > v8:
> >   - Compatible name as per soc name
>=20
> I am sorry, but I do not understand this.

I mean to say replaced soc family name from compatible with actual soc name=
s

>=20
> >
> >  .../watchdog/marvell,octeontx2-wdt.yaml       | 73 +++++++++++++++++++
> >  1 file changed, 73 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yam
> > l
> > b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yam
> > l
> > new file mode 100644
> > index 000000000000..3c642359d960
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt
> > +++ .yaml
> > @@ -0,0 +1,73 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/watchdog/marvell,octeontx2-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell Global Timer (GTI) system watchdog
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
>=20
> From v7:
> Put allOf after maintainers:.

Thanks for pointing, I am sorry, missed almost all comments on v7. Will res=
olve this and below as well in next version

>=20
> > +
> > +maintainers:
> > +  - Bharat Bhushan <bbhushan2@marvell.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - marvell,cn9670-wdt
> > +      - marvell,cn9880-wdt
> > +      - marvell,cnf9535-wdt
> > +      - marvell,cn10624-wdt
> > +      - marvell,cn10308-wdt
> > +      - marvell,cnf10518-wdt
>=20
> static const struct of_device_id gti_wdt_of_match[] =3D {
>        { .compatible =3D "marvell,cn9670-wdt", .data =3D &match_data_octe=
ontx2},
>        { .compatible =3D "marvell,cn9880-wdt", .data =3D &match_data_octe=
ontx2},
>        { .compatible =3D "marvell,cnf9535-wdt", .data =3D &match_data_oct=
eontx2},
>        { .compatible =3D "marvell,cn10624-wdt", .data =3D &match_data_cn1=
0k},
>        { .compatible =3D "marvell,cn10308-wdt", .data =3D &match_data_cn1=
0k},
>        { .compatible =3D "marvell,cnf10518-wdt", .data =3D &match_data_cn=
10k},
>=20
> This is a fat hint that you should be using fallback compatibles here.
> You even had a fallback setup in your last revision, but you seem to have
> removed it alongside the removal of the wildcards. Why did you do that?

Not sure I understand this comment, Compatible in last version was as below=
:

+ properties:
+ compatible:
+    oneOf:
+      - const: marvell,octeontx2-wdt
+      - items:
+          - enum:
+              - marvell,octeontx2-95xx-wdt
+              - marvell,octeontx2-96xx-wdt
+              - marvell,octeontx2-98xx-wdt
+          - const: marvell,octeontx2-wdt
+      - const: marvell,cn10k-wdt
+      - items:
+          - enum:
+              - marvell,cn10kx-wdt
+              - marvell,cnf10kx-wdt
+          - const: marvell,cn10k-wdt

By fallback do you mean " const: marvell,cn10k-wdt" and " const: marvell,oc=
teontx2-wdt" ? If yes I removed because "octeontx2" and "cn10k" are soc fam=
ily name and no a specific soc.

Thanks
-Bharat

>=20
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    minItems: 1
>=20
> From v7:
> maxItems instead. You see it is different than above properties?
>=20
> > +
> > +  clock-names:
> > +    minItems: 1
>=20
> From v7:
> Need to define names.
>=20
> Cheers,
> Conor.