Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1460571rwd; Sat, 27 May 2023 18:40:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4LYRAbPKLAg6hRtBeRj+uj6PMgfEvY5tBY3SEA5JGw87lNSVttYDS+AT49RJK90CcLWWRd X-Received: by 2002:a05:6a00:1825:b0:623:8592:75c4 with SMTP id y37-20020a056a00182500b00623859275c4mr10446611pfa.29.1685238035492; Sat, 27 May 2023 18:40:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685238035; cv=none; d=google.com; s=arc-20160816; b=M/WALQy13T7MunFtPk6ZwWHF2XG8AcRaJqw87Yi51GIqtOvRQTBI4V2dRM/NmaWncd edu+VCDyv3kiMlzwbXY6+QIPAImUr7Pd4wAbW6tNS9qxOAHPHedISQhL1vgInZytfq+M PI6HcXo2QV/PkkQs5oaPG5g2h84X4Xis/tFvkJazfEmf5wLsSVXnKxBUgTM3G+nh4wtI VcJrqgmvInwQFiTvngrSYDEeL8cF4QvCQ74UTONTS8qGT1pA2YTBwzFHcPZWNpdoWIxP 4t/RjbjpAJZXZCS4arOFqPXgLsXMSvhDDGCtSr5flLLjKUnhGwOwMAwJ8m+lgLl2rq6r 925A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=XwTMqNXJxZngfAiFWVhcJnTq6nmvJ33/9Fzz5GiyWWk=; b=MnpVhdExfSM4+c4l30NtQWV8q/Zn5mvVAVe4/TZQMUBX2u8mcdvGMGG6I4EePyN9sN NApJru//XYsqSjm2A8Pny9FnoIZS7jD/DjEx/Pq0/PVU8wHl/IijleZg5RVXBt5K6gEC 6j2XXN6mXDDAlZgXbSVhHRHeKuicgHfc1PI/r2T/oruWTcBcRxZOSypMJCcMNr8nORXX rqPVgvzN6d8ADF/JfPSZ5AjvqYcwyjryQsQ9dFXnl5ABHQVfjOdmwJOwvkjLyxn19tsJ QtPkrXTIoIh5+KnHn4Pw+NovqEjjphdOlzqSRnsraWkPYKAsXeb5M0dZbwB8+Cy/e8iv boHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=HvdtVhLA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020aa7948b000000b0064d4963f75fsi7234446pfk.193.2023.05.27.18.40.21; Sat, 27 May 2023 18:40:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=HvdtVhLA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbjE1BV2 (ORCPT + 99 others); Sat, 27 May 2023 21:21:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjE1BV0 (ORCPT ); Sat, 27 May 2023 21:21:26 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E8CD3 for ; Sat, 27 May 2023 18:21:25 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51492ae66a4so967428a12.1 for ; Sat, 27 May 2023 18:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1685236883; x=1687828883; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XwTMqNXJxZngfAiFWVhcJnTq6nmvJ33/9Fzz5GiyWWk=; b=HvdtVhLAR2W1pMjW56B3uOfnxErxKXMBHe25hDnziAGoKKyrn69dT85wVYtO6XW/aF RJ1+2DEL9xyBI6PpLm4YDWEYvWMdZa9hQRcNtst5RjoQL0plq/YbQTe7hjgm1ddB0sdP VaAQBLskb0r7tUwLLOZnGMkO2NZvMHH/mZ6es= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685236883; x=1687828883; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XwTMqNXJxZngfAiFWVhcJnTq6nmvJ33/9Fzz5GiyWWk=; b=I0YEUtyNgAngTCbMtKQk0pWugzOhn1ZBAKZ30IefezMZ1ltIoHQJ+oq+Za2oG8tbZH 2D23fLcwhDbmss/IU+S2JAZSmOLeUPSGXTAIk+lIV8nZ7JdL+ThXbqBful1RU0Krx9ZF QEyQ6FVPKz1GaueCp+quTnJf3pRZhlA7LR8wfmIrFk6teP0mHVahlYg2PSKRa4SZ5nDy 23Cdv+tMSVTuzjrwfYM55Qy8E90k+NO0V0XeelJdkhEDP0RlSxMwCt+PCr2lPcHukxIU DWHgclipqOwnNoQ5+lCEHdUgGl3GS8pRJEKLirj+e1DHWsM+93CZ+BcNl4O0pXb6HaRk AiYw== X-Gm-Message-State: AC+VfDwIW4pIM/0IMJbE4ze7+WtI9FSjS02C/r3KtS92elfWyNN/D5uH T3ybW9oygb3v0V2oZr1O8ucwmsIFAzu8p57qwDWokdiO X-Received: by 2002:a17:907:e86:b0:965:6d21:48bc with SMTP id ho6-20020a1709070e8600b009656d2148bcmr7035107ejc.75.1685236882965; Sat, 27 May 2023 18:21:22 -0700 (PDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id k12-20020a170906128c00b00965a52d2bf6sm3960193ejb.88.2023.05.27.18.21.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 May 2023 18:21:21 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-96f8d485ef3so326863266b.0 for ; Sat, 27 May 2023 18:21:21 -0700 (PDT) X-Received: by 2002:a17:907:2682:b0:96a:440b:d5c8 with SMTP id bn2-20020a170907268200b0096a440bd5c8mr5866751ejc.59.1685236880680; Sat, 27 May 2023 18:21:20 -0700 (PDT) MIME-Version: 1.0 References: <20230522025124.5863-1-michael.christie@oracle.com> <20230522025124.5863-4-michael.christie@oracle.com> <20230522123029.GA22159@redhat.com> <20230522174757.GC22159@redhat.com> <20230523121506.GA6562@redhat.com> <87bkib6nxr.fsf@email.froward.int.ebiederm.org> <20230524141022.GA19091@redhat.com> <87ttw1zt4i.fsf@email.froward.int.ebiederm.org> <20230525115512.GA9229@redhat.com> <87y1lcxwcj.fsf@email.froward.int.ebiederm.org> <87cz2mrtnk.fsf@email.froward.int.ebiederm.org> <87mt1pmezu.fsf@email.froward.int.ebiederm.org> In-Reply-To: <87mt1pmezu.fsf@email.froward.int.ebiederm.org> From: Linus Torvalds Date: Sat, 27 May 2023 18:21:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression To: "Eric W. Biederman" Cc: Oleg Nesterov , Mike Christie , linux@leemhuis.info, nicolas.dichtel@6wind.com, axboe@kernel.dk, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com, sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com, brauner@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2023 at 6:17=E2=80=AFPM Eric W. Biederman wrote: > > It seems like a good approach for including in the -rc series. > I think the change should look more like my change below. I have no objections. My patch was a fairly "hack and slash" thing to just disassociate the IO workers entirely from the core dumping. Yours seems to be slightly more surgical. Linus