Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758345AbXJKTMV (ORCPT ); Thu, 11 Oct 2007 15:12:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755235AbXJKTMO (ORCPT ); Thu, 11 Oct 2007 15:12:14 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:38778 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754469AbXJKTMN (ORCPT ); Thu, 11 Oct 2007 15:12:13 -0400 Date: Thu, 11 Oct 2007 21:12:12 +0200 (CEST) From: Jan Engelhardt To: Randy Dunlap cc: "Agarwal, Lomesh" , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org Subject: Re: TPM driver changes to support multiple locality In-Reply-To: <20071011115429.92326cbd.randy.dunlap@oracle.com> Message-ID: References: <27383.1192045583@turing-police.cc.vt.edu> <20071011115429.92326cbd.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 22 On Oct 11 2007 11:54, Randy Dunlap wrote: >On Thu, 11 Oct 2007 11:33:35 -0700 Agarwal, Lomesh wrote: > >> Below is the patch for TPM driver. >> Comments/suggestions? > >Observe/use kernel coding style. >Run the patch thru scripts/checkpatch.pl and check its suggestions. >Use "diffstat -p1 -w70" and put that summary near the top of the >patch (after the patch description). Or, if using quilt on top of the tree, a simple `quilt diff --diffstat --sort` will do all the nice diffing, including stat and use diff -pu. It also preserves diffstat (if not regenerating that) and patch description, so is suited *perfectly* for the task when you don't want to use stgit. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/