Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <afe12540-0980-f536-996d-28807937f36b@wanadoo.fr>
Date:   Sun, 28 May 2023 09:27:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v4 1/6] ASoC: tas2781: Add Header file for tas2781 driver
To:     "13916275206@139.com >> Shenghao Ding" <13916275206@139.com>
Cc:     Ryan_Chu@wistron.com, Sam_Wu@wistron.com,
        alsa-devel@alsa-project.org, broonie@kernel.org,
        devicetree@vger.kernel.org, gentuser@gmail.com, kevin-lu@ti.com,
        krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
        linux-kernel@vger.kernel.org, navada@ti.com, peeyush@ti.com,
        perex@perex.cz, pierre-louis.bossart@linux.intel.com,
        robh+dt@kernel.org, shenghao-ding@ti.com, tiwai@suse.de,
        x1077012@ti.com
References: <20230527223439.7741-1-13916275206@139.com>
Content-Language: fr
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20230527223439.7741-1-13916275206@139.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 28/05/2023 à 00:34, Shenghao Ding a écrit :
> Create Header file for  tas2781 driver.
> 
> Signed-off-by: Shenghao Ding <13916275206-7R9yAhoRP9E@public.gmane.org>
> 
> ---
> Changes in v4:
>   - correct some enums have capitalized Chn, chn to all
>   Changes to be committed:
> 	new file:   include/sound/tas2781-dsp.h
> 	new file:   include/sound/tas2781-tlv.h
> 	new file:   include/sound/tas2781.h
> ---
>   include/sound/tas2781-dsp.h | 190 ++++++++++++++++++++++++++++++++++++
>   include/sound/tas2781-tlv.h |  22 +++++
>   include/sound/tas2781.h     | 182 ++++++++++++++++++++++++++++++++++
>   3 files changed, 394 insertions(+)
>   create mode 100644 include/sound/tas2781-dsp.h
>   create mode 100644 include/sound/tas2781-tlv.h
>   create mode 100644 include/sound/tas2781.h

[...]

> diff --git a/include/sound/tas2781-tlv.h b/include/sound/tas2781-tlv.h
> new file mode 100644
> index 000000000000..f4310dce655a
> --- /dev/null
> +++ b/include/sound/tas2781-tlv.h
> @@ -0,0 +1,22 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +//
> +// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier
> +//
> +// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> +// https://www.ti.com
> +//
> +// The TAS2781 driver implements a flexible and configurable
> +// algo coefficient setting for one, two, or even multiple
> +// TAS2781 chips.
> +//
> +// Author: Shenghao Ding <shenghao-ding-l0cyMroinI0@public.gmane.org>
> +// Author: Kevin Lu <kevin-lu-l0cyMroinI0@public.gmane.org>
> +//
> +
> +#ifndef __TAS2781_TLV_H__
> +#define __TAS2781_TLV_H__
> +
> +static const DECLARE_TLV_DB_SCALE(dvc_tlv, -10000, 100, 0);
> +static const DECLARE_TLV_DB_SCALE(amp_vol_tlv, 1100, 50, 0);
> +
> +#endif /* __TAS2781_LIB_H__ */

Nit: __TAS2781_TLV_H__ (or nothing as in the file above)

> diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
> new file mode 100644
> index 000000000000..399bb8f9b54a
> --- /dev/null
> +++ b/include/sound/tas2781.h
> @@ -0,0 +1,182 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +//
> +// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier
> +//
> +// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> +// https://www.ti.com
> +//
> +// The TAS2781 driver implements a flexible and configurable
> +// algo coefficient setting for one, two, or even multiple
> +// TAS2781 chips.
> +//
> +// Author: Shenghao Ding <shenghao-ding-l0cyMroinI0@public.gmane.org>
> +// Author: Kevin Lu <kevin-lu-l0cyMroinI0@public.gmane.org>
> +//
> +
> +#ifndef __TAS2781_H__
> +#define __TAS2781_H__
> +
> +#include <linux/kernel.h>

I've not chekced in details, but is it really needed?

I've been told once, that we should try to avoid kernel.h in /include/


CJ