Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   mirimmad@outlook.com
To:     gregkh@linuxfoundation.org
Cc:     Immad Mir <mirimmad17@gmail.com>,
        Ivan Orlov <ivan.orlov0322@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH] powerpc: fix debugfs_create_dir error checking
Date:   Sun, 28 May 2023 13:16:44 +0530
Message-ID: <CY5PR12MB64553EE96EBB3927311DB598C6459@CY5PR12MB6455.namprd12.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY5PR12MB6455:EE_|PH7PR12MB6881:EE_
X-MS-Office365-Filtering-Correlation-Id: dc3f02a5-fc02-4bca-6bc0-08db5f4fc6fa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8lpoaBXq7EYViZfOVTqgnP+WRXOrz9OCwatIpUWbX+xy6upcLAdUgjMZNRJxFypEoT6PD2vErYBdQE9ngoavhqxjKFi9KIJbpmmtAveqww2/ym49L9GidDAC+KiVxorGwoSS8R7wWWnzJZWV/mfG701cNNft/JK7Gk4VxzoCjE1KdoFAzy/i3xNSFYuh4wRDTjVfOA30sS74Vy7P9HSlNkbmFKY5CYqc1cAdbUotEy8DMWYqH7nspRNuJXKxWGonzWtNnDu4CKUY5O1/SnUqRbi3BObapQUsj+lSQw1jdDDuCJgYI4bMkii/QIHLv6ghCFIAcodAHDYa9Eep1SHMiblyQrPJbnEAzjCfQq5JafKE4fZYRa1RQKespWk7qu9GMoaf8rDnNPextQVpmCi+iV26W2rAZz5mB47luyn+0wuLFDSQnrA81UB/HRBJbkPhlFX3RyTFKHzCM/ZZ3qNLjNZ2FpEZH/HgsMKJ5bUD5l2z8uRVY9MEp1BPbzhTawblSlrDxCulHR4+J6ZrHOKd/Djo0J8enYPRajO+14oPbot4FmN3ApGICsB6mOdWIN2L
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ALtumnEaDhCjiloC6P6lqY6dJrXaKh9nX7uI/mhI5/hFve45qL7GDnPDxNn8?=
 =?us-ascii?Q?NctpbwvVg9X4OX+7Y5M7ROWFFe4fyY88QcXe0YcGmXaV/PFkeQU74yKHNUO6?=
 =?us-ascii?Q?6NRVyJnVVHMPzB8622LbkytvPxvi+6vST8ESXpSoEEMzK4KltpB984XFyGVR?=
 =?us-ascii?Q?NP2bp742Ukya4slfahr4ZMgJJJhGv6mmtHg3vRUGfCDa8+agwoLsyh6Os9P1?=
 =?us-ascii?Q?kimM9NqgzyK4hbGefTTZnD6cgziNWG6yurS7NKRiRjtUj7A6vbqwGgsFbSZY?=
 =?us-ascii?Q?n5ICP0rzJq5LJiX/uNK8MZHsLTlPAm+tB3AAIVJdhgQNJ2V5H5Uw1PVT0j2q?=
 =?us-ascii?Q?q4CcPx29qJ4tCr2/aHPdJccXrMSqcYO/C4LpfwrCpTx7m/cI8ZlxjAHoymkS?=
 =?us-ascii?Q?l8bqEwjQx+lx35zkWwrjFiTCwfMVZPghpGvz3E3LA3tM5hPP9ACtAVsr/5zu?=
 =?us-ascii?Q?Z2G0Hn8N9/J5k98TcsZUezHRRcVGyCpcvauYL68VE6B/Z7LIToDFgzxqlrR/?=
 =?us-ascii?Q?fB+pWFJjDbdji1SzUWJ5BpDqm4DlnWADr+E7jYUjQl1BxR4Uv66t+KfblBux?=
 =?us-ascii?Q?HJlUI8wwF/itlsVsrpXwI81BQmHgMKYlFelddRfpfVmZO9fyAVGPga5pMCZH?=
 =?us-ascii?Q?AIef3cVwwVp0cc9rOPHbYTF6AB9aG2EYk46aMEcm2fjTtz2PhXG4Y3KCx88z?=
 =?us-ascii?Q?fXhmk60R5jTv1ipa+aOHwd0Vw9YIp3je+6EAxZqpSGs7UknKQ9ONRcyZpHd3?=
 =?us-ascii?Q?JFt+/QzA4DMc2W3unx2ZwiFd8hdFp3lxCma8T6Ar5E5aEtIR6XzeUKT+2s2J?=
 =?us-ascii?Q?uvn8/+1VTwT/SH3LwYxK7DrKLwunKeCo4tp7Tqf8qBEY7YA+pFjyM4GxErVy?=
 =?us-ascii?Q?r7jff8yPgxSnufyGGp00jcL22hLUxH00IvahlPKCRCudTlPZg34N4dGyg/2/?=
 =?us-ascii?Q?AfBJ0Jq1JPVoChvOnX2wTeWxLMBMP1PKxzyPpcI+spl4nkv5XRXk3OTvK+fW?=
 =?us-ascii?Q?jp7g+BQiRE3EtTiuEwr3uyX+lb9YyHpyJvtsumIMmeLWj/WuvDw0Jv+IsuGC?=
 =?us-ascii?Q?XOLWJpZaZ0SmIsCs467Pph1s6sAB77cUemAGSWw0HWd053G9D8z2/DZir49M?=
 =?us-ascii?Q?pEyz6KhHkE0I8eCqBdGdbny2DFADzKv6HZcdaNDGFTYEQLWwZJAgnRVoARE/?=
 =?us-ascii?Q?mp2gmjd4o+uils1zpNzKjTaEWfEmEstoVOVmlBzyi+RsAkZrsaMg1zSuq291?=
 =?us-ascii?Q?P6R+bOikC4dSvWElkG1RzjMVCoELBGUXX7Jw1EwFwg=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc3f02a5-fc02-4bca-6bc0-08db5f4fc6fa
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6455.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2023 07:47:25.4767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6881
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Immad Mir <mirimmad17@gmail.com>

The debugfs_create_dir returns ERR_PTR incase of an error and the
correct way of checking it by using the IS_ERR inline function, and
not the simple null comparision. This patch fixes this.

Suggested-By: Ivan Orlov <ivan.orlov0322@gmail.com>
Signed-off-by: Immad Mir <mirimmad17@gmail.com>
---
 arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c
index 6b4eed2ef..262cd6fac 100644
--- a/arch/powerpc/platforms/powernv/opal-xscom.c
+++ b/arch/powerpc/platforms/powernv/opal-xscom.c
@@ -168,7 +168,7 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn,
 	ent->path.size = strlen((char *)ent->path.data);

 	dir = debugfs_create_dir(ent->name, root);
-	if (!dir) {
+	if (IS_ERR(dir)) {
 		kfree(ent->path.data);
 		kfree(ent);
 		return -1;
@@ -190,7 +190,7 @@ static int scom_debug_init(void)
 		return 0;

 	root = debugfs_create_dir("scom", arch_debugfs_dir);
-	if (!root)
+	if (IS_ERR(root))
 		return -1;

 	rc = 0;
--
2.40.0