Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 28 May 2023 01:17:07 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     "Wen, Qian" <qian.wen@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        Kai Huang <kai.huang@intel.com>,
        Zhi Wang <zhi.wang.linux@gmail.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH v13 019/113] KVM: TDX: create/destroy VM structure
Message-ID: <20230528081707.GB1234772@ls.amr.corp.intel.com>
References: <cover.1678643051.git.isaku.yamahata@intel.com>
 <7c011a5c9dd92cfb9074297af22d132a4e57fd11.1678643052.git.isaku.yamahata@intel.com>
 <fd9359f2-f65b-745e-c984-b9c53a0f5ba1@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <fd9359f2-f65b-745e-c984-b9c53a0f5ba1@intel.com>
Precedence: bulk

On Tue, May 23, 2023 at 04:17:07PM +0800,
"Wen, Qian" <qian.wen@intel.com> wrote:

> > diff --git a/arch/x86/kvm/vmx/x86_ops.h b/arch/x86/kvm/vmx/x86_ops.h
> > index 8118647aa8ca..8f87eeeab97c 100644
> > --- a/arch/x86/kvm/vmx/x86_ops.h
> > +++ b/arch/x86/kvm/vmx/x86_ops.h
> > @@ -139,19 +139,28 @@ void vmx_setup_mce(struct kvm_vcpu *vcpu);
> >  
> >  #ifdef CONFIG_INTEL_TDX_HOST
> >  int __init tdx_hardware_setup(struct kvm_x86_ops *x86_ops);
> > +void tdx_hardware_unsetup(void);
> >  int tdx_hardware_enable(void);
> >  bool tdx_is_vm_type_supported(unsigned long type);
> >  int tdx_dev_ioctl(void __user *argp);
> >  
> >  int tdx_vm_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap);
> > +int tdx_vm_init(struct kvm *kvm);
> > +void tdx_mmu_release_hkid(struct kvm *kvm);
> > +void tdx_vm_free(struct kvm *kvm);
> >  int tdx_vm_ioctl(struct kvm *kvm, void __user *argp);
> >  #else
> >  static inline int tdx_hardware_setup(struct kvm_x86_ops *x86_ops) { return -ENOSYS; }
> > +static inline void tdx_hardware_unsetup(void) {}
> >  static inline int tdx_hardware_enable(void) { return -EOPNOTSUPP; }
> >  static inline bool tdx_is_vm_type_supported(unsigned long type) { return false; }
> >  static inline int tdx_dev_ioctl(void __user *argp) { return -EOPNOTSUPP; };
> >  
> >  static inline int tdx_vm_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap) { return -EINVAL; };
> > +static inline int tdx_vm_init(struct kvm *kvm) { return -EOPNOTSUPP; }
> > +static inline void tdx_mmu_release_hkid(struct kvm *kvm) {}
> > +static inline void tdx_flush_shadow_all_private(struct kvm *kvm) {}
> 
> typo? This function tdx_flush_shadow_all_private is not used anywhere.

Right. It was carry over from the old versions. Will remove the line.

Thanks,
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>