Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87pm6km1lr.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Herve Codina <herve.codina@bootlin.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 9/9] ASoC: simple-card: Handle additional devices
In-Reply-To: <20230526150702.2555143c@bootlin.com>
References: <20230523151223.109551-1-herve.codina@bootlin.com>
        <20230523151223.109551-10-herve.codina@bootlin.com>
        <87mt1u7fql.wl-kuninori.morimoto.gx@renesas.com>
        <20230524141411.28765782@bootlin.com>
        <87v8ghgtyu.wl-kuninori.morimoto.gx@renesas.com>
        <20230526150702.2555143c@bootlin.com>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Mon, 29 May 2023 00:18:48 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AM/Uk+heMwfkovgNXLhZ6dQ/59LRRhb173Aaa9veDTAGFbMm08lPGhn10TPF?=
 =?us-ascii?Q?ST/rxjjJ7fdezYLP8/hPmekk09lwZCmJIDFxgKPVViUf9DeW6q6jhtKiAHfJ?=
 =?us-ascii?Q?b2C7pg9vFEXy7sX1M2+I7FcYjvtdhQGEHGF36z+hWNQIECpwSt0wztQrD2e1?=
 =?us-ascii?Q?BkYvv4vCT4FxQrHySSMyTkLnVhGzQNlijStQz8cVRVs73MsZKuL7btpXHRKn?=
 =?us-ascii?Q?1oe6i+lWtHK2j2Q9uP+L+qRyr/wsKM0cleqdvUG+F+pN0Dr4oxVy7IjHwYhk?=
 =?us-ascii?Q?tbgG53zBcZUAn/1uInzNyQedeEuwfa76IVqTKXQUmJRKijsOs1coKLJ/28o8?=
 =?us-ascii?Q?gWYgUBfj+2DDrD2iSGLrr5peqJ0E6c41xF35fhExVR+lyf7yI3nPOqRI2C+b?=
 =?us-ascii?Q?9poIPiA4iFJ3lGTWQ7BfJtlZwLubEWqnIE6NQgdiQgxbzVQhWzbMW3U8i9fX?=
 =?us-ascii?Q?PZDOAqni27XDYuI2JMV+OBZb1zBrdgi5G7yln88Ai1tasDtb9WZtuM7gX/TU?=
 =?us-ascii?Q?wrVBfHNSSOemCiINBMpPfYrI81j4ca/60xC4Na9P/4iWRhA2GDCV2/TIMkFi?=
 =?us-ascii?Q?07vbVbMciQwPfIuQZAI66t5CYzenaKANThcdaNyn7950C+bYF0niCfVEw+AA?=
 =?us-ascii?Q?6jfdYh/8XHkc4JzOFzpQsH1JBdTh/ehEQd67QhstG9qvHRjFlfySjo4ORMfe?=
 =?us-ascii?Q?o/YuDR5MaZIQB3r+k9MnASPg+2ROOzoCafUsaRbyT+FVHOumxgN8EflC0laF?=
 =?us-ascii?Q?6E0m7oUM8iImikPsO73xCl0wvx9tYE64XuWpMOfGRJDiLnW+3HhYNJt2IRY9?=
 =?us-ascii?Q?9CEROEm0lZszp+41JPeq6yfp7mKGYzbxaiAOkfgZc4ZoUuMLkXz5zMFKInGY?=
 =?us-ascii?Q?JJ0DaDYpKaHjFj7bqqxx5Urac1R2yhFVAwHFHxUK4lX++pJKgh/Qy6w48RQN?=
 =?us-ascii?Q?LLT0f3j+GSYCkcQuOBnfeJQ+AIeIO46/ZLFKjfkgjb24slY21ZotaBu6vQG2?=
 =?us-ascii?Q?wUDRc2sFgDpr2tBzj7jsQShtuVzDntnEIr7erAh7cDFUYdRlPrdeXZlvQFyg?=
 =?us-ascii?Q?XE4ZJTpKpVdM8JKUkxEQQ/nvDLEVyMfneLii8s10ECjZ6fFmIadwUrFTt4aO?=
 =?us-ascii?Q?4XCfZ2B5DZcje/fpAuSfG1rEa+K3y8ALZxp+oqOkc4HNZG00r4zuNbYHc3ci?=
 =?us-ascii?Q?DqPFU5LtBlJsDttHQs2tSiPs1Lk/hlgSGXHXRtexTRvgTXVr7hhO7NZXluz0?=
 =?us-ascii?Q?Sq0disf1iqNEl8G6mTIQY5kO07svc/RPH1Rsyrr1xY/jRBdJpZLtOFE5QT8U?=
 =?us-ascii?Q?56NrcGLumb+8sylIWA5KqPEVDo57kJtUXwhm8kBRGzcFpADOTZmlSjgdwSed?=
 =?us-ascii?Q?fq84F8biG9Aesvi/7TRbrHDAULoREmW0rfgz3SMtFhOcQgFxlFh3W0uFxv4F?=
 =?us-ascii?Q?BWktGQupIKml0DjLU5FxmbXUqr8uLBXr+PIV8HaWv7P53vCuRS5nFTO8Hh2u?=
 =?us-ascii?Q?34CjAqMVIgvRBYki6OrgIxROOG88zWzq6C2m2ZC6YWXVfRUeIRDHMGgAD3By?=
 =?us-ascii?Q?TIodRXA4VluD2aIxtXs2FG+lKxhMWukUsAUqHfqCTRWyny/x0yp2OQ33pi+L?=
 =?us-ascii?Q?RjycrT8/l8CNHZKGwdKlMOU=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83cf4919-af94-4b78-f17b-08db5fda4667
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 00:18:49.3872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: afeZzVUBG9eix7xmRUqk25nwCSNhB7F6lBpgrV4dmoLYHHj+xNEMq+6udteF/B/K9TJDSBZLAYwAS+PDf6v3/G1fWs2eWWHKTNH9pc6fYkElN1AZZO/0LVk48A3mlOZW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB9886
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Herve

Thank you for the reply

> > 	static int __simple_for_each_link (...)
> > 	{
> > 		...
> > =>		add_devs = of_get_child_by_name(top, PREFIX "additional-devs");  
> > 		...
> > 	}
> > 
> > 	static int simple_populate_aux(...)
> > 	{
> > 		...
> > =>		node = of_get_child_by_name(dev->of_node, PREFIX "additional-devs");  
> > 		...
> > 	}
> > 
> 
> Well, of_get_child_by_name() is called twice to retrieve the additional-devs
> node but for very different reason.
> 
> In __simple_for_each_link() to filter out the node as it has nothing to do with a DAI.
> In simple_populate_aux() to take care of the devices declared in the node.

I thought it is better to handling "device" and "filtering" in the same place,
if it has "additional-devs" on the DT. Because we don't need to filtering
if don't need to care about device.

But this is very small detail, not a big deal to discuss about for
a long time.

Thank you for your help !!

Best regards
---
Kuninori Morimoto