Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <09e24386-de63-e9e9-9e7f-5d04bad62d83@amd.com>
Date:   Sun, 28 May 2023 20:14:28 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: Regression from "ACPI: OSI: Remove Linux-Dell-Video _OSI string"?
 (was: Re: Bug#1036530: linux-signed-amd64: Hard lock up of system)
Content-Language: en-US
To:     Nick Hastings <nicholaschastings@gmail.com>
Cc:     Salvatore Bonaccorso <carnil@debian.org>, 1036530@bugs.debian.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, regressions@lists.linux.dev
References: <ZG3mbc3zdR4KcUW/@eldamar.lan> <ZG6cY8xjfob4Bvcs@xps>
 <ZG98fQ+MD4O0nGGE@eldamar.lan>
 <168471337231.1913606.15905047692536779158.reportbug@xps>
 <ZG/8cxxTJ9ZzrVPQ@xps> <ZHCYRmD7YeIWoy2W@eldamar.lan>
 <168471337231.1913606.15905047692536779158.reportbug@xps>
 <ZHKrC4/G6ZyvRReI@xps> <ZHL5cCNUzVdleiag@eldamar.lan>
 <ab12984e-be17-903d-ba0a-f9c85b8c544f@amd.com> <ZHP4IqxBUPuVRvRV@xps>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <ZHP4IqxBUPuVRvRV@xps>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0ZrRThPUDUralFhQWdwa0sxdjV5SGZYR0MySkxjaHAwVzNMR29idzUrcFRQ?=
 =?utf-8?B?RlBNcnlkME16UE54VVlEb1lVT291S0JpZlhTWFJDcUg5bG1mMUZvMUpLSFpP?=
 =?utf-8?B?VlY5clFlUVhUbmpUSzdVVTdrZmFPVUpwcTBVaDJqemJteENyeUUvNnRqZjN0?=
 =?utf-8?B?Rmx0VVVnczdhWW1KcG14ZmJhRTZ4U3ZidUpVaTVWd25SVGQxZWFSR29pdjNl?=
 =?utf-8?B?T1JQcGFJTXppRjc5QjNyaW9qTzhVMnY4bmsrYXYvdjFueEZZZ0VhR2VSVWZQ?=
 =?utf-8?B?VVJ1NERoUTdoRVErYnVZWWtFMGFJQlI4UXRmM2J1K3hybVhRN0JaZTJmaFU1?=
 =?utf-8?B?R0VpNHhtaHpyNlVrMUlBelBDN0RJVEpLaEl0T0JYZ04zanBVT2ljT1o4RGJN?=
 =?utf-8?B?Tk54QytHR3pXNEkzMVNkcG1xMWRET1RjSC91SG96bklIS3V3clhYVjdzWEh4?=
 =?utf-8?B?ZjNuYVZDU3Q3bkcvTXl2dWFRS2trcGlaclNYdEQrYVMyaXhpSDFvblo1RFp2?=
 =?utf-8?B?QWpIVmhKeVlWNytkUXl1UXRoMml1dmhZU1IvdHFuVVZPTXdiQllYcmQvZHpD?=
 =?utf-8?B?S1QreTBmNHZLSlBjTGg2MXFlNWNoUWdLM0dodWptLzVrU0FPQWZmZ2dJazhm?=
 =?utf-8?B?M09wL2dsd2ZRWDdWRi9ucE82d2s2d1h1SjkzTVdndyt5M1RSOE5uK1pDeTFE?=
 =?utf-8?B?WUtpT3pjVUhBc2J1TjNVZXRZYnBhYjU0ZTcyc1YyaTA4MklSV2RhMWl0SlJi?=
 =?utf-8?B?UHlRT3Q2dlpCMFBXemNMejZlQUc1ekNmSWtTcTM3dkM5b3BudnMzeHp3MUJj?=
 =?utf-8?B?MUVuYzZ6VVhJdUJXeUIyNEl2ckNnSzJIVXFmMmdta1JyeGV0YTBOZVhIVGxw?=
 =?utf-8?B?VVNZMXUvVFVDakFFVkpGcXJTM3g5Y1ZLZFZGZzZHYnIrU3dDZFZHWkFKUldo?=
 =?utf-8?B?Zm1Gc3pjUnBYWWthT2JFdFd3TFU0aGl3aHphMlBwUGxySVRmMHRyT01uSDdw?=
 =?utf-8?B?WS90QldWSXhLOTBmdmlkT3luYWNiaU5pL3dVY0tVRytxQ3c0eEF4QUFyNzNo?=
 =?utf-8?B?VzBYWGl5aXVxTmRqdmN0MjdTa0FQYVE2TUcrQlgzcE8yV1poRFMvYUxHWjcv?=
 =?utf-8?B?NUF5bCt1ZWJZc3VJZWNsMnZiZmhidmtNNEQ4a0drWHU5K2N0Vy9KQ0RNNGR4?=
 =?utf-8?B?TkpsMnNqczJscUhUcVFPUml3K3hEWnQ3cGtzejJEMUFveWIwVm9OSm1yM1Zo?=
 =?utf-8?B?cE5Ta1FFWFlyUEc2MllwM00zWkRlLzRZeGR2L1N0emxmR0JIcjJvb0RnVExv?=
 =?utf-8?B?RjBwZ0gvbHRKcFUvbkRxZ3JsOGcrTjhEalQrRUxLZDBhdGZqNGUwS0o0T1dG?=
 =?utf-8?B?aXArU2w3M01PcFRYQUdGVFNjcFcyRmxiVE9SU3MzWEVLakljRC8vdEl6SlBJ?=
 =?utf-8?B?NEtFZVAxaUxtczJsSk9pbmM0MEdjcDUydVVZVzduc3JpaThhdzFZU2xMWDcw?=
 =?utf-8?B?dS9FU0MwN2RaZkYyZVRITFRUQmlVR3dKK0NqK2VsTDdncUJGQVN4dDlsaXVk?=
 =?utf-8?B?SHZlaVdnZDJGQklxbG82eXhxUlNyQ01qWHI0NXd4YzhpSHp5MWREdDhTd0Ew?=
 =?utf-8?B?K3hwSnNvNE5aRDNXNDRaVWZaWXREZThZTUxha0kyc1VENE9hMmJIZlNXSWFR?=
 =?utf-8?B?WXF3WUlhL1Y0cTZEWTBOampIZ1dxbjVwWC9xY1B0a0c4K2lXSTlZclQ5SEFi?=
 =?utf-8?B?aDBTR1JZQnJhN1lIbVdWdk1VNkhidmFLRGdpY1g4dFJidlNQNW9aSTJUOWlw?=
 =?utf-8?B?elVOVUNhdWRVd1YvODR1dXBZbEk0US8yMlRuODZHR3JBZ3hLZkoyUU82b1hM?=
 =?utf-8?B?dEZVVGJyZmIrUlNlSjZQbitiS0oyRVlyeitaeFBQR0hQSEVJQmErZCtTZVFm?=
 =?utf-8?B?enRsNW81ajk0UE5aRDZ4Y3BER2xla3J1TEhlaUwvSVdhTWRDdHBvM3grVDB0?=
 =?utf-8?B?bW05NERXbzEwbThwVnhqN3Y5cGh0aVRrdUFUajErRmtuK09zMXZrVmU1cHJp?=
 =?utf-8?B?dWo4eEdMRUMzYVlMZjFzMUJUN3pPOUhNeWorb0FEVkVuanVaRDBZOGxMTDI2?=
 =?utf-8?B?SFB6eXoxVXFqTVJ4T1ZqMUgwMzZ5Y2JTK3JEZC9ocE95SzU2WEE5RXQwSUll?=
 =?utf-8?B?S2c9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e85fbd61-e12b-41d8-3dae-08db5fe20e3a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 01:14:31.0547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IWKLG4hgZJRrHVwWPO6JbFL3TrnHnm9DNSnf3d/24CLYpr1vipxxjsDy8Mus4vbW+ro8Sf729mRsTDcQsRtMgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9099
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/28/23 19:56, Nick Hastings wrote:
> Hi,
> 
> * Mario Limonciello <mario.limonciello@amd.com> [230528 21:44]:
>> On 5/28/23 01:49, Salvatore Bonaccorso wrote:
>>> Hi Mario
>>>
>>> Nick Hastings reported in Debian in https://bugs.debian.org/1036530
>>> lockups from his system after updating from a 6.0 based version to
>>> 6.1.y. >
>>> #regzbot ^introduced 24867516f06d
>>>
>>> he bisected the issue and tracked it down to:
>>>
>>> On Sun, May 28, 2023 at 10:14:51AM +0900, Nick Hastings wrote:
>>>> Control: tags -1 - moreinfo
>>>>
>>>> Hi,
>>>>
>>>> I repeated the git bisect, and the bad commit seems to be:
>>>>
>>>> (git)-[v6.1-rc1~206^2~4^5~3|bisect] % git bisect bad
>>>> 24867516f06dabedef3be7eea0ef0846b91538bc is the first bad commit
>>>> commit 24867516f06dabedef3be7eea0ef0846b91538bc
>>>> Author: Mario Limonciello <mario.limonciello@amd.com>
>>>> Date:   Tue Aug 23 13:51:31 2022 -0500
>>>>
>>>>       ACPI: OSI: Remove Linux-Dell-Video _OSI string
>>>>       This string was introduced because drivers for NVIDIA hardware
>>>>       had bugs supporting RTD3 in the past.
>>>>       Before proprietary NVIDIA driver started to support RTD3, Ubuntu had
>>>>       had a mechanism for switching PRIME on and off, though it had required
>>>>       to logout/login to make the library switch happen.
>>>>       When the PRIME had been off, the mechanism had unloaded the NVIDIA
>>>>       driver and put the device into D3cold, but the GPU had never come back
>>>>       to D0 again which is why ODMs used the _OSI to expose an old _DSM
>>>>       method to switch the power on/off.
>>>>       That has been fixed by commit 5775b843a619 ("PCI: Restore config space
>>>>       on runtime resume despite being unbound"). so vendors shouldn't be
>>>>       using this string to modify ASL any more.
>>>>       Reviewed-by: Lyude Paul <lyude@redhat.com>
>>>>       Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>>>       Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>>
>>>>    drivers/acpi/osi.c | 9 ---------
>>>>    1 file changed, 9 deletions(-)
>>>>
>>>> This machine is a Dell with an nvidia chip so it looks like this really
>>>> could be the commit that that is causing the problems. The description
>>>> of the commit also seems (to my untrained eye) to be consistent with the
>>>> error reported on the console when the lockup occurs:
>>>>
>>>> [   58.729863] ACPI Error: Aborting method \_SB.PCI0.PGON due to previous error (AE_AML_LOOP_TIMEOUT) (20220331/psparse-529)
>>>> [   58.729904] ACPI Error: Aborting method \_SB.PCI0.PEG0.PG00._ON due to previous error (AE_AML_LOOP_TIMEOUT) (20220331/psparse-529)
>>>> [   60.083261] vfio-pci 0000:01:00.0 Unable to change power state from D3cold to D0, device inaccessible
>>>>
>>>> Hopefully this is enough information for experts to resolve this.
>>>
>>> Does this ring some bell for you? Do you need any further information
>>> from Nick?
>>>
>>> Regards,
>>> Salvatore
>>
> 
>> Have Nick try using "pcie_port_pm=off" and see if it helps the issue.
> 
> I booted into a 6.1 kernel with this option. It has been running without
> problems for 1.5 hours. Usually I would expect the lockup to have
> occurred by now.
> 
>> Does this happen in the latest 6.4 RC as well?
> 
> I have compiled that kernel and will boot into it after running this one
> with the pcie_port_pm=off for another hour or so.
> 
>> I think we need to see a full dmesg and acpidump to better
>> characterize it.
> 
> Please find attached. Let me know if there is anything else I can provide.
> 
> Regards,
> 
> Nick.

I don't see nouveau loading, are you explicitly preventing it from 
loading?  Can I see the journal from a boot when it reproduced?