Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>
CC:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V3] soc: imx: support i.MX93 soc device
Thread-Topic: [PATCH V3] soc: imx: support i.MX93 soc device
Thread-Index: AQHZhvcGw2nYob3zLEmYd1JxpO1fJq9pecCAgARgjICAAtQdEA==
Date:   Mon, 29 May 2023 03:33:44 +0000
Message-ID: <DU0PR04MB9417C357D4A919288E4D42FA884A9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230515063730.2042715-1-peng.fan@oss.nxp.com>
 <33d57180-aa13-4178-86e1-c4cf6ef29a6e@prevas.dk>
 <20230527082037.GB528183@dragon>
In-Reply-To: <20230527082037.GB528183@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UlMuHLRBR1FmchAKre7MnZ0SC0z3OsBuqKAom95pP1aJe4YiFbSbU9xtdbmC?=
 =?us-ascii?Q?wR3XBf9zA9yZqQtO5cEs4fCR/iMZEdigHOrSwRyrhIepv/DQABHHWZKVTMA+?=
 =?us-ascii?Q?qLNiiObrthLV+k8fq07WgL1fsFqvtrJMqaqWGxBQS1Gya5vWaRhD6xKNmPUj?=
 =?us-ascii?Q?WWpf1W5e0C4wK9hX1r+HJGeadQ0GRIF+1bU6/XqvVPCDuYdkrqj47XiVLGsj?=
 =?us-ascii?Q?nSC0Ft2T8Dim8KVPv9FU+8PC86tv/RMR9KHrID2Efc8VwDTUY8xzBSCtm1CL?=
 =?us-ascii?Q?v12MdNSeBI5cZhEFyv6bc1o2elGJs+UH3bmjfHOUHYKGAAy976eKKanOvdMC?=
 =?us-ascii?Q?FVZAkcnTIbwW4fOc+Nn5BFPvHVQBWAJ6FYAj5YtPXZHmcx+SBHSMFzZt8UtV?=
 =?us-ascii?Q?qFFBX6l7kleIO6cicSqzIEwRle6LB347aXmuUdlUHC9mHh0MOMZpUuFOtJGg?=
 =?us-ascii?Q?3TtQam9KfMe62WyXYhT0NJfW2VpT5pL/i7iEGEqdfQ+JqLUpg/7gjiFJ7S2W?=
 =?us-ascii?Q?r99DAh86iAOoxIChVvlSupFi0HxoyjWdbuf2ChvkeHiyBVweUe6CJcbXVGJ5?=
 =?us-ascii?Q?PWF7GKDWswWgFcEYkhRAZeLxqrPdrKMM+pvnpdGiQwZwrO6IHBR1shS2Wqh9?=
 =?us-ascii?Q?3s3e4uv9tq+8JA5kLFDlLHBxvATi7gUgSbiwdHXJSUksPRsTjaXwazY4cQcX?=
 =?us-ascii?Q?QwegJ1jXJa1ugQQknxUS8pMHz5F/f6BxS4JMgxITsLzRpfq6PbPJRpUpakob?=
 =?us-ascii?Q?9WahTkWYnH+dVmdA0G8RtvmlB6YWOrntYpBFc2YMBL4meNy22pWt8EI6fnqj?=
 =?us-ascii?Q?cdVC+O0MVmeKt/GJc1HUTU5ManjLoi9XEKF6oqEk0XzRphG01QD5RqffjhHv?=
 =?us-ascii?Q?8XvtVwKzMIXgQQXe4TrWTeArO6K9hf0MaNL8EmBlJApom4kHId3qb1tBIpAK?=
 =?us-ascii?Q?VTBmNKaeSPoi0SByXsUFEtoqnYJdNKT8HhEoZ3E+JZAkVU5A8xlnKwyXaBHj?=
 =?us-ascii?Q?Bgg1sCOnMfAvZeNP3XPsK4flqK+RUVfafx5MZfsdkQK5u/QuEw7OfCrLsIim?=
 =?us-ascii?Q?1ypoZLpkAwyfyVuB6sO3MXNF/H+zDP5faTAky1tk3DswW7U2LZFuOND0hhbI?=
 =?us-ascii?Q?XgigPafzgQ7UhBKTqT7OZlFz9dRstmXCKdpaQHqlpIsvXUwRFgk2mezRRatt?=
 =?us-ascii?Q?cXsl71AqRQwoooiCU/9i0DngrliFs/TYOwmjWlkvw1p8myxEYtujduBJ/CY4?=
 =?us-ascii?Q?vlNSQ/pUwNttaxVq7x4yXnwBDhWgerFhtoeZYYrRugOcz/KvNhFO2a1fHYMT?=
 =?us-ascii?Q?I9FsTiHb3uKS39UnJKT+1oRwY8EAU2R5HEmVb6GZDpDdfG/yLeVuAKPJkHSE?=
 =?us-ascii?Q?crKXijHffQaFDB5Cmy9xDPATn527fMch8kcP8jcZk2RxQ4W6V/sbtwZGz29E?=
 =?us-ascii?Q?AgTt6NRN6FrG8ms8jeAmrqoC8uSSDCuvnFmYDHXCzbEM9Y37NF4zG/gEGa8T?=
 =?us-ascii?Q?5MTKbA/4vYXGWR9YLBFIDAYcFu33IxtntScR6pPTC0IU3Ampj05K1yvoYrQ2?=
 =?us-ascii?Q?+oCDi9ULaOlTxRdH6Vo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8d998aa-a490-4f01-4aaf-08db5ff58163
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2023 03:33:44.4917
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6krw3sM8OXz7JSNgGw0t6JepnfYJ16UaTZsaA6KQbM1OaCPigKGGbQKOeh+pXfq7ihLOdZAv3PUsZVd2fH7mRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9062
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shawn,

> Subject: Re: [PATCH V3] soc: imx: support i.MX93 soc device
>=20
> On Wed, May 24, 2023 at 03:30:01PM +0200, Rasmus Villemoes wrote:
> > On 15/05/2023 08.37, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > i.MX93 Device Unique ID(UID) is in eFuse that could be read through
> > > OCOTP Fuse Shadow Block. i.MX93 UID is 128 bits long, so introduce
> > > soc_uid_high to indicate the higher 64bits.
> >
> > So apparently, the imx8mp also has 128 bits, at least according to the
> > reference manual, which mentions a "UNIQUE_ID[127:64]" at offset 0xe00
> > -
> > 0xe10 (i.e. bank 40, words 0 and 1).
> >
> > However, no further mention of these upper bits can be found anywhere
> > in the RM, or in linux or u-boot, mainline or downstream NXP.
> > Furthermore, quick experiments on both an imx8mp-evk and a custom
> > imx8mp board reveals that those words are not locked down (they do
> > seem to have some contents from the factory, but I can still set more b=
its
> in them).
> >
> > Could someone from NXP please explain what exactly bank 40, words 0
> > and 1, on imx8mp are for? What do their initial value mean, why are
> > they not locked down, and why does the RM indicate that they should be
> > part of a unique_id?
> >
> > Also, assuming that the RM is just wrong (wouldn't be the first time;
> > the description of the lower 64 bits is also wonky in its own special
> > way), an obvious follow-up question is: Are the currently exposed
> > (lower) 64 bits unique among all imx8mp SOCs, i.e. does those 64 bits
> > by themselves actually work as a uid?
>=20
> Rasmus,
>=20
> Are you fine with the patch itself?  Or do you expect more clarification =
in the
> commit log?

Rasmus's comments is for i.MX8MP, this patch is for i.MX93.
But anyway I just sent out V4 patch to address i.MX8MP support and
then add i.MX93 support.

Thanks,
Peng.

>=20
> Shawn