Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cbca803c-c9b2-f851-6cf1-f9ed0223de13@amd.com>
Date:   Mon, 29 May 2023 09:35:37 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 0/9] perf/mem: AMD IBS and generic tools improvements
To:     peterz@infradead.org
Cc:     mingo@kernel.org, eranian@google.com, kan.liang@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        leo.yan@linaro.org, kjain@linux.ibm.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, Namhyung Kim <namhyung@kernel.org>,
        acme@kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230407112459.548-1-ravi.bangoria@amd.com>
 <CAM9d7cijvZBsaXTMm8d=sxUWy6s+umCCnWhunD3KVhKbpVp_-A@mail.gmail.com>
 <631876a2-5946-82d5-6f70-bf7734db3992@amd.com>
 <bd4f84ff-640d-02bf-1abd-58bc8362edb8@amd.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <bd4f84ff-640d-02bf-1abd-58bc8362edb8@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHQ1OXZyNXRyVTdhQ0MzUE5GZGg3Mno3VlZCNDl2Y3lNOTNwUzZVUjhTa2xG?=
 =?utf-8?B?QldwRUhzd25BK09pUGZnL1ZmRnYxR1lIVVNKeWxFYXJpdkkrZUpORzArL2dK?=
 =?utf-8?B?RVgrenJvS09CYXgxYndFaHI5c2p3VXJkc0VQRk1UdzJ1RG4rbmQrTEVpRG1m?=
 =?utf-8?B?QlV4eDM5cG5CSkhHNlBvRWtXRW1ybTBrajZmcyt4ODRCS3dpL0phbGZmS1pB?=
 =?utf-8?B?YUpvcXYyTzZEcnVoNWNidDljeDA4ZFhrOVo2R2I3VmwySVBFQmpWdHRHMTNQ?=
 =?utf-8?B?SUdNWVdWZWtTdWZoZjdxWWpLWExENzNXQ2pjSTBKL0dGeENSNlI3a2xVVE1i?=
 =?utf-8?B?SWVPdVRER05icktmWGxtNmZDK0lRU2tRYVFEZDlDRW5rNUtCL0lBQnF5dEdv?=
 =?utf-8?B?d1FMUzNQM1dFckZpWmRNNHBxNi9OSHk3bmlXNStaei9xWEk0bmRaNlFVc3V1?=
 =?utf-8?B?cWZQVXJjRDFKNlRkbFRvY3lnM2NtOVIwK212VzRTS1MyWlIvbzV6TStZT01D?=
 =?utf-8?B?NWtTU0loakIxQTZ6b1dHTnVyK002TlRUT3ZpMkZpUXRUMkl0SzF3RWtlZjR6?=
 =?utf-8?B?VWJjZGV3bll0UUVpdDVMYzhpNFBTRmVSUEsyUlpXaEVtbkdJamRRQ0sreVFV?=
 =?utf-8?B?bllzc3oxZlg1V2xMQXZsakN4OEZsOVJRblhqd1o1VnFIRjJtMlVuU2tjd2d0?=
 =?utf-8?B?YzZkOUtRUXlhbVhsUDlrMFpPR3lIb09GM0pDRndKTlBjUUNrQVBZeS9ZakxJ?=
 =?utf-8?B?WnE5UmVKK2J4SlpRUE5adldUM2Vvbys4ekpPMVQwUTVQVm1EUEw5WWY3c3pP?=
 =?utf-8?B?VTF3VndHckFIazhsSzdjYTE1cmU1WCtpejRXN2lkaVZRMGpmU05iYkJ6ekVF?=
 =?utf-8?B?L3l0b3pRWEtLa1UxREtVdDFnbEduZ3ExNHNSTmFJTnlVSFNIMXJOcTl5a1ZC?=
 =?utf-8?B?UDRwUW9uc1Y0ekRaSVBDVkRja1lGdU9qOUh6cWJhdkpYeGhLTjJYOWJobHFw?=
 =?utf-8?B?OE90bFFyc3JsbTB5SXZGUHlrK1kxMmVDaWM2UTlINlhpRWtrQm5ucTB3akl3?=
 =?utf-8?B?SytKaG1YQmhVZE5KQTk5djFlNVViSU1Xalk1MWFlZzhXNEhVVE5aRmVPcEhr?=
 =?utf-8?B?ODBNcUJXK3IrNmhjdnk4QVdpbzhRaDRRNjducjJINkdHUHdxUGdHSERhM0dm?=
 =?utf-8?B?TFpPRFdCUmQ2bEd6UzliUkR5ZjlFL3Mya2RadjdDcy9Xb2VPSUc4aCtnZ0I0?=
 =?utf-8?B?YkxyeHV2eUZaeG81d2ZFczFKYXZpTHNNZWVLN0N3M2kxWEZyQXl5RVc2bnhG?=
 =?utf-8?B?dFFRbHB6MjI2eFVIdW9DQlVPVTNuaFR1VVBiVXlvUTBrZ1V0c3cybjVBQldM?=
 =?utf-8?B?M1JPUC9sT25uczdIODFEVXRLT0M3bDVjaDBQMGgxMG5OTzJnRUlOUGFIN0hG?=
 =?utf-8?B?OWVjblZnTFM1ZzdoMldlZVZQTHpDeG5Jd0hpUG1CYy8yWkpvSXBYZElOdHZw?=
 =?utf-8?B?YTUyT2JBVTZvTTRZb1UwT0E3RUtqM2xGTDFDY20xaERYLzNOQ2xiNS9BNmx2?=
 =?utf-8?B?b3VNV2ZTcmM5b1ljUVdXZU1XWSsxR2txZWhoaCs5enl0Vk8rSDd6RmsvdVVZ?=
 =?utf-8?B?cVBoZ1MvWWxHdHNpK3h3aUxjZnVKNHdhOHgwaHpzSlJnUDNRTEZWeE1lTkNv?=
 =?utf-8?B?Qlh1djBqU0hNc1BSWGExTW5CMFFaQytPZUx4NXFmcTF2MVFXOGQwMGZsbHdT?=
 =?utf-8?B?SzFBOXozVnVUQS9ZK1lLOTl5WnUrTzAyaFdGSjdDWFBBbFRhdmpjRFpxRUY0?=
 =?utf-8?B?QkFBZEMyTGRLOXhXTWNqSk9vRG5NZE1qdXNDRklleXdnaTdzZUFSSC9NQllm?=
 =?utf-8?B?VWxEYWtOekxmemdhY0NvdFhFbzJSZ1pSU1NIVEFobWpnakNscjRWK215ZTFV?=
 =?utf-8?B?YjlkditXVlE5MlpVRlovclpoR0xyekx0YmNMWm4zbXFXc0djUTJNOEVOUkZ5?=
 =?utf-8?B?b3RCeVR3MDJhcW1OTVVvQjgwNTFVck1wU0JMZFZscG83Qm0zV0NmWGd0OUFZ?=
 =?utf-8?B?Z2ZlUFJTVVp3KzI4RC8xYXBReXJ5WVVIQ2Z2ckFHbUpnaUtjMnpYSjZjYXpH?=
 =?utf-8?Q?mMlMKQrb4vC8jztEGNukb5Q2T?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5f95de7-cd11-4d86-ed80-08db5ffa2227
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 04:06:52.9495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IBlCeJB2usxrurnD+hYFgKe1/Fu5u2vz8w6prze/pkUKsVlafE9gKsCpfsN2ofN5SISf0T/GpCJfeIdozr283w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8345
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16-May-23 8:15 AM, Ravi Bangoria wrote:
> On 10-Apr-23 7:53 AM, Ravi Bangoria wrote:
>> On 08-Apr-23 3:14 AM, Namhyung Kim wrote:
>>> Hi Ravi,
>>>
>>> On Fri, Apr 7, 2023 at 4:25 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>>>
>>>> Kernel IBS driver wasn't using new PERF_MEM_* APIs due to some of its
>>>> limitations. Mainly:
>>>>
>>>> 1. mem_lvl_num doesn't allow setting multiple sources whereas old API
>>>>    allows it. Setting multiple data sources is useful because IBS on
>>>>    pre-zen4 uarch doesn't provide fine granular DataSrc details (there
>>>>    is only one such DataSrc(2h) though).
>>>> 2. perf mem sorting logic (sort__lvl_cmp()) ignores mem_lvl_num. perf
>>>>    c2c (c2c_decode_stats()) does not use mem_lvl_num at all. perf mem
>>>>    prints mem_lvl and mem_lvl_num both if both are set, which is ugly.
>>>>
>>>> Set mem_lvl_num, mem_remote and mem_hops for data_src via IBS. Handle
>>>> first issue using mem_lvl_num = ANY_CACHE | HOPS_0. In addition to
>>>> setting new API fields, convert all individual field assignments to
>>>> compile time wrapper macros built using PERF_MEM_S(). Also convert
>>>> DataSrc conditional code to array lookups.
>>>>
>>>> Interpretation of perf_mem_data_src by perf_mem__lvl_scnprintf() was
>>>> non-intuitive. Make it sane.
>>>
>>> Looks good, but I think you need to split kernel and user patches.
>>
>> Patch #1 to #3 are kernel changes. Patch #4 to #9 are userspace changes.
>> Arnaldo, Peter, please let me know if you wants to split the series and
>> resend.
> 
> Hi Peter, tools/ patches are already upstream. Can you please pick up
> kernel changes.

Gentle ping, Peter!

Thanks,
Ravi