Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wu Bo <bo.wu@vivo.com>
To:     chao@kernel.org
Cc:     bo.wu@vivo.com, jaegeuk@kernel.org,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, wubo.oduw@gmail.com
Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs: fix args passed to trace_f2fs_lookup_end
Date:   Mon, 29 May 2023 12:13:37 +0800
Message-Id: <20230529041337.36741-1-bo.wu@vivo.com>
In-Reply-To: <2bb05623-9438-3b68-6ac8-4294f9676ff6@kernel.org>
References: <2bb05623-9438-3b68-6ac8-4294f9676ff6@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3zmf1ZTZCwkRPROaQPg6cuEe62rrdghC6adOWYL4IFwe7OCdt3JUUFXKRLRA?=
 =?us-ascii?Q?rDVJG89O78T3mTXh1jhPNIdDELBvLA5y260gs9+40AaIpuVPOvwLYvdr+Td2?=
 =?us-ascii?Q?VOIz7O4V0DrYxoJUoXiRENVXKDbUmeCFLKVO1tD6X/5vmxCK9vkn7W08mke5?=
 =?us-ascii?Q?52ktJCqV7aCT1IT4eEx9XnZ/MNLlL8z/qYjYiy5722Cj/DxIupRRXMUTdLv/?=
 =?us-ascii?Q?TMNPiZk8jFY+HqRfWbtN6nJNPx2z2y3+8mSRO6xYsbo8aNvJIw2y3JimVplJ?=
 =?us-ascii?Q?KqnpGWJBSGZtXHA0jFxrEVVA+lvun/8oNyJ1CYh4ea5iGztibvl+x2OzudNX?=
 =?us-ascii?Q?UGIAb6crfiBJ04aBjAL5abcnau5htidbJit4j7UexvFgjCN4imdHaDpKPZzB?=
 =?us-ascii?Q?E6JTaqNN2q7JsGhk3AZyNtLyfHT2f1Oabf64Vvg7PtkbHl8mo89Ws5nwhkKU?=
 =?us-ascii?Q?ZAs2uQ1mfaLJdMVOsHtotDgIJXCzILwzWeJFiwN2ygRgMg1FGA/QdtfdpiZS?=
 =?us-ascii?Q?qd10lGOZjymthCsh0rT803XrfHZkVDQ7U/msM3PiAkHNRu6qgbyEkEyeWAGV?=
 =?us-ascii?Q?HXfyiyFQ7lPwaCo2dGj4goMvIg4jeMizikE9TrM22yT1uEmF+axrgl/Ipzdg?=
 =?us-ascii?Q?SCaKF5ZFUxjks2nyxaFIV+6i9/mQGYHsqXlXYMXYMI0ATHbcECt3kS48IV9p?=
 =?us-ascii?Q?7rDk+nR1M2Ef0pcjetCyUI2YOXEJRxMQ98wquVDekPyMMcTJWyGflaMlL2qL?=
 =?us-ascii?Q?5Pl+wqeRGv2GG4FPKxgLrG9aX1ShhNfiPiqwJzNH+yL47GAfzzjquOh97HnN?=
 =?us-ascii?Q?TToAEY/X5bzolJ/eVqkFPnbx6k1h19KI3krAYf0za3yooZE3BIE/ACDb58rb?=
 =?us-ascii?Q?JyiZC6iosecMI4mKFTjmetK3xZR3/i/yPo6r2ytoLXfnC6zCdmu0eRiBiY+b?=
 =?us-ascii?Q?VW16ntW1JZdxyfvG4tNRBrP6iuraoRaZwdKr1fZeAo15E6d+/5KzLVB6XPds?=
 =?us-ascii?Q?k+p/oOJ0TQ5c4ZNUEE5q4ItzouluXIWleR9mdgIrn1LFuPRewvh9Zl70DqyA?=
 =?us-ascii?Q?OUZO41FoRGbfw4/ikS7LLzLg2GaHWtumiqgaSKcv7SPJ8fupUjgBOvYO0liB?=
 =?us-ascii?Q?4cuTN5t6L/clNUm/sKhbkO/IuRcwhN4zAr7Zl/CZdik7ZdijeH14dCZyYqji?=
 =?us-ascii?Q?cW8rxMukWl5FontMgp0W+NMVZkmdqO+Ojd+U5BNZ+1DdL5ISE0LVQzALFIvb?=
 =?us-ascii?Q?DghGg5cFqD5EdSzQusHylRT/ch9EB8DYkDh1rI4gx8bJnFDZuQ8XKr6I7L9N?=
 =?us-ascii?Q?GoJ9bgH3tlPv9JndFXlGSo6s/cHOIdPCwSs+ecRT6dhXG4RepayWYlJEhKN9?=
 =?us-ascii?Q?y3BrCKdRzgJfla0Nk4YgPjlpyEkXcObsNebWOOyUm0/O9pCUe8g3pevnYI1R?=
 =?us-ascii?Q?5WQThFSynthyuBmapPS2QjeIzrrwxGkQ3QpQ7J3ns3RdJeF9YX2MG6vBwxHk?=
 =?us-ascii?Q?HaF1Z+bHXtWjVonuC59GIy8QWR2P2ePhYLFEK96T94LGcU8T3iUdZqhVb32j?=
 =?us-ascii?Q?XZuTSXxrH0bG3P4tg2ZZulIiYXg0Swx+s5GRx3ro?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03cd784b-6707-4ba2-13a1-08db5ffb187c
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3017.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 04:13:45.8567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YvXdksAMpLrVOpI4nZ21KrDKqS8npU7N7ibHbJANo9qpJOpVV8GSCiGEVCVCxklTsFU6mpYtjWqxWolMAPE7dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5930
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 27, 2023 at 09:01:41AM +0800, Chao Yu wrote:
> On 2023/5/27 1:21, Jaegeuk Kim wrote:
> > On 05/24, Wu Bo wrote:
> > > The NULL return of 'd_splice_alias' dosen't mean error.
> > > 
> > > Signed-off-by: Wu Bo <bo.wu@vivo.com>
> > > ---
> > >   fs/f2fs/namei.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> > > index 77a71276ecb1..e5a3e39ce90c 100644
> > > --- a/fs/f2fs/namei.c
> > > +++ b/fs/f2fs/namei.c
> > > @@ -577,7 +577,7 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry,
> > >   #endif
> > >   	new = c(inode, dentry);
> > >   	err = PTR_ERR_OR_ZERO(new);
> > > -	trace_f2fs_lookup_end(dir, dentry, ino, !new ? -ENOENT : err);
> > > +	trace_f2fs_lookup_end(dir, new ? new : dentry, ino, err);
> > 
> > Shouldn't give an error pointer to the dentry field.
> > 
> > How about just giving the err?
> > 
> > -       err = PTR_ERR_OR_ZERO(new);
> > -       trace_f2fs_lookup_end(dir, dentry, ino, !new ? -ENOENT : err);
> > +       trace_f2fs_lookup_end(dir, dentry, ino, PTR_ERR_OR_ZERO(new));
> 
> static inline int __must_check PTR_ERR_OR_ZERO(__force const void *ptr)
> {
> 	if (IS_ERR(ptr))
> 		return PTR_ERR(ptr);
> 	else
> 		return 0;
> }
> 
> For below two cases, PTR_ERR_OR_ZERO(new) will return zero:
> a) f2fs_lookup found existed dentry
> b) f2fs_lookup didn't find existed dentry (-ENOENT case)
> 
> So in below commit, I passed -ENOENT to tracepoint for case b), so we can
> distinguish result of f2fs_lookup in tracepoint, actually, -ENOENT is expected
> value when we create a new file/directory.
> 
> Commit 84597b1f9b05 ("f2fs: fix wrong value of tracepoint parameter")
I can see this commit is try to distinguish the dentry not existed case.
But a normal case which dentry is exactly found will also go through
'd_splice_alias', and its return is also NULL. This makes the tracepoint always
print 'err:-2' like the following:
      ls-11676   [004] .... 329281.943118: f2fs_lookup_end: dev = (254,39), pino = 4451, name:Alarms, ino:7093, err:-2
      ls-11676   [004] .... 329281.943145: f2fs_lookup_end: dev = (254,39), pino = 4451, name:Notifications, ino:7094, err:-2
      ls-11676   [004] .... 329281.943172: f2fs_lookup_end: dev = (254,39), pino = 4451, name:Pictures, ino:7095, err:-2
Even these lookup are acctually successful, this is a bit strange.
> 
> > 
> > 
> > >   	return new;
> > >   out_iput:
> > >   	iput(inode);
> > > -- 
> > > 2.35.3
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel