Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bharat Bhushan <bbhushan2@marvell.com>
To:     Conor Dooley <conor@kernel.org>
CC:     "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: RE: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI
 system watchdog driver
Thread-Topic: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI
 system watchdog driver
Thread-Index: AQHZj5sOTdsKm/MUPEiPdp8HUff0C69s87YAgAE8q+CAABvLAIACfT1A
Date:   Mon, 29 May 2023 06:14:07 +0000
Message-ID: <DM5PR1801MB1883D475F396D2CBA02B6D91E34A9@DM5PR1801MB1883.namprd18.prod.outlook.com>
References: <20230526062626.1180-1-bbhushan2@marvell.com>
 <20230526-bondless-slather-5de0a5659353@spud>
 <DM5PR1801MB188350DD9CFDBB3E240AC838E3449@DM5PR1801MB1883.namprd18.prod.outlook.com>
 <20230527-wiring-coping-88eba4d91f3f@spud>
In-Reply-To: <20230527-wiring-coping-88eba4d91f3f@spud>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9DxjHPVUIwvcNm2o5EeQl9d/YMdfdVjlQ0Ne2MXhve5deqFurmg0MwDvH5N1?=
 =?us-ascii?Q?LbILEb9Q1uiYE0aka4ZwZORZFhbiZtUD9N5tUNyLEN5TdzaowTQajX+g6sXo?=
 =?us-ascii?Q?JtMP6RpLUyBPeegGSyPL10aBk/mQkZlegPI61uHmS9visxpLSOVdxd+wJUoI?=
 =?us-ascii?Q?I9Brvh9pPthTi47Bx4v2BXY3LzgtDrYv8MrzPDmnyim+lWhWMAhmm4pB8NmJ?=
 =?us-ascii?Q?Cjtp6BGh3FIAx/jw9lpXV/mVZb/MXoPQPhv7DE4D5TcMsyNWcdCmOsouMS58?=
 =?us-ascii?Q?7vz3C0tUR13DbGNqY4gLB3d6YgHEvyRrfT7tmtpnS5CjspgY3a0pdivW/oQv?=
 =?us-ascii?Q?xvb/+MdYIYO58meUHHmul71ELASj0JHML1Sdw+R0WjyrEGgnJUuVjeJx62He?=
 =?us-ascii?Q?xVaPktUYR9U9fTYp/Z9+Mlo9/OF1KtEq35ycuXMD/bBheq9zJiNqnTJs29Df?=
 =?us-ascii?Q?9GQkV06f3kwKcdC1j36De+OClYnBpAxqcchqt1C2vzzFqC6CZPJzPoqbe8w9?=
 =?us-ascii?Q?P6KJ11BUzHRzjDIhP2F2o+HLqVzSPobGUjUtoCQh0Mn3l5zhPYVXWzRXih9Z?=
 =?us-ascii?Q?qaiPO2Vpw36IYMII3b6eYQ8R0Tw9QY5PGt+7HaOoJWje3J6Ovli4AHCqwQc4?=
 =?us-ascii?Q?oMbJbmkTR4/FojbFEWpJCOeIG+8ULavxpmM++STDO4sOukro6MXgmUvowLgg?=
 =?us-ascii?Q?HnaiCo8gF1LCL7YOZqsG8pbIdJHdfhvt6MM44Y0rXxYCDPMtbq4aRroVYvgu?=
 =?us-ascii?Q?O8dGQwLhekRUig8PuGSPXZmSrGy8dxk93sqFHSZn25Pd6fDLDCTfctGeESdt?=
 =?us-ascii?Q?LvB20bRGtpUeITUC/l++cZXON1A/F4Cj8busjgrI/M4MugbwVdt/A19UnlJ+?=
 =?us-ascii?Q?pD6q2I31UNr43Qi7PU/uoT7YYGblFXmjX12/37HeX16sCIPfv1a75YVNktjS?=
 =?us-ascii?Q?AXMnVWIW+ADR30HaAqzUrVsuusNBXFZ59JDVR7qXHJF8UOETfrAcECjS40IM?=
 =?us-ascii?Q?7cvkSinX3RAuntYn2CTWIzn6LUr2wg+F7DyxjiewMrxjvOutregaSyVtUbyx?=
 =?us-ascii?Q?Zd70bHldj9xgCuvPrwcP+9MoiZDFRGknIH5f8fJNmebUlVcIdcEVDb9JANNm?=
 =?us-ascii?Q?DjsPG0Nkzg4NvWmvJ0N2h7oZRV2cUaYMh05dw3m7SJ1U4FvKY5xJOTMqCBe5?=
 =?us-ascii?Q?zp8jJDBauiU8vJ69T95Syu4Fnhy1kf2NZo1FoDFjjxRFxIVxbtHLw+GkuLnd?=
 =?us-ascii?Q?zZ7rUMXVM4jNghgDmBUfILgze9aE6ewWWNs82MEu+RttI3pJQ7nh5zC0PsEy?=
 =?us-ascii?Q?HaXsJ1NcC+zYc5xJ1DkOr38k/B0dP2lL0rLqtysS684uKGiLl+2hH14eSHMZ?=
 =?us-ascii?Q?62rDEejjrJPCbYWLLvV3SDYFewshXuAMBbnPfHtzlVORnoqdwp7ssJ285cAn?=
 =?us-ascii?Q?cTI0vZfAourSAp/fJ9j7/6dbPcJzL3HkVy8zNQpkBvurxpLmvgimmce0OzWm?=
 =?us-ascii?Q?lUFt002AI8LEVCw6PUtto8dAqkOTAzaKPJBQIyrMJ/9r73HGhQiVcpSF5/Zb?=
 =?us-ascii?Q?97lvsTo/hKJ5cbdJmReuikv7Lt1BW17UKw3MKwQs?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1883.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4813c233-9a40-4e64-0444-08db600be922
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2023 06:14:07.4699
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5W2YkRnykXI+gh+/0mZbXYRVd1le3pfnyTN5nIp1bzVw19cZsa+iYxCFs8SRFO2thOK80YOxBaHIblYLGp8HDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR18MB4341
X-Proofpoint-GUID: cU_WD07jTUy9xYHgv2CoQdDm-O7TyvgY
X-Proofpoint-ORIG-GUID: cU_WD07jTUy9xYHgv2CoQdDm-O7TyvgY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-29_03,2023-05-25_03,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Saturday, May 27, 2023 9:40 PM
> To: Bharat Bhushan <bbhushan2@marvell.com>
> Cc: wim@linux-watchdog.org; linux@roeck-us.net; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; linux-watchdog@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>
> Subject: Re: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI =
system
> watchdog driver
>=20
> On Sat, May 27, 2023 at 02:53:25PM +0000, Bharat Bhushan wrote:
> > From: Conor Dooley <conor@kernel.org>
> > > On Fri, May 26, 2023 at 11:56:25AM +0530, Bharat Bhushan wrote:
>=20
> > > > +properties:
> > > > +  compatible:
> > > > +    enum:
> > > > +      - marvell,cn9670-wdt
> > > > +      - marvell,cn9880-wdt
> > > > +      - marvell,cnf9535-wdt
> > > > +      - marvell,cn10624-wdt
> > > > +      - marvell,cn10308-wdt
> > > > +      - marvell,cnf10518-wdt
> > >
> > > static const struct of_device_id gti_wdt_of_match[] =3D {
> > >        { .compatible =3D "marvell,cn9670-wdt", .data =3D &match_data_=
octeontx2},
> > >        { .compatible =3D "marvell,cn9880-wdt", .data =3D &match_data_=
octeontx2},
> > >        { .compatible =3D "marvell,cnf9535-wdt", .data =3D &match_data=
_octeontx2},
> > >        { .compatible =3D "marvell,cn10624-wdt", .data =3D &match_data=
_cn10k},
> > >        { .compatible =3D "marvell,cn10308-wdt", .data =3D &match_data=
_cn10k},
> > >        { .compatible =3D "marvell,cnf10518-wdt", .data =3D
> > > &match_data_cn10k},
> > >
> > > This is a fat hint that you should be using fallback compatibles here=
.
> > > You even had a fallback setup in your last revision, but you seem to
> > > have removed it alongside the removal of the wildcards. Why did you d=
o
> that?
> >
> > Not sure I understand this comment, Compatible in last version was as b=
elow:
> >
> > + properties:
> > + compatible:
> > +    oneOf:
> > +      - const: marvell,octeontx2-wdt
> > +      - items:
> > +          - enum:
> > +              - marvell,octeontx2-95xx-wdt
> > +              - marvell,octeontx2-96xx-wdt
> > +              - marvell,octeontx2-98xx-wdt
> > +          - const: marvell,octeontx2-wdt
> > +      - const: marvell,cn10k-wdt
> > +      - items:
> > +          - enum:
> > +              - marvell,cn10kx-wdt
> > +              - marvell,cnf10kx-wdt
> > +          - const: marvell,cn10k-wdt
> >
> > By fallback do you mean " const: marvell,cn10k-wdt" and
> > "const: marvell,octeontx2-wdt" ? If yes I removed because "octeontx2"
> > and "cn10k" are soc family name and no a specific soc.
>=20
> No, I meant that you should permit
> 	compatible =3D "marvell,cn9880-wdt", "marvell,cn9670-wdt"; and
> 	compatible =3D "marvell,cnf9535-wdt", "marvell,cn9670-wdt"; and
> 	compatible =3D "marvell,cn9670-wdt";
> so the driver only needs to contain
> 	{ .compatible =3D "marvell,cn9670-wdt", .data =3D &match_data_octeontx2}=
,
> instead of
> 	{ .compatible =3D "marvell,cn9670-wdt", .data =3D &match_data_octeontx2}=
,
> 	{ .compatible =3D "marvell,cn9880-wdt", .data =3D &match_data_octeontx2}=
,
> 	{ .compatible =3D "marvell,cnf9535-wdt", .data =3D &match_data_octeontx2=
},
>=20
> Note that using fallback compatibles is separate from using wildcards, an=
d I was
> not suggesting that you go back to wildcards ;)

Fallback you mentioned make code look simple. Is below representation corre=
ct for above mentioned fallback?=20

properties:
  compatible:
    oneOf:
      - const: marvell,cn9670-wdt
      - items:
          - enum:
              - marvell,cn9880-wdt
              - marvell,cnf9535-wdt
          - const: marvell,cn9670-wdt
      - const: marvell,cn10624-wdt
      - items:
          - enum:
              - marvell,cn10308-wdt
              - marvell,cnf10518-wdt
          - const: marvell,cn10624-wdt


And driver will have
        { .compatible =3D "marvell,cn9670-wdt", .data =3D &match_data_octeo=
ntx2},
        { .compatible =3D "marvell,cn10624-wdt", .data =3D &match_data_cn10=
k},


Thanks
-Bharat

>=20
> Cheers,
> Conor.