Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 11:43:28 +0530
From:   Kanchan Joshi <joshi.k@samsung.com>
To:     "min15.li" <min15.li@samsung.com>
Cc:     kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme: fix miss command type check
Message-ID: <20230529061328.GA11198@green245>
MIME-Version: 1.0
In-Reply-To: <20230526170656.55303-1-min15.li@samsung.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Content-Type: multipart/mixed;
        boundary="----kPHV7voJGfjLavpOfz2TLZSfqzzSedGz1kraSQUx2cheHG0X=_2b02d_"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20230526090834epcas5p197a90228102b26759f9b957c50d3bb6b@epcas5p1.samsung.com>
        <20230526170656.55303-1-min15.li@samsung.com>
Precedence: bulk

------kPHV7voJGfjLavpOfz2TLZSfqzzSedGz1kraSQUx2cheHG0X=_2b02d_
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline

On Fri, May 26, 2023 at 05:06:56PM +0000, min15.li wrote:
>In the function nvme_passthru_end(),only the value of the command opcode is
>checked, without checking the command type (IO command or Admin command).
>When we send a Dataset Management command (The opcode of the Dataset
>Management command is the same as the Set Feature command),kernel
>thinks it is a set feature command, then sets the controller's keep
> alive interval, and calls nvme_keep_alive_work().
>
>Signed-off-by: min15.li <min15.li@samsung.com>

Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>


------kPHV7voJGfjLavpOfz2TLZSfqzzSedGz1kraSQUx2cheHG0X=_2b02d_
Content-Type: text/plain; charset="utf-8"


------kPHV7voJGfjLavpOfz2TLZSfqzzSedGz1kraSQUx2cheHG0X=_2b02d_--