Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca146ce1-d3d3-e5eb-ac44-3afaec8ca6cc@axis.com>
Date:   Mon, 29 May 2023 09:41:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq
 vcnl4040/4200
Content-Language: en-US
To:     <andy.shevchenko@gmail.com>, Astrid Rost <astrid.rost@axis.com>
CC:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@axis.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Mathieu Othacehe <m.othacehe@gmail.com>
References: <20230522142621.1680563-1-astrid.rost@axis.com>
 <20230522142621.1680563-5-astrid.rost@axis.com>
 <ZHPZlA5LM5h4xmp3@surfacebook>
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <ZHPZlA5LM5h4xmp3@surfacebook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nm9sZUNsRmVnRVloeWE0Tks1aEdxSXRoK3ZOU2xUMERUcms1MXhGZXFHVll4?=
 =?utf-8?B?OWVQVTRLazlBd0E1S3lEV2g1SlByNGd2dkNLMTl2bkM4U2VodW9ZYnBYM2gw?=
 =?utf-8?B?TS9nR09ZQXJMVFliaFBkdjZSdXg5RnVuMDFnekpvUnNyTjgxOEx1eWdZYVAr?=
 =?utf-8?B?cTEza2RQVXd0ZDJEeGVBRGRUVWIzRzNxajRxNVBCQm85RXYrV0orMVRCbExO?=
 =?utf-8?B?ZXlxZlN1RWtCT1F3QnNhNHB2RDNlZ3R0d0RIVFFCMVhUYTdDRUVZeVRDSGEy?=
 =?utf-8?B?NVNVQ0hPY1hTT0VVVHd5NWd1dy9XazQwNnN4Ykh5ZzMxVVhkTmdJZk0rSmZj?=
 =?utf-8?B?UG5WMktST3hsOGlYalJ5UmNtMVJaQitqaHF0Umc1RmVkV0VrblNtRTVlTmNn?=
 =?utf-8?B?UzVHMkFxeCt0SVoxaitEeURaYzRFQlJTR0hRZnJwRU0xY0NrVDk0YjNoem1R?=
 =?utf-8?B?UXI5Z2hiTFF5aVloVXBPbHlqMGxaczJRakp6NnR6YXNpWXFvcHcyT0lLQllm?=
 =?utf-8?B?UnIydTc0SExZNGp1MmQ3M0pDSVVSZ1BnUGlzTk1kQUd4U1RES3haVkNheDho?=
 =?utf-8?B?K2pqekwxbW4yeG8wVlIvWUVMYkw2cFd6T1NzS2lBaUloSTZlbEYyNm95UTdt?=
 =?utf-8?B?eFVZb3ZBeWl1WnV6UzFNbUJvU3dkUnpHYk84QjZhV2NGbkJjd2lQTy9jOC8w?=
 =?utf-8?B?eTIxWkIzMDNZc1NiMjN3eUgxSXVEeS9Mc0JQOUVWazNidmIydzYrWkVQNUlI?=
 =?utf-8?B?RzAxZTk0NUt5dENsanJVK0JTakJZWXU2TlhwSkFIdHIxeFk1S0svdHp6Qlc4?=
 =?utf-8?B?VElFblB4akluajBhZCtOTG80ZXpCZGRjVWhITHJENkRWd3V2RjBQZjBiSUdY?=
 =?utf-8?B?VmtVbzJ0NCtsYitRRFZQQ29mUkJZYTVneUdXU1FLQlhndWc0OHFMMVVyWXg5?=
 =?utf-8?B?blA0OHVjY0JIRnZpVWRFQ1JnZlVNOThTOGJHdGhLWTNURWFHY0N4MmNwb1F3?=
 =?utf-8?B?a3VKaHAvcWVEQ24rejhlRWtDL3pKaTM4NDB6Qjl3T1l0ZkMvU2hFTUtUTEsv?=
 =?utf-8?B?cFFoYTVkSnViRVI1N000UXFPNmlGeEJ0VlA0akQrbk5wbGNkUXduNmp6eGox?=
 =?utf-8?B?Vk96b2h0WjdoMkxqK3pza25WSjA3d0xXZ0lkZUt3Q3NGQWFxdFFrUGt5UVIz?=
 =?utf-8?B?SndVSllpT1BxUVRHUjJrR01LWnVmQU8zckNJTW5KU0lROVBudkpVU3ZJQ0Yy?=
 =?utf-8?B?UUMwLytMMmcrUStpR3N0UldCMmpqTTdOWVZCaU5ZS3NYTFhCZTFqc3ZnSk5z?=
 =?utf-8?B?WUF5bDFqdS80MTNSaHQ1VnhIQlQ1V2VQZFUzdFdscGpFbmUrR3pZMWRMai9Y?=
 =?utf-8?B?WDlMNDM3V0NUdzRTU0pkVGhielc5Vy9uS3lzZU0wQ1ZqR29QOEFmZUthdWVS?=
 =?utf-8?B?UVVuZm9mejcwWXdGaC9xNGlOamdaTm1RWmYwRE00cW1qenB1ckR2RG5GRllZ?=
 =?utf-8?B?T3ZPRUxnR2dUaDQwVVFTdzVnd3VibHVFME9zUENzTjdEWm1ESG03Z3ViZU1x?=
 =?utf-8?B?T1VoVmt0Z0RyYXpra3FRMWZNT0hNTklWcEN2VHA0M3dNQ2hNYjZ3NmhyeDJ2?=
 =?utf-8?B?L2k2QURIcHFxT2I3OUlyTTBNUXJub0NWaGZ5bFAxeVR2WXBJOS9ja0tES0Ev?=
 =?utf-8?B?ZFVJcUQ2bWM1T1lMMldvK3NaZnNsUUgyZ0lZaHNtTER1M0ZRKzFBVGdEWjJX?=
 =?utf-8?B?aVVoNTVoc0lRTCtsWk83Ui9IUnZ2RWNUd25CdUFoN2lSOHlDeGY2SnZzNWJK?=
 =?utf-8?B?NTJLZW9XUmR3djN2SlpiRlhXalU1ajJ2eUszT3padUI0TEgwSWg5a0dHR0hH?=
 =?utf-8?B?MURndVJvdU1TMU1OTm1kTUx2NHp1QTJ4bmdRVmttUHZyWHFrN1c0cWdrRWNT?=
 =?utf-8?B?M3JSTVVBbFhqdjkrbXc5bEFHeXB2ZmJDdythOXUveFRDRlZzbm5hVGx5MTc1?=
 =?utf-8?B?U0ZiRmRiTEVXUWZYQmFQR2tlT0R6RVQ1ckQ3MEtIRDRBVzVxVXlGRDZEbmx1?=
 =?utf-8?B?K3FiMzJiMzZidDNGcWtVNXA1K21qSFZvZmFremUwSXEyZXN3ZXlUSFlLU0or?=
 =?utf-8?Q?8+GA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b130572f-92df-4f75-1c9a-08db601814c9
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 07:41:14.8664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g0vPSVjsbWsnBNGVUWHP0peU0Lw3osFtn6RBNvml4ynh450D9oupbabZ4SeiAtbW5oGGLvkV4ghjsQftlkFzCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR02MB6315
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andy,

Thanks for reviewing.
I can change this. But this is how it gets formatted by .clang-format.

Astrid

On 5/29/23 00:45, andy.shevchenko@gmail.com wrote:
> Mon, May 22, 2023 at 04:26:18PM +0200, Astrid Rost kirjoitti:
>> Add support to configure ambient light sensor interrupts and threshold
>> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
>> will be pushed to the event interface.
> 
> ...
> 
>> +		case IIO_EV_DIR_RISING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_ALS_THDH_LM, val);
> 
> Strange indentation.
> 
>> +			break;
>> +		case IIO_EV_DIR_FALLING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_ALS_THDL_LM, val);
> 
> Same.
> 
>> +			break;
> 
> ...
> 
>> +	case IIO_PROXIMITY:
>> +		switch (dir) {
>> +		case IIO_EV_DIR_RISING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_PS_THDH_LM, val);
> 
> Same.
> 
>> +			break;
>> +		case IIO_EV_DIR_FALLING:
>> +			ret = i2c_smbus_write_word_data(
>> +				data->client, VCNL4040_PS_THDL_LM, val);
> 
> Same.
> 
>> +			break;
>