Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <46da8636-0c4f-9602-dcad-6e6dec10a94a@axis.com>
Date:   Mon, 29 May 2023 11:25:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v4 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200
Content-Language: en-US
To:     <andy.shevchenko@gmail.com>, Astrid Rost <astrid.rost@axis.com>
CC:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@axis.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Mathieu Othacehe <m.othacehe@gmail.com>
References: <20230522142621.1680563-1-astrid.rost@axis.com>
 <20230522142621.1680563-4-astrid.rost@axis.com>
 <ZHPY32XPGyc96jJS@surfacebook>
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <ZHPY32XPGyc96jJS@surfacebook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak84TUkxY1VKa0Q4d09VTGpGVUlLMFBSbGdoS05nU0pWdU44OFZZM096NlBT?=
 =?utf-8?B?UGQ5YlljYjBkV3BKOW5PUVc2K2NubDk1U1V6TVREWnROc1NBaENpakNOWWcv?=
 =?utf-8?B?ay9YYkhsakNhcXlBVGtmMklOUjU5cHlQVjcwemJUQjVsSW96M1JkV21NRzNn?=
 =?utf-8?B?R3gxeDh2b0c1KzZXbzFXTnJUa2tEajdPZ2w0eWwzWmYxVnE3TkQ4VjFPSTMw?=
 =?utf-8?B?ZXdZVTNUNmhxYWp4c2owRk1MeC9oaVNNWjZ1emNaVHV2RHMvMjBUVlBpYVM4?=
 =?utf-8?B?U2w4QmRqSVl0YnVjcE9vdmV3eEdKbjRUREM4YWVTRE0wU3AydzVUcjJSWXhQ?=
 =?utf-8?B?ai9WNThlc2drU3k0TkN3MXI2QVFkVm93SVk2a0lIbE56OFJlbTB1aWlpVFZt?=
 =?utf-8?B?M0J1Zmsva292NmlCUVB3OGJDb1lvRXFRcmw1WXZnMTFTZTBlV1FmRGJuMVZ1?=
 =?utf-8?B?WFI3NHFKZFFnUUV6MG94WHAxcklxR2FRL0VaSFg3aGFMLzVBMHZoTDluUnB3?=
 =?utf-8?B?bUlhc2R5Y2w2ZWFoMldxQWZZRjFQSVRNMGY0U0IrN3ZQNDVQKzJQSllkOStK?=
 =?utf-8?B?dkxXM2RRSmlHQ01WampzdEcvOGpVZnZaa0V6RFpUZ0pxRXp0Z1R4Nzdmb0ox?=
 =?utf-8?B?dFoxVExPR1BlUVlYMlIvaUZ4MzladjN5VERxdnk2ZHRHdHd0bDYxcXpFSmJF?=
 =?utf-8?B?MExZeXdmUHBxUzBPNzVyK1ZITEdoU3ZkUEdOS2hja09uR1pjeS94Qk12TC9r?=
 =?utf-8?B?UHFreldYMmtXbkZBS3QxKzMrKzdLUThxcEdTbytOQk1IaUU0MU5CbVhmUWZV?=
 =?utf-8?B?NWpzRzJSSDBObXJFTlVPQk9FQzRPNGFQVTZVVGlGQ2sxNXpKZi9PcFJMcGQv?=
 =?utf-8?B?cTExKzBqdWxxbUlxdFdxNVZ4MW9sdWREd09uemZQYmdWUUNiWEhQZDlCQkd0?=
 =?utf-8?B?b1FKQlVxd2RJSXBlVGZsSnBFZHlIV3pxMEVOVUNERTNEamxlOEs5V2lyaU1Y?=
 =?utf-8?B?dDJ5OUt2ZnZzNHczaVBnM1Zoci9PVStKdjhyMGhjOUptNUpkTllzUzRMVXF5?=
 =?utf-8?B?SjlhbkNpeStmRUxxbVBjTlViU09SLy9wWnMrZUdMaDFaS1NLYVVDbUd2RnU2?=
 =?utf-8?B?NmxBd2c3dG5sNWJ2cVJNYmhXbHRQNmZZZmpmSGdqd2c3d1gybDVWQWh0WmtM?=
 =?utf-8?B?TGpkOUFaL3dabXM2RXFnSEZYOGwzaWVBMFppQUJZeGYzUllzVEhVVjFEcUNx?=
 =?utf-8?B?dmdaRUhtcUltQzk3NUg0eWlSdGdHUTdYU0ZCV3d1RE1hYUpiR3p3TG05ckM5?=
 =?utf-8?B?NkNtYkFUbGUvUFU1Ni9KVnphMCtCUTdub3Ivd2svM3JWUnVpVUhxS1gwWEUr?=
 =?utf-8?B?cVp1THlqbDlxNUxyMUJreW1WTitBL1kwNGloUy9NckFZRFlVRGE4ejBUa3dv?=
 =?utf-8?B?SlhDcWorUXpDQTFwall6Y05SS3J4Wklac21WSUZiN1ZBQ05STm9iSXdaanBX?=
 =?utf-8?B?cGtOT0xHYWthZWRlcDc0RFIyeGhDVVM4UzB0OWZJZ3ZWU2RtbHlEK29CSHh4?=
 =?utf-8?B?eC9qS3FzSWk5eUQ1SFprdlJoa0w5TVd6OTJiZTdIMXhKVlVJeHFKdlljdlN0?=
 =?utf-8?B?dDE5cWFDdjFpSWNKWXFwYlhlOWMzb21sVGxmcEc0a1hORG1GQVZZekR0akwv?=
 =?utf-8?B?NDRJWmpxa1ZmSHlJakdWdnQyMC9GQlNqZFVBaHNVc0VhcldkakFKaTlIVW55?=
 =?utf-8?B?NFlLa2haWnFPOTlCcE5xTEFXWlE3OU1JQkdRV0JFN1Z5T2dSQzlMcE5Kc3JN?=
 =?utf-8?B?S3BINVZGdVErSVJjbkZnbGNzK0dXa0h3c3hVYm1hc3l6U3AycG5qS20rK1Qr?=
 =?utf-8?B?UEhJeTltTDgwL1dqTEFEYjFvcm1RY0dER1I4d1M5dElHemU3OUdyWWh6MnRJ?=
 =?utf-8?B?NVBHV3hSS2QrOGt4bWk1T2c0eG1VUDV3WnlxYjFPV3ZkdEtpQVlJdy92MExw?=
 =?utf-8?B?S2lCaEJxQXU3NXNKTWJURnVQU0hhOTJsNmc0UkRUYVR3NGllSUxkdERPY1p2?=
 =?utf-8?B?T3JldjBHUDRjNExaSkNOdTRGbE16RkJoTjllWXJoempZWGg3ZnUrOFlacW1H?=
 =?utf-8?Q?7fvw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 47fd9ce9-f0bf-4976-2c9c-08db6026b14c
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 09:25:50.4610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uwgl6H8xchB2k002u3Dpw+q1srIIixB58oLsPDSPFtxCBjfRLIZi0qQqzhCAQMfIl07VZENv9Zfytc5RHE9RFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR02MB8327
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andy,

Thanks for your comment.


On 5/29/23 00:42, andy.shevchenko@gmail.com wrote:
> Mon, May 22, 2023 at 04:26:17PM +0200, Astrid Rost kirjoitti:
>> Add illuminance integration time for vcnl4040 and vcnl4200.
>> Add read/write attribute for illuminance integration time and read
>> attribute for available integration times.
>> Set scale and sampling rate according to the integration time.
> 
> ...
> 
>> +	data->vcnl4200_al.sampling_rate = ktime_set(0, val * 1200000);
>> +	if (data->id == VCNL4200)
>> +		/* 24000 µlux/step * 50000 µs / val  */
>> +		data->al_scale = div_u64(1200000000, val);
> 
> Without type these constant are integers. Is this okay with 32-bit builds?

No, I got an error on x86 on my first patch. But i did not really 
understand. All variables are within int and not defined as something 
bigger.

> 
>> +	else
>> +		/* 100000 µlux/step * 80000 µs / val */
>> +		data->al_scale = div_u64(8000000000, val);
> 
> Ditto.

8000000000 exceeds at least 32 bit.
> 
> Also, can you use constants from units.h (KILO) and time.h (USEC_PER_MSEC)?
> 
> ...
> 
>> +out:
> 
> out_unlock:
> 
>> +	mutex_unlock(&data->vcnl4000_lock);
>> +	return ret;
>