Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 12:15:08 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Robin van der Gracht <robin@protonic.nl>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        David Jander <david@protonic.nl>, kernel@pengutronix.de,
        linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] can: j1939: j1939_sk_send_loop_abort(): improved
 error queue handling in J1939 Socket
Message-ID: <20230529-escalate-petticoat-976947c5ff2c-mkl@pengutronix.de>
References: <20230526081946.715190-1-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mvongy46xmtqqt6x"
Content-Disposition: inline
In-Reply-To: <20230526081946.715190-1-o.rempel@pengutronix.de>
Precedence: bulk


--mvongy46xmtqqt6x
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 26.05.2023 10:19:46, Oleksij Rempel wrote:
> This patch addresses an issue within the j1939_sk_send_loop_abort()
> function in the j1939/socket.c file, specifically in the context of
> Transport Protocol (TP) sessions.
>=20
> Without this patch, when a TP session is initiated and a Clear To Send
> (CTS) frame is received from the remote side requesting one data packet,
> the kernel dispatches the first Data Transport (DT) frame and then waits
> for the next CTS. If the remote side doesn't respond with another CTS,
> the kernel aborts due to a timeout. This leads to the user-space
> receiving an EPOLLERR on the socket, and the socket becomes active.
>=20
> However, when trying to read the error queue from the socket with
> sock.recvmsg(, , socket.MSG_ERRQUEUE), it returns -EAGAIN,
> given that the socket is non-blocking. This situation results in an
> infinite loop: the user-space repeatedly calls epoll(), epoll() returns
> the socket file descriptor with EPOLLERR, but the socket then blocks on
> the recv() of ERRQUEUE.
>=20
> This patch introduces an additional check for the J1939_SOCK_ERRQUEUE
> flag within the j1939_sk_send_loop_abort() function. If the flag is set,
> it indicates that the application has subscribed to receive error queue
> messages. In such cases, the kernel can communicate the current transfer
> state via the error queue. This allows for the function to return early,
> preventing the unnecessary setting of the socket into an error state,
> and breaking the infinite loop. It is crucial to note that a socket
> error is only needed if the application isn't using the error queue, as,
> without it, the application wouldn't be aware of transfer issues.
>=20
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Reported-by: David Jander <david@protonic.nl>
> Tested-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Applied to linux-can, added stable on Cc.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--mvongy46xmtqqt6x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmR0eykACgkQvlAcSiqK
BOgQiggAquFQWp8JcNGEW3M8XDLDriPJI++T9TNxvt18R2mvq9dp3avKNDso7B0b
PA6A8m3RwS/gb7ibqOJtIOKt8fh0RGcraKEuYgUvEijNGfQ8L1WtjJjIV9o+gAfz
aNeXUrdf+Nq+4s3TlZpvdPQfOIuLxuxX6mIeauq2rYmTEJLrAX8Wzqrh8H/l+Qy4
zutQnmixVDiefKLi3Gm8/Sj7J1EtepjVa6E6e5VKdM/JdGEZ6SRzwXAtTviGy8BX
yP7z/ced3z0C31lXnyR4oxpCYPSEfbGm1iGqZJz/jQVy+tWKLWRZ9vZCIK1tGbrG
bcIGjG9vVvt3fkmjpTHT09ZtqcVoCw==
=6eIq
-----END PGP SIGNATURE-----

--mvongy46xmtqqt6x--