Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 13:03:14 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>, Russell King <linux@armlinux.org.uk>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020
 switches
Message-ID: <20230529130314.0d4c474e@wsk>
In-Reply-To: <20230529105132.h673mnjddubl7und@skbuf>
References: <20230523142912.2086985-1-lukma@denx.de>
        <20230529110222.68887a31@wsk>
        <20230529105132.h673mnjddubl7und@skbuf>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/wjR+okbr5dZj2MG3U4lC9KN";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/wjR+okbr5dZj2MG3U4lC9KN
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Vladimir,

> Hello Lukasz,
>=20
> On Mon, May 29, 2023 at 11:02:22AM +0200, Lukasz Majewski wrote:
> > Dear All,
> >  =20
> > > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f);
> > > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220,
> > > 6250, 6290" the error when mv88e6020 or mv88e6071 is used is not
> > > present anymore.
> > >  =20
> >=20
> > Are there any more comments for this patch set? =20
>=20
> Has your email client eaten these comments too?
>=20
> https://lore.kernel.org/netdev/c39f4127-e1fe-4d38-83eb-f372ca2ebcd3@lunn.=
ch/
> | On Wed, May 24, 2023 at 03:48:02PM +0200, Andrew Lunn wrote:
> | > > > Vladimir indicates here that it is not known how to change
> the max MTU | > > > for the MV88E6250. Where did you get the
> information from to implement | > > > it?
> | > >=20
> | > > Please refer to [1].
> | > >=20
> | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as
> | > > registers' offsets and bits are the same for mv88e60{71|20}).
> | >=20
> | > So you have the datasheet? You get the information to implement
> this | > from the data sheet?
> | >=20

This I've replied to Andrew in a private mail.

> | >      Andrew
>=20
> https://lore.kernel.org/netdev/ZG4E+wd03cKipsib@shell.armlinux.org.uk/
> | On Wed, May 24, 2023 at 01:37:15PM +0100, Russell King (Oracle)
> wrote: | > On Wed, May 24, 2023 at 02:17:43PM +0200, Lukasz Majewski
> wrote: | > > Please refer to [1].
> | > >=20
> | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as
> | > > registers' offsets and bits are the same for mv88e60{71|20}).
> | > >=20
> | > > After using Vladimir's patch there is no need to add max_frame
> size | > > field and related patches from v6 can be dropped.
> | >=20
> | > However, you haven't responded to:
> | >=20
> | >
> https://lore.kernel.org/all/ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk/ |
> > | > to explain why what you're doing (adding this function) is safe.
> | >=20
> | > Thanks.
> | >=20

The above question has been replied:
https://lore.kernel.org/all/20230524145357.3928f261@wsk/

> | > --=20
> | > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> | > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Do you have any more comments?


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/wjR+okbr5dZj2MG3U4lC9KN
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmR0hnIACgkQAR8vZIA0
zr3phggAnR4vPpm7QoDvoYhqmbZqP8NmH+Xwb+XojKe9MRSSCQr0CcH/uF0+9dqm
H+b88EW66uMrlN9PmQDrK6gelrzMO2qqILFCE4IYTLlJtlBbMxcn5fxyNqHx6HWe
tSy8aiVywTW+++Rtrkp4lPDhNjV9aBiqudyPWPTYVsvCkWQPxVtsUdHXEvIOJQRZ
cWzfyKrjOrR6RAIDvdQPsRrS0GSrPnQQRv1SsPYwRMzK5QOUpc8QHw9WU0M2XIUg
rLV22gdtVstZIg+6HC8eM6mHtquJHJ7kfH008JTj5AIqkLgwe7Fs2CiaYLGnNOaW
u2dHQC/uo9/7bRdir3xfOlZAelZ5FA==
=ffyA
-----END PGP SIGNATURE-----

--Sig_/wjR+okbr5dZj2MG3U4lC9KN--