Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbXJKX1f (ORCPT ); Thu, 11 Oct 2007 19:27:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753001AbXJKX12 (ORCPT ); Thu, 11 Oct 2007 19:27:28 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:43142 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752879AbXJKX11 (ORCPT ); Thu, 11 Oct 2007 19:27:27 -0400 Date: Fri, 12 Oct 2007 01:27:55 +0200 From: Adrian Bunk To: Jeff Garzik Cc: Linus Torvalds , Kevin , Greg KH , Olof Johansson , Greg KH , "Rafael J. Wysocki" , "Theodore Ts'o" , Zwane Mwaikambo , Justin Forbes , Linux Kernel Mailing List , Chris Wedgwood , Domenico Andreoli , Mark Lord , Randy Dunlap , Michael Krufky , Chuck Ebbert , Dave Jones , akpm@linux-foundation.org, Chuck Wolber , stable@kernel.org, alan@lxorguk.ukuu.org.uk, BDFL , Stephen Rothwell Subject: Re: APM shutdown oops (Re: [stable] [patch 09/12] Fix SMP poweroff hangs) Message-ID: <20071011232755.GA3620@stusta.de> References: <20071008180406.052382073@mini.kroah.org> <200710092359.47144.spaceman__spiff@cox.net> <200710102005.02184.spaceman__spiff@cox.net> <470E6E79.6040908@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <470E6E79.6040908@pobox.com> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2251 Lines: 57 On Thu, Oct 11, 2007 at 02:42:01PM -0400, Jeff Garzik wrote: > Linus Torvalds wrote: >> On Wed, 10 Oct 2007, Kevin wrote: >>> The last kernel I used was 6.2.22 the "dmesg" the file is attached: >>> >>> dmesg 2.6.22 line 158 > apm: overridden by ACPI. >>> >>> dmesg, APM on, has no line > apm: overridden by ACPI. >> Ok, this is the real reason. The APM code does: >> if (PM_IS_ACTIVE()) { >> printk(KERN_NOTICE "apm: overridden by ACPI.\n"); >> apm_info.disabled = 1; >> return -ENODEV; >> } >> and in previous kernels that would notice that you have ACPI enabled, and >> APM gets shut out, and you never see your buggy APM BIOS. >> In 2.6.23, this apparently doesn't happen for some reason. >> And I think I see the problem: it's a config change. You don't have >> PM_LEGACY enabled. Your config file diff shows: >> -CONFIG_PM_LEGACY=y >> +# CONFIG_PM_LEGACY is not set >> I suspect we should make CONFIG_APM either depend on, or select, >> PM_LEGACY. But as far as I can see, nothing has actually changed in this >> area in the kernel, and this bug has been there before - just your config >> change made it appear. Rafael? Stephen? Opinions? I'd think that making >> APM depend on CONFIG_PM_LEGACY is the right thing to do these days.. > > Speaking as the author of > > [PATCH] move pm_register/etc. to CONFIG_PM_LEGACY, pm_legacy.h > > I agree. arch/i386/kernel/apm.c clearly requires include/linux/pm_legacy.h > and the legacy PM API. > > I would vote for a dependency rather than select, but don't have any strong > feelings on the matter... It should be a select since a dependency would make it needlessly hard for kconfig users to find the APM option. > Jeff cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/