Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 13:58:06 +0200
From:   Michal Hocko <mhocko@suse.com>
To:     Mike Rapoport <rppt@kernel.org>
Cc:     Haifeng Xu <haifeng.xu@shopee.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mm_init.c: remove free_area_init_memoryless_node()
Message-ID: <ZHSTTu7aNvZeIHIT@dhcp22.suse.cz>
References: <20230528045720.4835-1-haifeng.xu@shopee.com>
 <20230529090446.GK4967@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230529090446.GK4967@kernel.org>
Precedence: bulk

On Mon 29-05-23 12:04:46, Mike Rapoport wrote:
> (added Michal)
> 
> On Sun, May 28, 2023 at 04:57:20AM +0000, Haifeng Xu wrote:
> > free_area_init_memoryless_node() is just a wrapper of
> > free_area_init_node(), remove it to clean up.
> > 
> > Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> > ---
> >  mm/mm_init.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/mm/mm_init.c b/mm/mm_init.c
> > index 2d91bb52c619..93821824271a 100644
> > --- a/mm/mm_init.c
> > +++ b/mm/mm_init.c
> > @@ -1752,11 +1752,6 @@ void __init setup_nr_node_ids(void)
> >  }
> >  #endif
> >  
> > -static void __init free_area_init_memoryless_node(int nid)
> > -{
> > -	free_area_init_node(nid);
> > -}
> > -
> >  /*
> >   * Some architectures, e.g. ARC may have ZONE_HIGHMEM below ZONE_NORMAL. For
> >   * such cases we allow max_zone_pfn sorted in the descending order
> > @@ -1867,7 +1862,7 @@ void __init free_area_init(unsigned long *max_zone_pfn)
> >  				panic("Cannot allocate %zuB for node %d.\n",
> >  				       sizeof(*pgdat), nid);
> >  			arch_refresh_nodedata(nid, pgdat);
> > -			free_area_init_memoryless_node(nid);
> > +			free_area_init_node(nid);
> 
> Using a dedicated free_area_init_memoryless_node() wrapper here emphasizes
> that the node has no memory, but I don't have a strong feeling about
> keeping it.

Honestly, I do not think it has any added value anymore. Some time ago
it was a list of special parameters and aliasing that made some sense at
least. Maybe that could be carved into the changelog in some form.

Acked-by: Michal Hocko <mhocko@suse.com>

> 
> >  
> >  			/*
> >  			 * We do not want to confuse userspace by sysfs
> > -- 
> > 2.25.1
> > 
> 
> -- 
> Sincerely yours,
> Mike.

-- 
Michal Hocko
SUSE Labs