Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 13:48:36 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     <Claudiu.Beznea@microchip.com>
CC:     <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <Nicolas.Ferre@microchip.com>,
        <alexandre.belloni@bootlin.com>, <daniel.lezcano@linaro.org>,
        <tglx@linutronix.de>, <wim@linux-watchdog.org>,
        <linux@roeck-us.net>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: timer: atmel,at91sam9260-pit:
 convert to yaml
Message-ID: <20230529-schematic-abrasion-a06a29481ace@wendy>
References: <20230529062604.1498052-1-claudiu.beznea@microchip.com>
 <20230529062604.1498052-3-claudiu.beznea@microchip.com>
 <20230529-chuck-turbofan-a8aabbdd9341@wendy>
 <f4c04190-c90e-bf5f-f666-c979a7aee8ce@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="QnBF0FcDx3VBpqKu"
Content-Disposition: inline
In-Reply-To: <f4c04190-c90e-bf5f-f666-c979a7aee8ce@microchip.com>
Precedence: bulk

--QnBF0FcDx3VBpqKu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 29, 2023 at 12:32:49PM +0000, Claudiu.Beznea@microchip.com wrot=
e:
> On 29.05.2023 15:17, Conor Dooley wrote:
> > On Mon, May 29, 2023 at 09:26:02AM +0300, Claudiu Beznea wrote:
> >> +        interrupts:
> >> +          description:
> >> +            Contain interrupt for the PIT which is the IRQ line share=
d across all
> >> +            System Controller members.
> >=20
> > I think you should drop this & the corresponding section below, since
> > both PIT and PIT64 have a single interrupt.
>=20
> OK. Just wanted to emphasize with this that in case of PIT the interrupt
> may be shared with other IPs.

Hmm. Perhaps for the other patch, keep the description then, and for this
one remove the description from the else branch & add explain what "all
system controller members" actually means here? It probably made sense in
the txt binding, but "system controller" has lost its context here.
Maybe something like:
"Shared interrupt between the PIT and other functions of the system
controller, for example, the watchdog, trumpet and airhorn"?

Cheers,
Conor.

> >> +        clocks:
> >> +          maxItems: 1
> >> +
> >> +    else:
> >> +      properties:
> >> +        interrupts:
> >> +          description:
> >> +            PIT64B peripheral interrupt identifier.
> >> +        clocks:
> >> +          minItems: 2
> >> +        clock-names:
> >> +          items:
> >> +            - const: pclk
> >> +            - const: gclk
> >> +      required:
> >> +        - clock-names
> >=20
>=20

--QnBF0FcDx3VBpqKu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHSfIwAKCRB4tDGHoIJi
0jihAP9RPI9uRTfWz1IZRSiam+UQ+nEDIQA6miPvid++71X53gD/WqPNahZzotuJ
FT+ZEVVKizduAnFCebdolxza7JIw6Ac=
=16Ml
-----END PGP SIGNATURE-----

--QnBF0FcDx3VBpqKu--