Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 13:34:02 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Bharat Bhushan <bbhushan2@marvell.com>
CC:     Conor Dooley <conor@kernel.org>,
        "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: Re: [EXT] Re: [PATCH 1/2 v8] dt-bindings: watchdog: marvell GTI
 system watchdog driver
Message-ID: <20230529-unwanted-chewer-b3f6ab8bcb86@wendy>
References: <20230526062626.1180-1-bbhushan2@marvell.com>
 <20230526-bondless-slather-5de0a5659353@spud>
 <DM5PR1801MB188350DD9CFDBB3E240AC838E3449@DM5PR1801MB1883.namprd18.prod.outlook.com>
 <20230527-wiring-coping-88eba4d91f3f@spud>
 <DM5PR1801MB1883D475F396D2CBA02B6D91E34A9@DM5PR1801MB1883.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ywTPy+AUgC8z/xRs"
Content-Disposition: inline
In-Reply-To: <DM5PR1801MB1883D475F396D2CBA02B6D91E34A9@DM5PR1801MB1883.namprd18.prod.outlook.com>
Precedence: bulk

--ywTPy+AUgC8z/xRs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Bharat,

On Mon, May 29, 2023 at 06:14:07AM +0000, Bharat Bhushan wrote:

> Fallback you mentioned make code look simple. Is below representation cor=
rect for above mentioned fallback?=20
>=20
> properties:
>   compatible:
>     oneOf:
>       - const: marvell,cn9670-wdt
>       - items:
>           - enum:
>               - marvell,cn9880-wdt
>               - marvell,cnf9535-wdt
>           - const: marvell,cn9670-wdt
>       - const: marvell,cn10624-wdt
>       - items:
>           - enum:
>               - marvell,cn10308-wdt
>               - marvell,cnf10518-wdt
>           - const: marvell,cn10624-wdt

Instead of having const: bits for each of the single-compatible ones, if
you are not going to add descriptions, I'd probably do:
properties:
  compatible:
    oneOf:
      - enum:
          - marvell,cn9670-wdt
          - marvell,cn10624-wdt

      - items:
          - enum:
              - marvell,cn9880-wdt
              - marvell,cnf9535-wdt
          - const: marvell,cn9670-wdt

      - items:
          - enum:
              - marvell,cn10308-wdt
              - marvell,cnf10518-wdt
          - const: marvell,cn10624-wdt

> And driver will have
>         { .compatible =3D "marvell,cn9670-wdt", .data =3D &match_data_oct=
eontx2},
>         { .compatible =3D "marvell,cn10624-wdt", .data =3D &match_data_cn=
10k},

Otherwise, looks good to me. You should probably also rename the file to
match one of the compatibles contained in it.

Thanks,
Conor.

--ywTPy+AUgC8z/xRs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHSbugAKCRB4tDGHoIJi
0jZ9AP9dKKl1qfQuhXx6zf7LJ/oKTPhJB0Iymd+M3n5+3MyDMAD9HryFUB8C5p7A
zZ1uKMaseMn/g5aNILTTqA5PwMwQdQ4=
=6E/Q
-----END PGP SIGNATURE-----

--ywTPy+AUgC8z/xRs--