Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 15:08:25 +0200
From:   Andrew Jones <ajones@ventanamicro.com>
To:     Song Shuai <songshuaishuai@tinylab.org>
Cc:     paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, conor@kernel.org, suagrfillet@gmail.com,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle
Message-ID: <20230529-635a440721fd4e1305cbc9c9@orel>
References: <20230529101524.322076-1-songshuaishuai@tinylab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230529101524.322076-1-songshuaishuai@tinylab.org>
Precedence: bulk

On Mon, May 29, 2023 at 06:15:24PM +0800, Song Shuai wrote:
> With this configuration opened, the basic platform-independent s2idle is
> provided by the sole "s2idle" string in `/sys/power/mem_sleep`.
> 
> At the end of s2idle, harts will hit the `wfi` instruction or enter the
> SUSPENDED state through the sbi_cpuidle driver. The interrupt of possible
> wakeup devices will be kept to wake the system up.
> 
> And platform-specific sleep states can be provided by future ACPI and
> SBI SUSP extension support.
> 
> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
>  arch/riscv/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 348c0fa1fc8c..4bb818035585 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -805,6 +805,9 @@ config ARCH_HIBERNATION_POSSIBLE
>  config ARCH_HIBERNATION_HEADER
>  	def_bool HIBERNATION
>  
> +config ARCH_SUSPEND_POSSIBLE
> +	def_bool y
> +
>  endmenu # "Power management options"
>  
>  menu "CPU Power Management"
> -- 
> 2.20.1
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

Thanks,
drew