Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd
Mime-Version: 1.0
Message-Id: <49631ff4-8d8c-4e77-bf13-dd8b0c1819d0@app.fastmail.com>
In-Reply-To: <aeb0313-e845-9134-4136-6347d691bd4@linux.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20230526171658.3886-1-mpearson-lenovo@squebb.ca>
 <20230526171658.3886-4-mpearson-lenovo@squebb.ca>
 <aeb0313-e845-9134-4136-6347d691bd4@linux.intel.com>
Date:   Mon, 29 May 2023 10:50:35 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] platform/x86: think-lmi: Don't display unnecessary
 authentication settings
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Mon, May 29, 2023, at 8:05 AM, Ilpo J=C3=A4rvinen wrote:
> On Fri, 26 May 2023, Mark Pearson wrote:
>
>> If Opcode support is available (which is the standard for all platfor=
ms
>> going forward) then there is no need to have the encoding and kbdlang
>> attributes visible
>>=20
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> ---
>> Changes in v2 & v3: None. Version bumped in series
>>=20
>>  drivers/platform/x86/think-lmi.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>=20
>> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/=
think-lmi.c
>> index 1c02958035ad..64cd453d6e7d 100644
>> --- a/drivers/platform/x86/think-lmi.c
>> +++ b/drivers/platform/x86/think-lmi.c
>> @@ -879,6 +879,12 @@ static umode_t auth_attr_is_visible(struct kobje=
ct *kobj,
>>  		return 0;
>>  	}
>> =20
>> +	/* Don't display un-needed settings if opcode available */
>> +	if ((attr =3D=3D &auth_encoding.attr ||
>> +	    attr =3D=3D &auth_kbdlang.attr) &&
>
> Indentation issue here, attr must be at the same column although putti=
ng=20
> the || on a single line might make this easier to read.

OK - will fix.

>
>> +	    tlmi_priv.opcode_support)
>> +		return 0;
>> +
>>  	return attr->mode;
>>  }
>> =20
>>=20
>
> --=20
>  i.

Thanks for the review
Mark