Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd
Mime-Version: 1.0
Message-Id: <709df78f-4313-460a-87da-f4d302ed8912@app.fastmail.com>
In-Reply-To: <a52f69f-2dc4-fe76-9f89-e1c143d2bb27@linux.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20230526171658.3886-1-mpearson-lenovo@squebb.ca>
 <20230526171658.3886-3-mpearson-lenovo@squebb.ca>
 <a52f69f-2dc4-fe76-9f89-e1c143d2bb27@linux.intel.com>
Date:   Mon, 29 May 2023 10:58:08 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] platform/x86: think-lmi: Correct NVME password handling
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks Ilpo

On Mon, May 29, 2023, at 8:03 AM, Ilpo J=C3=A4rvinen wrote:
> On Fri, 26 May 2023, Mark Pearson wrote:
>
>> NVME passwords identifier have been standardised across the Lenovo
>> systems and now use udrp and adrp (user and admin level) instead of
>> unvp and mnvp.
>>=20
>> This should apparently be backwards compatible.
>>=20
>> Also cleaned up so the index is set to a default of 1 rather than 0
>> as this just makes more sense (there is no device 0).
>
> These two sound entirely separate changes. If that's the case, please=20
> make own patch from the send change.

Ack. It was all related to the index setting and seemed trivial so I lum=
ped together but I can split.
This patch series is turning into a good learning exercise for my git sk=
ills :) (which are limited)

>
> Hmm, index_store() still allows 0, is that also related here? Please c=
heck=20
> also ABI documentation as index default seems to be mentioned there as=20
> well.
>

I'd rather not limit it so 0 isn't allowed in case our BIOS team does so=
mething weird in the future; but right now 1 is the default so it makes =
more sense.

Well spotted on the ABI documentation - I had completely missed that. I =
will address that as well.

> --=20
>  i.

Thanks for the review
Mark