Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fcdc5a27817b17d91df84bb06ad5d382829d5467.camel@mniewoehner.de>
Subject: Re: [linus:master] [tpm, tpm_tis] e644b2f498: RIP:acpi_safe_halt
From:   Michael =?ISO-8859-1?Q?Niew=F6hner?= <linux@mniewoehner.de>
To:     Jerry Snitselaar <jsnitsel@redhat.com>,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>
Cc:     Lukas Wunner <lukas@wunner.de>,
        Jarkko Sakkinen <jarkko@kernel.org>, oe-lkp@lists.linux.dev,
        lkp@intel.com, linux-kernel@vger.kernel.org,
        linux-integrity@vger.kernel.org,
        Philipp Rosenberger <p.rosenberger@kunbus.com>,
        peterz@infradead.org
In-Reply-To: <6nf5n6fdnkhx6taa2mecnsmyw7sdgaz6fbvkqy7jqkyd7jq2u7@ogsi6ije32in>
References: <202305041325.ae8b0c43-yujie.liu@intel.com>
         <d80b180a569a9f068d3a2614f062cfa3a78af5a6.camel@kernel.org>
         <42ea93a1-3186-b8ff-c317-d51f3e13856e@kunbus.com>
         <20230511141607.GA32208@wunner.de>
         <1a8ecf90-80a4-9aac-95e1-9ce0c4e09ba5@kunbus.com>
         <6nf5n6fdnkhx6taa2mecnsmyw7sdgaz6fbvkqy7jqkyd7jq2u7@ogsi6ije32in>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date:   Mon, 29 May 2023 17:07:54 +0200
MIME-Version: 1.0
User-Agent: Evolution 3.44.4 
Precedence: bulk

Hi Jerry,

On Thu, 2023-05-11 at 07:59 -0700, Jerry Snitselaar wrote:
> 
> IIRC trying to catch the irq storm didn't work in the L490 case for
> some reason, so we might still need the dmi entry for that one.
> 
> The info that the T490s had a pin wired up wrong came from Lenovo, but
> this one even looks to be a different vendor so I wonder how often
> this happens or if there is something else going on. Is it possible to
> get info about the tpm used in the Inspur system? The datasheet online
> doesn't mention it.

Are you sure about T490s? To me the wiring looks right on both s and non-s: Pin
18 / PIRQ# goes to PIRQA# of the PCH/SoC.

However on L490 Pin 18 / PIRQ# is wired wrongly to SERIRQ, which probably is the
reason that catching the interrupt storm didn't work: I guess this completely
messes up LPC communication and causes way more problems. In this case only a
DMI quirk can help.

BR
Michael

> 
> Regards,
> Jerry
> 
> > > Thanks,
> > > 
> > > Lukas
>