Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef8e411b-c326-9d24-c4f0-96cd183a9d1f@redhat.com>
Date:   Mon, 29 May 2023 17:46:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] media: atomisp: move the sanity checks before variable
 dereferences
To:     Dongliang Mu <dzm91@hust.edu.cn>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20230529152136.11719-1-dzm91@hust.edu.cn>
Content-Language: en-US, nl
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230529152136.11719-1-dzm91@hust.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 5/29/23 17:21, Dongliang Mu wrote:
> Smatch reports:
> 
> sh_css_load_firmware() warn: variable dereferenced before check 'fw_data'
> 
> The variable fw_data can be NULL in sh_css_load_firmware, resulting in
> NULL pointer dereference.
> 
> Fix this by moving the sanity checks before variable dereferences.
> 
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>

Thank you for your patch, but the same patch has already been submitted
and merged into my media-atomisp branch about a week ago:

https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/commit/?h=media-atomisp&id=c09907049eea9f12e959fb88c02a483a4c5eee89

> ---
>  drivers/staging/media/atomisp/pci/sh_css_firmware.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index e7ef578db8ab..38b757c3df0a 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -229,6 +229,10 @@ sh_css_load_firmware(struct device *dev, const char *fw_data,
>  	struct sh_css_fw_bi_file_h *file_header;
>  	int ret;
>  
> +	/* some sanity checks */
> +	if (!fw_data || fw_size < sizeof(struct sh_css_fw_bi_file_h))
> +		return -EINVAL;
> +
>  	firmware_header = (struct firmware_header *)fw_data;
>  	file_header = &firmware_header->file_header;
>  	binaries = &firmware_header->binary_header;
> @@ -243,10 +247,6 @@ sh_css_load_firmware(struct device *dev, const char *fw_data,
>  		IA_CSS_LOG("successfully load firmware version %s", release_version);
>  	}
>  
> -	/* some sanity checks */
> -	if (!fw_data || fw_size < sizeof(struct sh_css_fw_bi_file_h))
> -		return -EINVAL;
> -
>  	if (file_header->h_size != sizeof(struct sh_css_fw_bi_file_h))
>  		return -EINVAL;
>