Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76daf752-d050-b283-89b4-19ca57ac62ee@linaro.org>
Date:   Mon, 29 May 2023 17:52:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 4/6] arm64: dts: qcom: msm8916/39: Clean up MDSS labels
Content-Language: en-US
To:     Stephan Gerhold <stephan@gerhold.net>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230525-msm8916-labels-v1-0-bec0f5fb46fb@gerhold.net>
 <20230525-msm8916-labels-v1-4-bec0f5fb46fb@gerhold.net>
 <6f1954e6-e98d-6911-8721-c50082bfb1d7@linaro.org>
 <ZHS-HSgaBxMXiKy9@gerhold.net>
 <17f31258-bc38-245f-532f-fdaa1ee8ad33@linaro.org>
 <343e2e95-17ee-f5e3-61e9-7e0b793859a6@linaro.org>
 <ZHTFOZFxq-JgLP-p@gerhold.net>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <ZHTFOZFxq-JgLP-p@gerhold.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 29.05.2023 17:31, Stephan Gerhold wrote:
> On Mon, May 29, 2023 at 04:26:09PM +0100, Bryan O'Donoghue wrote:
>> On 29/05/2023 16:24, Bryan O'Donoghue wrote:
>>> On 29/05/2023 16:00, Stephan Gerhold wrote:
>>>> Do you mean update the examples in the yaml bindings
>>>
>>> Yep.
>>>
>>> grep dsi0_out Documentation/* -r | grep qcom
>>> grep dsi0_in Documentation/* -r | grep qcom
>>>
>>> Consider splitting this patch out and fixing up[1] Documentation/* and
>>> arch/arm/boot/dts/*.dts[i] , arch/arm64/boot/dts/qcom/*.dts[i]
>>>
>>> We may as well be consistent everywhere.
>>>
>>> ---
>>> bod
>>
>>
>> [1] In a standalone series
>>
> 
> Right I will check this and try to adjust the documentation and/or the
> other SoCs in a separate series.
Agreed, bindings don't really care about labels but they set examples.

I'd really appreciate if you could take care of that, Stephan.

 I would still prefer to apply it for
> 8916/8939 as part of this series since I have some unrelated follow-up
> changes that would just cause unnecessary conflicts for Bjorn otherwise.
> 
> We already have most newer SoCs using the naming convention in this
> patch so it definitely does not make the existing situation any worse. :)
Definitely!

Konrad
> 
> Thanks,
> Stephan