Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd
Mime-Version: 1.0
Message-Id: <fe193fe8-5a3c-4aa6-bb75-5ac53dc5a8f7@app.fastmail.com>
In-Reply-To: <3b2dfd18-a6f2-46a6-19dd-4ee95d5e9471@linux.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20230526171658.3886-1-mpearson-lenovo@squebb.ca>
 <20230526171658.3886-2-mpearson-lenovo@squebb.ca>
 <ff5513d9-ecf-50d3-1bb3-644a1d2c2347@linux.intel.com>
 <e71b1911-5105-4e19-9c86-6146f07a6b00@app.fastmail.com>
 <3b2dfd18-a6f2-46a6-19dd-4ee95d5e9471@linux.intel.com>
Date:   Mon, 29 May 2023 12:10:57 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] platform/x86: think-lmi: Correct System password interface
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Mon, May 29, 2023, at 11:50 AM, Ilpo J=C3=A4rvinen wrote:
> On Mon, 29 May 2023, Mark Pearson wrote:
>
>> Thanks Ilpo
>>=20
>> On Mon, May 29, 2023, at 7:36 AM, Ilpo J=C3=A4rvinen wrote:
>> > On Fri, 26 May 2023, Mark Pearson wrote:
>> >
>> >> The system password identification was incorrect. This means that =
if
>> >> the password was enabled it wouldn't be detected correctly; and se=
tting
>> >> it would not work.
>> >> Also updated code to use TLMI_SMP_PWD instead of TLMI_SYS_PWD to b=
e in
>> >> sync with Lenovo documentation.
>> >>=20
>> >> Correct these mistakes.
>> >>=20
>> >> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> >
>> > Missing Fixes tag?
>>=20
>> Yes - will add.
>>=20
>> >
>> >> ---
>> >> Changes in v2:
>> >>  - Updated define name to be SMP_PWD instead of SYS_PWD
>> >>  - Clarified in comments what each password type is.
>> >> Changes in v3: None. Version bump with rest of series
>> >>=20
>> >>  drivers/platform/x86/think-lmi.c | 14 +++++++-------
>> >>  1 file changed, 7 insertions(+), 7 deletions(-)
>> >>=20
>> >> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x=
86/think-lmi.c
>> >> index 2745224f62ab..c7e98fbe7c3d 100644
>> >> --- a/drivers/platform/x86/think-lmi.c
>> >> +++ b/drivers/platform/x86/think-lmi.c
>> >> @@ -168,11 +168,11 @@ MODULE_PARM_DESC(debug_support, "Enable debu=
g command support");
>> >>   */
>> >>  #define LENOVO_CERT_THUMBPRINT_GUID "C59119ED-1C0D-4806-A8E9-59AA=
318176C4"
>> >> =20
>> >> -#define TLMI_POP_PWD (1 << 0)
>> >> -#define TLMI_PAP_PWD (1 << 1)
>> >> -#define TLMI_HDD_PWD (1 << 2)
>> >> -#define TLMI_SYS_PWD (1 << 3)
>> >> -#define TLMI_CERT    (1 << 7)
>> >> +#define TLMI_POP_PWD (1 << 0) /* Supervisor */
>> >> +#define TLMI_PAP_PWD (1 << 1) /* Power-on */
>> >> +#define TLMI_HDD_PWD (1 << 2) /* HDD/NVME */
>> >> +#define TLMI_SMP_PWD (1 << 6) /* System Management */
>> >> +#define TLMI_CERT    (1 << 7) /* Certificate Based */
>> >
>> > Whe you're adding Fixes tag, please make this change minimal by jus=
t=20
>> > adding TLMI_SMP_PWD.
>> >
>> > The rest of these define changes are a good too but it's unrelated =
to the=20
>> > actual fix so they should be in a separate patch. And once you move=
 it=20
>> > into own change, convert to BIT() while at it.
>>=20
>> I was asked previously to clarify what SMP stood for so added the=20
>> comment and it seemed odd to only clarify one and not the others.=20
>> Can I push back on this request. Doing two separate patches for just=20
>> that doesn't make sense to me.
>
> I did not mean removing TLMI_SMP_PWD's comment from this patch just to=
 add=20
> it in the another but the comments to the other bits which should go i=
nto=20
> their own patch. The thing here is that fixes should be made minimal t=
o=20
> comply with stable rules.
>
OK....seems odd to me to be honest,  but not something I'd lose sleep ov=
er.=20
I'll do that in amongst all the other changes.

Thanks
Mark