Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd
Mime-Version: 1.0
Message-Id: <39791b71-7c40-42dc-8618-a2831fa08440@app.fastmail.com>
In-Reply-To: <2796a7d0-8010-ab14-23a-9f69ee9d465@linux.intel.com>
References: <mpearson-lenovo@squebb.ca>
 <20230526171658.3886-1-mpearson-lenovo@squebb.ca>
 <20230526171658.3886-3-mpearson-lenovo@squebb.ca>
 <a52f69f-2dc4-fe76-9f89-e1c143d2bb27@linux.intel.com>
 <709df78f-4313-460a-87da-f4d302ed8912@app.fastmail.com>
 <2796a7d0-8010-ab14-23a-9f69ee9d465@linux.intel.com>
Date:   Mon, 29 May 2023 12:06:40 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "Hans de Goede" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] platform/x86: think-lmi: Correct NVME password handling
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Mon, May 29, 2023, at 11:41 AM, Ilpo J=C3=A4rvinen wrote:
> On Mon, 29 May 2023, Mark Pearson wrote:
>> On Mon, May 29, 2023, at 8:03 AM, Ilpo J=C3=A4rvinen wrote:
>> > On Fri, 26 May 2023, Mark Pearson wrote:
>> >
>> >> NVME passwords identifier have been standardised across the Lenovo
>> >> systems and now use udrp and adrp (user and admin level) instead of
>> >> unvp and mnvp.
>> >>=20
>> >> This should apparently be backwards compatible.
>> >>=20
>> >> Also cleaned up so the index is set to a default of 1 rather than 0
>> >> as this just makes more sense (there is no device 0).
>> >
>> > These two sound entirely separate changes. If that's the case, plea=
se=20
>> > make own patch from the send change.
>>=20
>> Ack. It was all related to the index setting and seemed trivial so I=20
>> lumped together but I can split. This patch series is turning into a=20
>> good learning exercise for my git skills :) (which are limited)
>>
>> > Hmm, index_store() still allows 0, is that also related here? Pleas=
e check=20
>> > also ABI documentation as index default seems to be mentioned there=
 as=20
>> > well.
>> >
>>=20
>> I'd rather not limit it so 0 isn't allowed in case our BIOS team does=20
>> something weird in the future; but right now 1 is the default so it=20
>> makes more sense.
>
> Sure, do what you feel makes sense here. I was just pointing out the=20
> perceived inconsistency in case it wasn't intentional.
>
> It might be useful to add one sentence into changelog about the reason=
ing=20
> so it can be found easier later on (effectively the paragraph you wrot=
e=20
> above with small tweaks is enough I think).

Ack - will do. Thanks

Mark