Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230418113451.151312-1-kaima@hust.edu.cn> <ZGX/PjYBVGuECcPg@linaro.org>
 <22043583.EfDdHjke4D@sophie-lab>
In-Reply-To: <22043583.EfDdHjke4D@sophie-lab>
From:   Jesse T <mr.bossman075@gmail.com>
Date:   Mon, 29 May 2023 13:54:45 -0400
Message-ID: <CAJFTR8R=QkWSoMstqer_eEwA5YmvEZetENT8hkxx62QCt2ztjg@mail.gmail.com>
Subject: Re: [PATCH] clk: imx: clk-imxrt1050: fix memory leak in imxrt1050_clocks_probe
To:     Kai Ma <kaima@hust.edu.cn>
Cc:     Stephen Boyd <sboyd@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        hust-os-kernel-patches@googlegroups.com, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Abel Vesa <abel.vesa@linaro.org>,
        Dongliang Mu <dzm91@hust.edu.cn>,
        Zhanhao Hu <zero12113@hust.edu.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 29, 2023 at 12:55=E2=80=AFAM Kai Ma <kaima@hust.edu.cn> wrote:
>
> On Thursday, May 18, 2023 6:34:38 PM CST Abel Vesa wrote:
> > On 23-04-18 11:34:51, Kai Ma wrote:
> > > Use devm_of_iomap() instead of of_iomap() to automatically
> > > handle the unused ioremap region. If any error occurs, regions alloca=
ted by
> > > kzalloc() will leak, but using devm_kzalloc() instead will automatica=
lly
> > > free the memory using devm_kfree().
> > >
> > > Also, fix error handling of hws by adding unregister_hws label, which
> > > unregisters remaining hws when iomap failed.
> > >
> > > Fixes: 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 cl=
ock driver")
> > > Signed-off-by: Kai Ma <kaima@hust.edu.cn>
> >
> > Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> >
> > Stephen, can you apply this through clk-fixes?
> >
>
> Thanks for your review, I am glad to let you know that I am a student at =
a
> university and we collaborate to contribute to the Linux kernel.

That's cool, I am too!
Is there going to be a V2 of
https://lore.kernel.org/linux-arm-kernel/20230426142552.217435-1-zero12113@=
hust.edu.cn/T/

Thanks,
Jesse Taube

> Here we
> have some similar patches for clk. Could you please take care of them?
>
> [1] https://lore.kernel.org/linux-arm-kernel/DU0PR04MB9417B63DE97D4A2A77B=
4176C88969@DU0PR04MB9417.eurprd04.prod.outlook.com/T/
> [2] https://lore.kernel.org/linux-arm-kernel/20230503070607.2462-1-lyx202=
2@hust.edu.cn/T/
> [3] https://lore.kernel.org/linux-arm-kernel/dc0f2863-d5d5-5102-eb8e-ceea=
92c03fda@oss.nxp.com/
> [4] https://lore.kernel.org/linux-arm-kernel/9a2ab7ec-07ee-255f-a143-9b6c=
8df7c1e2@gmail.com/
>
> Thank you very much!
>
> Regards,
> Kai Ma