Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3493655rwd; Mon, 29 May 2023 11:22:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7RDscf1eQcfi1GW2/UfH9LHwb6L9NH3hy2eWx/xkDe8khwPUgfWU7gehwFvl6XgZlEcX60 X-Received: by 2002:a17:90a:a40e:b0:256:8cb7:2b2b with SMTP id y14-20020a17090aa40e00b002568cb72b2bmr31421pjp.14.1685384565482; Mon, 29 May 2023 11:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685384565; cv=none; d=google.com; s=arc-20160816; b=HMCVgMcaWSHgdhMy94DOXS26+ZHOs6pHgOIvvh8fOJkNSn8dOQ78ZEZyawAcxhHexI zZhVp4w4vvouAJ0KVi4yOpSEnRuSUW+bIAB/KdqiRL6YtZRsT/yR9gmMYHF8pBoksLo6 uyP0N57+vjnBMHIwe4blRI9GlO/NNrVTgUgbuT8cz0leyWJd2vKrI49mkJcmt4X34ytp gL8NiZXGMSlZUzToIFgwD+CepqucC3/y4q9X4wdODZWajkSLiJP/yk6k2pWkCMqv4lvo R2CM4ZMwR1k85YaBbeXY3S0dgMBywCHrjyAwIJ3IdunFiXKYxnBwA8AaLbr4xLB7h1gx kJrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=P/0tITYpTpGavafJMOkhwQed8uJTPSwLhyk8FXAUCS8=; b=WNRx9V4QnwYQFiL24XphgYBXk2xq4QuMr7uTUT822XFjbITLNsl5FRs+yA8Q7DY0tz FBvNfAFoqdwgEEztHQB0mA5ZH8dpMxeuPfct/fQCsvhUV5nx0IkJmpSmgsVW2FJCOrwp uuwVPHAlMoBXPoywaVUJmPgWKo/McpZB9xJjgNbfDgbrx8EvYMA4e1BN9+iCyrpb5W0C l1xzHqAySDLamOc0Fa5/aMebaApeyEgNZGATqqwEp09ZGseNX27yKUfwTaCdAn55EC0G NL3owhTrZfFMek9wa8q/yp4+KpwckQOIlWoDXKINsnOFMqtnP+GsY8LqoR19QFChN/XI yHhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=eKO8XMAZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 23-20020a17090a1a1700b00235dc16de3asi11226597pjk.16.2023.05.29.11.22.32; Mon, 29 May 2023 11:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=eKO8XMAZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbjE2Rzk (ORCPT + 99 others); Mon, 29 May 2023 13:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjE2Rzj (ORCPT ); Mon, 29 May 2023 13:55:39 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC136CD; Mon, 29 May 2023 10:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P/0tITYpTpGavafJMOkhwQed8uJTPSwLhyk8FXAUCS8=; b=eKO8XMAZv/UuArc8zlhV6qI5Z6 wwoXuHeWvPqvnNzPY/wAymufwuUnWz6wKtpLuVcY2fUy6dTJzBfU0e48o8MOFMgYVur0phcqyOtjQ B8uuZ0z3MfECNtVeWZtb7jk1d3JWxI06vtr++Xye1e3s0OWgYfbvkkVEAQdwtpPnb42rxUe36boqU QAJs/GKgHmXFxleNHO/XY8yy/fJdUY60TlvLHghmlDoRv2OnYwBHpLjRKgLoErWJY4qzKidFxkgX9 jIYWaGUnt1MoaJK9eTUHxwg+ta8SPNFmjHJ4elcGTHg/ztPEuFCYUoJMbDx1VrG5kHxGlbYz57PH2 ZhauUOmw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q3h5K-005bSP-AT; Mon, 29 May 2023 17:55:10 +0000 Date: Mon, 29 May 2023 18:55:10 +0100 From: Matthew Wilcox To: Nitesh Shetty Cc: Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , James Smart , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , Andrew Morton , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, James.Bottomley@hansenpartnership.com, bvanassche@acm.org, hare@suse.de, ming.lei@redhat.com, dlemoal@kernel.org, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v11 2/9] block: Add copy offload support infrastructure Message-ID: References: <20230522104146.2856-1-nj.shetty@samsung.com> <20230522104146.2856-3-nj.shetty@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522104146.2856-3-nj.shetty@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2023 at 04:11:33PM +0530, Nitesh Shetty wrote: > + token = alloc_page(gfp_mask); Why is PAGE_SIZE the right size for 'token'? That seems quite unlikely. I could understand it being SECTOR_SIZE or something that's dependent on the device, but I cannot fathom it being dependent on the host' page size.