Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 19:19:27 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        jirislaby@kernel.org, jringle@gridpoint.com,
        l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v4 6/9] dt-bindings: sc16is7xx: Add property to change
 GPIO function
Message-ID: <20230529-verify-sympathy-4a486a6cb2c9@spud>
References: <20230529140711.896830-1-hugo@hugovil.com>
 <20230529140711.896830-7-hugo@hugovil.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="HWnfav14a9y5BMK9"
Content-Disposition: inline
In-Reply-To: <20230529140711.896830-7-hugo@hugovil.com>
Precedence: bulk


--HWnfav14a9y5BMK9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 29, 2023 at 10:07:08AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>=20
> Some variants in this series of UART controllers have GPIO pins that
> are shared between GPIO and modem control lines.
>=20
> The pin mux mode (GPIO or modem control lines) can be set for each
> ports (channels) supported by the variant.
>=20
> This adds a property to the device tree to set the GPIO pin mux to
> modem control lines on selected ports if needed.
>=20
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>  .../bindings/serial/nxp,sc16is7xx.txt         | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b=
/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> index 0fa8e3e43bf8..74dfbbf7b2cb 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> @@ -23,6 +23,9 @@ Optional properties:
>      1 =3D active low.
>  - irda-mode-ports: An array that lists the indices of the port that
>  		   should operate in IrDA mode.
> +- nxp,modem-control-line-ports: An array that lists the indices of the p=
ort that
> +				should have shared GPIO lines configured as
> +				modem control lines.
> =20
>  Example:
>          sc16is750: sc16is750@51 {
> @@ -35,6 +38,26 @@ Example:
>                  #gpio-cells =3D <2>;
>          };
> =20
> +	sc16is752: sc16is752@54 {
> +		compatible =3D "nxp,sc16is752";
> +		reg =3D <0x54>;
> +		clocks =3D <&clk20m>;
> +		interrupt-parent =3D <&gpio3>;
> +		interrupts =3D <7 IRQ_TYPE_EDGE_FALLING>;
> +		nxp,modem-control-line-ports =3D <1>; /* Port 1 as modem control lines=
 */
> +		gpio-controller; /* Port 0 as GPIOs */
> +		#gpio-cells =3D <2>;
> +	};
> +
> +	sc16is752: sc16is752@54 {
> +		compatible =3D "nxp,sc16is752";
> +		reg =3D <0x54>;

If this were not a txt binding, dt_binding_check would likely complain
that you have two nodes with the same node address & 3 below.
If you end up re-submitting, could you change that please?
Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

--HWnfav14a9y5BMK9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHTsrwAKCRB4tDGHoIJi
0u0qAQD+oyebwmnbLHw3fMF7xo44CXBt5Kuzc6FqTzYKLleiuwD+PX2NjngRUx6Y
M1+frhXmkvQeJRAlldSerTUPDb3OVwY=
=A0bN
-----END PGP SIGNATURE-----

--HWnfav14a9y5BMK9--