Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 19:09:39 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Hugo Villeneuve <hugo@hugovil.com>
Cc:     Conor Dooley <conor.dooley@microchip.com>,
        gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        jirislaby@kernel.org, jringle@gridpoint.com,
        l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v4 6/9] dt-bindings: sc16is7xx: Add property to change
 GPIO function
Message-ID: <20230529-florist-hardiness-be5de59e660c@spud>
References: <20230529140711.896830-1-hugo@hugovil.com>
 <20230529140711.896830-7-hugo@hugovil.com>
 <20230529-seventy-stash-0446d9ae02e8@wendy>
 <20230529102601.144e17eccefaedc891e76f3a@hugovil.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3m/oGbX7oIKrh9f/"
Content-Disposition: inline
In-Reply-To: <20230529102601.144e17eccefaedc891e76f3a@hugovil.com>
Precedence: bulk


--3m/oGbX7oIKrh9f/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 29, 2023 at 10:26:01AM -0400, Hugo Villeneuve wrote:
> On Mon, 29 May 2023 15:16:47 +0100
> Conor Dooley <conor.dooley@microchip.com> wrote:
>=20
> > Hey Hugo,
> >=20
> > On Mon, May 29, 2023 at 10:07:08AM -0400, Hugo Villeneuve wrote:
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >=20
> > > Some variants in this series of UART controllers have GPIO pins that
> > > are shared between GPIO and modem control lines.
> > >=20
> > > The pin mux mode (GPIO or modem control lines) can be set for each
> > > ports (channels) supported by the variant.
> > >=20
> > > This adds a property to the device tree to set the GPIO pin mux to
> > > modem control lines on selected ports if needed.
> > >=20
> > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >=20
> > Did I not ack this in v2? I didn't notice a reason for dropping it
> > in the cover etc. Was it intentionally dropped, or missed?

> In v3, I slighly modified the example, and that is why I didn't copy your=
 ack.

Ah, I would say that for "slight modifications" when you have an ack,
you could keep it - but everyone is different and dropping tags is
likely to piss people off less than keeping them, so I understand
sticking on the safe side.


--3m/oGbX7oIKrh9f/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHTqYwAKCRB4tDGHoIJi
0iT6AP9Q185i0OxcOD7GLWmxswpaTvHOufcQOLOWg93VAMiGFAEAuhzLQA7nbEQ5
Qy+7aOMjI25GLgVmTTGqeAXe2EtCGwM=
=7KVg
-----END PGP SIGNATURE-----

--3m/oGbX7oIKrh9f/--