Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a566ffa5-0d30-58a4-fb4f-284504e04fff@oracle.com>
Date:   Mon, 29 May 2023 14:03:05 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps
 regression
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     "Eric W. Biederman" <ebiederm@xmission.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux@leemhuis.info, nicolas.dichtel@6wind.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mst@redhat.com,
        sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
        brauner@kernel.org
References: <87ttw1zt4i.fsf@email.froward.int.ebiederm.org>
 <20230525115512.GA9229@redhat.com>
 <87y1lcxwcj.fsf@email.froward.int.ebiederm.org>
 <CAHk-=wj4DS=2F5mW+K2P7cVqrsuGd3rKE_2k2BqnnPeeYhUCvg@mail.gmail.com>
 <87cz2mrtnk.fsf@email.froward.int.ebiederm.org>
 <CAHk-=whsi9JFP-okH3jXHrA8rh8bMuuSt6ZgkmPwiDMAn437qA@mail.gmail.com>
 <87mt1pmezu.fsf@email.froward.int.ebiederm.org>
 <20230529111859.GA15193@redhat.com>
 <022f4de6-9eae-0a94-0f55-b84be4982fc3@oracle.com>
 <20230529174646.GB15193@redhat.com> <20230529175440.GC15193@redhat.com>
Content-Language: en-US
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20230529175440.GC15193@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWdkSllVNDN6S0k1emp5aG5zV1RhclVBS1crd213ZGZjdEQ3L3ZwVENqYXJa?=
 =?utf-8?B?VGNFcTV6THEwQmlvL25COGVlWjBVRHIvVG9MWUs3enpLa21VVk1wRDRPOWg2?=
 =?utf-8?B?bHkrQWZpYWRaZC96NFNOeTJBWVRic1FWd2RMb09DdnhkWWkvSy9tKzk3ZzM0?=
 =?utf-8?B?b2pndUlIL3doUGp1cSsyYmorYXViQTBUZnhkTUtyR0RFNGlwc1hVTDVza2tX?=
 =?utf-8?B?c2dHVFZiaDNkTzNsbUh4ZTJLbWNHVHZ2TGxaek9zS2xMVEJScXhadXNLSVBZ?=
 =?utf-8?B?Z3VGY0pWVUNyZVZiYnhWUzhTTVZKV1JsOC9pZXlZL0ppOFBLU0JHTjlwWGFB?=
 =?utf-8?B?NGx0aDg0ek11TkN0MC9lUkZFK1VyWDN3QTZrc3pHY3VGeEdHSGI4a1IzSzFi?=
 =?utf-8?B?d1BHdC9JN3VGRVZBQWdCQmtEK0lwVnIwYjJLemlkWTI0ajdCNjNVRlExK0pK?=
 =?utf-8?B?ZUNOWndaY1JHd24zc2hWR1dsUFAvd1VzbC9jc3Vocjl1clZGT2tDTkdwWG9W?=
 =?utf-8?B?RzBwTllhb08yUkt0QlhCSVBiL0VFQjgrMlg0WnFVQ3cwS3lQMHBXcjJoek12?=
 =?utf-8?B?QWp6L0NwWnpDV0NYSTBLOGxBSjFjYzJZZXNXMFM0amJUdy9sVjgvYjVTUUFz?=
 =?utf-8?B?a21PYXFzVERJb3BjYTE3bTR5bnQxWEZpdzIraE1Wc1dOWEd5WjJiWmtCUzJ6?=
 =?utf-8?B?alk5Ukk2WVo1TW90ZTRpRVg1dGtrVHVpT2FzMzdpRnNGVEtUUllLdG9rbEJV?=
 =?utf-8?B?K1ZXWWtLVnpSaXFRT1JWN1RYemRSQm9TYS9LbkpCUTlHYVBlQ0lIcWdFcERj?=
 =?utf-8?B?QmRpY3JCN283R2FFdnRCbkJZTFpqUS9rK1hOYzhJbi9JUERSdjk1aHg4YnpZ?=
 =?utf-8?B?eVNlTExveUx2TGp3V0pGcjFTdTdCMy9JQ3BPZGR1WmpTbm8vblFnZHRTWmVa?=
 =?utf-8?B?ZFp6ZE9uNUFPZ3pXZjNPa1ZvSksvQytra3N3MGlPa3FhYnZKVmVRU1pDejJJ?=
 =?utf-8?B?RGJLY01mdTdFWFR5cU8ySmU2N25HSkxDY3pwMVd2RVVyZCsweFZLbGgyNGdC?=
 =?utf-8?B?cVhWMS95aVZsWkQ3M0xtWXNNaVVpUUN2R1VqTUUrVExLMEJzVFZ6b1N4dTNp?=
 =?utf-8?B?c2FBZUhyRllIaENmWFh5YnNnNExnNlp6WEhyUWRibW1UeDZteHRsTVBiZTFv?=
 =?utf-8?B?eExKVmRqREFRdjArMC9oZG1kQUtWSnU4Rk1rajVKNlRHZ2ZKeXk3ZmY4empp?=
 =?utf-8?B?R1B0TnpXa2JHeGRabER5T2tTcEVOT1J3cEtCV2NGbFJTVVJzMUEzM2FNSjZT?=
 =?utf-8?B?QXJadU1xalZta3ZRVTRKeW1oSmYxUUpKUUFwQzNmZWY5bWdKbWVWZHFyMHRq?=
 =?utf-8?B?SmgxN2REa0dsRkNreVFueWFZQTBrWTNqQkNnd2hteWxXSGhsMWdmN2ttbmh2?=
 =?utf-8?B?OWFIZlYyays3dEpZQ2NVTkNyVzBZTkVlS1RlbWsrVU4zZjljeWtFc2NPcDVz?=
 =?utf-8?B?RnlPeWFDVWxkZTVpS3NuNlVNdjZCMEZyZ0ZadCtzYjduOTNObkhBbDR5WjUr?=
 =?utf-8?B?Q0VRYk4zZlpPWWZzdE84SkdUVWE2NjZQRE5WblJ6NS9GelJvanRQSlBNbWRw?=
 =?utf-8?B?RkVCL0x6Y2FiQ2F6UFlXMzI1Y2F2MGU2VmlBVU5vdFF1b0FMMGpmQStrUWI5?=
 =?utf-8?B?Q0RmNTREZVRjbVlGQ3htQkVvbHJkdW50akhkc0U0U25CL1p4aFNIRU0zRGlr?=
 =?utf-8?B?d04zdVJQTDV3YlhiNStWNFRuckFNa3FzTUZwOUFOKzFIRGkxcTlNNFZPVG9x?=
 =?utf-8?B?aWhkSURXcUhDR2NvTlZVaWQvazZpQkJoQjhlTnlXNWZYcDVIQXhCQWxhbFJP?=
 =?utf-8?B?MFFsd1ZrZVRVK0MvVlRKcDJqQjZPL1NFWmJuelVxSXkzYjdvT3hlTWZwMTBq?=
 =?utf-8?B?blkwSGhLNVpLTmsxNVdwK09jek9pQXRQOUZUdFN1d1dzN25Ib1F0NGw2RGFj?=
 =?utf-8?B?UHd0VDJCUDZ0S3Y1Zk5jWWViUUlMem5paTB4R1pCYWtMRmQxVFpnWGlTQlRX?=
 =?utf-8?B?NW10MGJ4VVVaalFxdkJUMk1kS3Zla3F2ODI3SlFtMmpVaXRzdXNYM25QOEt2?=
 =?utf-8?B?TElQbkVGYlpIOVpabWlKQWJqVXlkS2JBaUc5NjhyejRWU3hYZFRZNUhsaEs0?=
 =?utf-8?B?TFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?dXRoU0VDeE5ZQ3BlQ1RHTjhHTVhlYzdQdUdMd1Y1VnFmckVERmJUNVVIc1pn?=
 =?utf-8?B?Z1YrRWMwQmJEQlEraXJRajBvN05heUFmRWNHTUhwVnZzSVVjdUQwL3BJQ2Vi?=
 =?utf-8?B?KzVKeFdOZnJBR0Nia0JmdythYnhUWnh0LzJrSEZiRUpYdWdad1hNaGoyQVFn?=
 =?utf-8?B?dWpaMEhsaUVkbGJiRitsendsTnF4N1YvT1lQcUVmcGVYem9ObEloMUNqeURQ?=
 =?utf-8?B?R3ZPV1h1Mms4N3dnRlBpdXhnTE9xVGwxdHNEQ2pZSFp4d3hHQmRTcFRqRXJD?=
 =?utf-8?B?QUhJTlZ1WXR1RUtrSjFzaUZiYnk2cWpBc3FnOFkzUUEycCtUM1pYdEd3Y1NX?=
 =?utf-8?B?UHVQd296T2RKWTByc0pWMlR5NjI2SGFGelUzSnFjajk0SVh5UWEwV054Unkz?=
 =?utf-8?B?eXAvSWNESUR2alhnbVA4TitZSE5iSnlzdGMvT2lzRGpQbG5jMVAra1NoaDNJ?=
 =?utf-8?B?TTk1a3l0RmRIdHBZbW5zZVZEeXZBUi9GMjFMRXRIKzlDUGJjbnRlZkN4enJI?=
 =?utf-8?B?VVUwTDd4MUlvZVRBWUN0aDlpZVFQRXU4dVlOT0VoYmxObjRtc3FZM3hsU25n?=
 =?utf-8?B?d0xtSHduSmFxcDdEMGR6dmhCRk5sUjdzZlFVUnhpU0JkZXFYU3N1OFdIUlg0?=
 =?utf-8?B?YmtmbllqQXg4T2VRN2EzZXZpaGtyS1NMUWRzNVpyZGo3cTV0aWZyeThldmJu?=
 =?utf-8?B?RTRsTGdxM1prbkZpSnEvZkQ1K0dPU3BGQitUSnZRNVRDMVdadVducDZ5WmpJ?=
 =?utf-8?B?eVBpVG9UN3ZqeHR1TXhBenFjMHUyaFJOcERuRDZkbWVQelp6NjRsb3NFUVdZ?=
 =?utf-8?B?RGtVWncrTXBRc1cyNkt2QVh3TllPQmRyZVVTai9pUkRVM3BDZkxmTEl3ekVG?=
 =?utf-8?B?aktwZFNGSlZraDlwRGQwMUFTZnVtd0M1S3ZvbVp0aGdTVHNRWCtvZXVYbkkw?=
 =?utf-8?B?bFFpbUtqaFBSUDFLMXlYeDgvV1RnWEJzbXVuNWJKUDFmc0lJb1JaMmZWV3dS?=
 =?utf-8?B?dG0vSUdBTk1wV2RBM0o5MWdUUi9MR1dJRzF3NW9OVWdKelN2U0ppTEErT0Ry?=
 =?utf-8?B?bndYV0Q1ZnNIUklBZXczVkRadjZJRHZCL0QwcWt3aHBOYjRSZzdwL1NNcmJY?=
 =?utf-8?B?T1NzWXBCSkJUMGltclBRQnhXRENDZU9MeHBsMEx2UkptVDhhYkdyQVRrVkdY?=
 =?utf-8?B?TDNuR1kyRTkvUlVlMCszdmVsN1hyLzVRY2wrS3JPS1FKdE9sbUthcVZIN2pT?=
 =?utf-8?B?N1BzTVAxSkRnNWg3b3lTeThJaGdZVUhuSDBYMStIMlg4Q24vc1FrL1JmUS9j?=
 =?utf-8?B?eXZ0NjBjaUhaVGt5UUVqZWlySEdQMENhRVZZeGZDcGptZXpLMmU4WS9DQ2Zq?=
 =?utf-8?B?WHdYS2F6b1pkcitmc21jc3UrbDVJRXFnMzFqMWNxY1RJUHIyaGQrUkRhUUhZ?=
 =?utf-8?Q?MXx3wr+2?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58993f58-090d-45b2-ca9f-08db60775688
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 19:03:07.3598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xuzyyEC5jAHcO32+1SJVLNtm//sYlF7w/OfGKpqVLdAr/39AYMAC5kGoO8+o0dZ332qquDnzdxpzqEQc8DlVuO4yYL4mJiE2CNKf4VoF8iQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7407
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-29_10,2023-05-29_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 adultscore=0 mlxlogscore=729 bulkscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305290160
X-Proofpoint-GUID: 23DBwgqSHUnNA6nCLoXNx_mWZ2dvJVEi
X-Proofpoint-ORIG-GUID: 23DBwgqSHUnNA6nCLoXNx_mWZ2dvJVEi
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/29/23 12:54 PM, Oleg Nesterov wrote:
> On 05/29, Oleg Nesterov wrote:
>>
>> Mike, sorry, I don't understand your email.
>>
>> Just in case, let me remind I know nothing about drivers/vhost/
> 
> And... this is slightly off-topic but you didn't answer my previous
> question and I am just curious. Do you agree that, even if we forget
> about CLONE_THREAD/signals, vhost_worker() needs fixes anyway because
> it can race with vhost_work_queue() ?

You saw the reply where I wrote I was waiting for the vhost devs to
reply because it's their code, right? Just wanted to make sure you know
I'm not ignoring your mails. The info is very valuable to me since I don't
know the signal code.

- I think you are right about using a continue after schedule.
- The work fn is stable. It's setup once and never changes.
- I have no idea why we do the __set_current_state(TASK_RUNNING). As
far as I can tell the work functions do not change the task state and
that might have been a left over from something else. However, the
vhost devs might know of some case.
- For the barrier use, I think you are right, but I couldn't trigger
an issue even if I hack up different timings. So I was hoping the
vhost devs know of something else in there.