Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755819AbXJLDHa (ORCPT ); Thu, 11 Oct 2007 23:07:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756126AbXJLDFZ (ORCPT ); Thu, 11 Oct 2007 23:05:25 -0400 Received: from nwd2mail10.analog.com ([137.71.25.55]:38749 "EHLO nwd2mail10.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755816AbXJLDFN (ORCPT ); Thu, 11 Oct 2007 23:05:13 -0400 X-IronPort-AV: i="4.21,263,1188792000"; d="scan'208"; a="53831998:sNHT51219854" From: Bryan Wu To: david-b@pacbell.net, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Mike Frysinger , Bryan Wu Subject: [PATCH 05/10] Blackfin SPI driver: prevent people from setting bits in ctl_reg Date: Fri, 12 Oct 2007 11:04:59 +0800 Message-Id: <1192158304-8277-6-git-send-email-bryan.wu@analog.com> X-Mailer: git-send-email 1.5.3.4 In-Reply-To: <1192158304-8277-1-git-send-email-bryan.wu@analog.com> References: <1192158304-8277-1-git-send-email-bryan.wu@analog.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 40 From: Mike Frysinger Prevent people from setting bits in ctl_reg that the SPI framework already handles, hopefully we can one day drop ctl_reg completely Signed-off-by: Mike Frysinger Signed-off-by: Bryan Wu --- drivers/spi/spi_bfin5xx.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 7093065..1a83656 100644 --- a/drivers/spi/spi_bfin5xx.c +++ b/drivers/spi/spi_bfin5xx.c @@ -996,6 +996,16 @@ static int setup(struct spi_device *spi) /* chip_info isn't always needed */ if (chip_info) { + /* Make sure people stop trying to set fields via ctl_reg when they + * should actually be using common SPI framework. Currently we let + * through: WOM EMISO PSSE GM SZ TIMOD. Not sure if a user actually + * needs/uses any of these, but let's assume (for now) they do. + */ + if (chip_info->ctl_reg & (SPE | MSTR | CPOL | CPHA | LSBF | SIZE)) { + dev_err(&spi->dev, "do not set bits in ctl_reg that the SPI framework provides\n"); + return -EINVAL; + } + chip->enable_dma = chip_info->enable_dma != 0 && drv_data->master_info->enable_dma; chip->ctl_reg = chip_info->ctl_reg; -- 1.5.3.4 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/