Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 22:05:39 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <keescook@chromium.org>, <yzaikin@google.com>,
        <ebiederm@xmission.com>, <dave.hansen@intel.com>, <arnd@arndb.de>,
        <bp@alien8.de>, <James.Bottomley@HansenPartnership.com>,
        <deller@gmx.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <luto@kernel.org>,
        <peterz@infradead.org>, <brgerst@gmail.com>,
        <christophe.jaillet@wanadoo.fr>, <kirill.shutemov@linux.intel.com>,
        <jroedel@suse.de>, <akpm@linux-foundation.org>,
        <willy@infradead.org>, <linux-parisc@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] signal: move show_unhandled_signals sysctl to
 its own file
Message-ID: <20230529200539.limexmxhrpfyya7p@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="xtz7dcv4hf5tve4g"
Content-Disposition: inline
In-Reply-To: <20230526222207.982107-3-mcgrof@kernel.org>
CMS-TYPE: 201P
References: <20230526222207.982107-1-mcgrof@kernel.org>
        <CGME20230526222248eucas1p2c21183361439f3a9e36c84545265395e@eucas1p2.samsung.com>
        <20230526222207.982107-3-mcgrof@kernel.org>
Precedence: bulk

--xtz7dcv4hf5tve4g
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 26, 2023 at 03:22:06PM -0700, Luis Chamberlain wrote:
> The show_unhandled_signals sysctl is the only sysctl for debug
> left on kernel/sysctl.c. We've been moving the syctls out from
> kernel/sysctl.c so to help avoid merge conflicts as the shared
> array gets out of hand.
>=20
> This change incurs simplifies sysctl registration by localizing
> it where it should go for a penalty in size of increasing the
> kernel by 23 bytes, we accept this given recent cleanups have
> actually already saved us 1465 bytes in the prior commits.
>=20
> ./scripts/bloat-o-meter vmlinux.3-remove-dev-table vmlinux.4-remove-debug=
-table
> add/remove: 3/1 grow/shrink: 0/1 up/down: 177/-154 (23)
> Function                                     old     new   delta
> signal_debug_table                             -     128    +128
> init_signal_sysctls                            -      33     +33
> __pfx_init_signal_sysctls                      -      16     +16
> sysctl_init_bases                             85      59     -26
> debug_table                                  128       -    -128
> Total: Before=3D21256967, After=3D21256990, chg +0.00%
>=20
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  kernel/signal.c | 23 +++++++++++++++++++++++
>  kernel/sysctl.c | 14 --------------
>  2 files changed, 23 insertions(+), 14 deletions(-)
>=20
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 8f6330f0e9ca..5ba4150c01a7 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -45,6 +45,7 @@
>  #include <linux/posix-timers.h>
>  #include <linux/cgroup.h>
>  #include <linux/audit.h>
> +#include <linux/sysctl.h>
> =20
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/signal.h>
> @@ -4771,6 +4772,28 @@ static inline void siginfo_buildtime_checks(void)
>  #endif
>  }
> =20
> +#if defined(CONFIG_SYSCTL)
> +static struct ctl_table signal_debug_table[] =3D {
> +#ifdef CONFIG_SYSCTL_EXCEPTION_TRACE
> +	{
> +		.procname	=3D "exception-trace",
> +		.data		=3D &show_unhandled_signals,
> +		.maxlen		=3D sizeof(int),
> +		.mode		=3D 0644,
> +		.proc_handler	=3D proc_dointvec
> +	},
> +#endif
> +	{ }
> +};
> +
> +static int __init init_signal_sysctls(void)
> +{
> +	register_sysctl_init("debug", signal_debug_table);
> +	return 0;
> +}
> +early_initcall(init_signal_sysctls);
> +#endif /* CONFIG_SYSCTL */
> +
>  void __init signals_init(void)
>  {
>  	siginfo_buildtime_checks();
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index a7fdb828afb6..43240955dcad 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2331,24 +2331,10 @@ static struct ctl_table vm_table[] =3D {
>  	{ }
>  };
> =20
> -static struct ctl_table debug_table[] =3D {
> -#ifdef CONFIG_SYSCTL_EXCEPTION_TRACE
> -	{
> -		.procname	=3D "exception-trace",
> -		.data		=3D &show_unhandled_signals,
> -		.maxlen		=3D sizeof(int),
> -		.mode		=3D 0644,
> -		.proc_handler	=3D proc_dointvec
> -	},
> -#endif
> -	{ }
> -};
> -
>  int __init sysctl_init_bases(void)
>  {
>  	register_sysctl_init("kernel", kern_table);
>  	register_sysctl_init("vm", vm_table);
> -	register_sysctl_init("debug", debug_table);
> =20
>  	return 0;
>  }
> --=20
> 2.39.2
>=20

LGTM
--=20

Joel Granados

--xtz7dcv4hf5tve4g
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmR1BZMACgkQupfNUreW
QU+RNgwAk/Z2mYaycPxMeef8lQvY2yVWUf5q2MCjPy06wUObCXySaXq7LCvkxJPF
7JUVXIQ81yZNNNdQ8dWnP0M1gF7Gy1/FuVZwE4FagWhT9nelpF3kmBll4JfkbnG0
1fJVvS4HDK3RB1h7MwIyy1loRFrZvOC7oPf25qwK7PHfjrbAfZvHIda88CH8uQoY
Ro2letTYBeYIcSp/YXSd7QjvnlWMWZbJuLHodgm1GK5MmZFARCxCKydYczFta8kC
/hT/VaYTnxs1uG8eI55Bb69LJF9kZNKsZYwzNus9wJxKWJgkhkpgJvJyFoJP2pXf
2Wdrufh/b73bRTGolMe4zZmqtMeFLctMSXSMglftViTkJzQSRKi+goiwnH//dt3+
JpvVex4Z1k9hz6MBRpCPys3kSmXjOW5EwI1hTNtH9Hp3xeotJEN6n3ncwHpOuL2E
D5i7AXkoFQa4D731FlAsfCxxuelF98CHS3CNaqDK9cRqOa9Gzco1TafXtc9DD8T3
RWpFL98a
=5oKi
-----END PGP SIGNATURE-----

--xtz7dcv4hf5tve4g--