Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 22:04:57 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <keescook@chromium.org>, <yzaikin@google.com>,
        <ebiederm@xmission.com>, <dave.hansen@intel.com>, <arnd@arndb.de>,
        <bp@alien8.de>, <James.Bottomley@HansenPartnership.com>,
        <deller@gmx.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <luto@kernel.org>,
        <peterz@infradead.org>, <brgerst@gmail.com>,
        <christophe.jaillet@wanadoo.fr>, <kirill.shutemov@linux.intel.com>,
        <jroedel@suse.de>, <akpm@linux-foundation.org>,
        <willy@infradead.org>, <linux-parisc@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] sysctl: remove empty dev table
Message-ID: <20230529200457.a42hwn7cq6np5ur4@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="5h2emgdaq4yeo4b7"
Content-Disposition: inline
In-Reply-To: <20230526222207.982107-2-mcgrof@kernel.org>
CMS-TYPE: 201P
References: <20230526222207.982107-1-mcgrof@kernel.org>
        <CGME20230526222249eucas1p1d38aca6c5a5163bd6c48b3a56e2618b4@eucas1p1.samsung.com>
        <20230526222207.982107-2-mcgrof@kernel.org>
Precedence: bulk

--5h2emgdaq4yeo4b7
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 26, 2023 at 03:22:05PM -0700, Luis Chamberlain wrote:
> Now that all the dev sysctls have been moved out we can remove the
> dev sysctl base directory. We don't need to create base directories,
> they are created for you as if using 'mkdir -p' with register_syctl()
> and register_sysctl_init(). For details refer to sysctl_mkdir_p()
> usage.
>=20
> We save 90 bytes with this changes:
>=20
> ./scripts/bloat-o-meter vmlinux.2.remove-sysctl-table vmlinux.3-remove-de=
v-table
> add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-90 (-90)
> Function                                     old     new   delta
> sysctl_init_bases                            111      85     -26
> dev_table                                     64       -     -64
> Total: Before=3D21257057, After=3D21256967, chg -0.00%
>=20
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  kernel/sysctl.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index fa2aa8bd32b6..a7fdb828afb6 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2344,16 +2344,11 @@ static struct ctl_table debug_table[] =3D {
>  	{ }
>  };
> =20
> -static struct ctl_table dev_table[] =3D {
> -	{ }
> -};
> -
>  int __init sysctl_init_bases(void)
>  {
>  	register_sysctl_init("kernel", kern_table);
>  	register_sysctl_init("vm", vm_table);
>  	register_sysctl_init("debug", debug_table);
> -	register_sysctl_init("dev", dev_table);
> =20
>  	return 0;
>  }
> --=20
> 2.39.2
>=20
LGTM.

Review
But why was dev there to begin with?

Best

--=20

Joel Granados

--5h2emgdaq4yeo4b7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGyBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmR1BWcACgkQupfNUreW
QU/t3gv3c4diMWueMMeFZjElEqAeuF66TElSTtKZbqNst1WFgpzBrHNLH0hAGhLO
vRbWOFmYgjh6U31lrVti+jcw+Ha8t+SRjASrYvefYjw9XIv7geaaE7eJZFtYWfJF
yAuSAlbtrl6xLDBudHTD80jXFDEoj+9FrADIyViWyRALRBvsePkRQqiNJPi498yt
nhHAuEStiqJLqLqcnEZ5eERoWOtSxU31cOXl0SdLpUGt6uNYzIiWHLzz2POOtmjP
4hxAW9Uod+yHAWNjOnec5UnQfiMHZtyjAYe6S3ljbiEtjde2rrM599NpznWrrcRQ
7FEz/3wIu/4qL90gj78krhwyiYeC/VlchrC0sOdgV5Gi3ooSO/bMdvD5MST4rN1q
xIL4tVsUQ8LySQNfk1zYfavLqXllSEoHvQc3txw2X6K0ArB3mqkHv/1qIr1sn+Px
PAsWXbMeVeYZHyIkHzzUWPpKGyaqHyho5VQ0MJfqL1cgEva1Xol9xaiePbPRijvA
3BJT2UU=
=Aua/
-----END PGP SIGNATURE-----

--5h2emgdaq4yeo4b7--