Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 29 May 2023 23:40:12 +0300
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Martin Kepplinger <martin.kepplinger@puri.sm>
Cc:     laurent.pinchart@ideasonboard.com, kernel@puri.sm,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        mchehab@kernel.org
Subject: Re: [PATCH v2] media: hi846: fix usage of pm_runtime_get_if_in_use()
Message-ID: <ZHUNrHGJv63mKGH0@valkosipuli.retiisi.eu>
References: <20230425094747.2769693-1-martin.kepplinger@puri.sm>
 <ZGODstToZrypFaAV@valkosipuli.retiisi.eu>
 <73bfe0c438e194fa462bec521debacfcd722dc9e.camel@puri.sm>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <73bfe0c438e194fa462bec521debacfcd722dc9e.camel@puri.sm>
Precedence: bulk

On Tue, May 23, 2023 at 12:07:54PM +0200, Martin Kepplinger wrote:
> Am Dienstag, dem 16.05.2023 um 16:22 +0300 schrieb Sakari Ailus:
> > Hi Martin,
> > 
> > On Tue, Apr 25, 2023 at 11:47:47AM +0200, Martin Kepplinger wrote:
> > > pm_runtime_get_if_in_use() does not only return nonzero values when
> > > the device is in use, it can return a negative errno too.
> > > 
> > > And especially during resuming from system suspend, when runtime pm
> > > is not yet up again, -EAGAIN is being returned, so the subsequent
> > > pm_runtime_put() call results in a refcount underflow.
> > > 
> > > Fix system-resume by handling -EAGAIN of
> > > pm_runtime_get_if_in_use().
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > > ---
> > > 
> > > revision history
> > > ----------------
> > > v2 (thank you Sakari and Laurent):
> > > * drop the other patch (the streaming-state in suspend/resume needs
> > > to
> > > ? be solved differently).
> > > * Sakari pointed out that many drivers are affected by this and
> > > that
> > > ? runtime-pm might need changes instead. I think this patch doesn't
> > > hurt
> > > ? and could serve as a reminder to do so.
> > 
> > I guess it's appropriate to add:
> > 
> > Fixes: e8c0882685f9 ("media: i2c: add driver for the SK Hynix Hi-846
> > 8M pixel camera")
> > 
> 
> I agree. Feel free to do so when applying.

Done!

-- 
Sakari Ailus