Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wu Bo <bo.wu@vivo.com>
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, wubo.oduw@gmail.com,
        Wu Bo <bo.wu@vivo.com>
Subject: [PATCH v2 1/1] f2fs: fix args passed to trace_f2fs_lookup_end
Date:   Tue, 30 May 2023 09:21:18 +0800
Message-Id: <20230530012118.74228-1-bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sa8bMBW1bw8mDpiA4IF8VlqfMbBxuM/KA4yj8b7/vYoVldJV8jp3WZKbeYk2?=
 =?us-ascii?Q?RfpWnA7s1Hw/xEEN6ATaaALVVtgejNOVBPFTZu0jsppUfMVneNf+Fhdh7sP0?=
 =?us-ascii?Q?POoE5Af44tqllKMw7pacvVr79/XkbpU2iEWVOKySxFW3xYF4do8ZqocyamGZ?=
 =?us-ascii?Q?3dQM2Rn3czCA8X0OXxyw+1GPIYrhP9ou3o3sqChmvhqQf+FI4r2hDWPr1KP3?=
 =?us-ascii?Q?fsojt2qUThBMyw0t84EbwHo9suVCHo483znp+ZKRYqU4ImEYno2MiHCD/m3X?=
 =?us-ascii?Q?JFsDJTMDoselmAPe2Kg9S3ixtraUvbHgZBOGDazbFJI9bYD88z+5553ikoxY?=
 =?us-ascii?Q?Fa2kPpI2ZLgGJ2T276Lq0mUGBBzl2/EiF2QxPIi/RUmx1xwWm1lg8X9pCoXg?=
 =?us-ascii?Q?8kGHDMMDNm3s1Gr1jr1tKlerquvnYDvGpufUjCAMQhbRuHaEF+tB2EXZRsMz?=
 =?us-ascii?Q?TAG5+cfhzIU+LTLsDE2cTWUY3La3RCINWh6omIPYqEJvO6ZUiG5aC1WChOzy?=
 =?us-ascii?Q?R5sVgyy+0D3cB4EuJ+ZZOEvvAVAx64QlggmDMce+nxOwpBPWdvpAxJ29f46X?=
 =?us-ascii?Q?8Dq/LLXsBfSfnHLR3HoohDHoBC1W1zptJx4KmWlZqgkV72Ty3U3uOAP1s/oP?=
 =?us-ascii?Q?1al+cwmcGDqgRvbM7qY4kourTrNFf1KjpQe6dgy5Nv9hzTNia1pWQ6JdwvN5?=
 =?us-ascii?Q?nniW+TFwdzlyRhmY64xok7Y09GbpJFYfjGmFoEC7CjLkDcqqrhBh3kiq+ytu?=
 =?us-ascii?Q?bRVO9sYwTqG3l93ahK1Mq8TLV0bvO+YCsrkjDXjkcy8u+6/U2ZaCcU8wv9sa?=
 =?us-ascii?Q?8tJqrmQjSKCT5sJu0nAUc+qTrV85IHkd/17QMkBe487HuqNcoyo1GhxVbILK?=
 =?us-ascii?Q?NUFP2vU7+R7X4suDPVB1OYSZBYAwWGceqXriq/qQipVhkum2KNi/GwibHZR6?=
 =?us-ascii?Q?m+GA6eVaCHxKO1AaD7HxHYIVqzTk6BXtFRWp6mQtbw5q5izm9mWYgy+U+0/+?=
 =?us-ascii?Q?t5rjTmTcDTA4lGTe4IzbFL6oKBcMWMqp3wClI+ueLBR0iIAD4E55dLWrMirw?=
 =?us-ascii?Q?NmnPCZ8h3t3s94kpK10C3RgARmG5qUzSEt0iuPsEkhoPKiR2FWG3v4Gag/eP?=
 =?us-ascii?Q?n/0Jk8u+he4/JvkgXbiz4t4CBiXuIiCASLbcCx0UlWzttm38fQcOFUVBwQ2F?=
 =?us-ascii?Q?Wv7ByCAAsRvm+ruFOi7ccP07paqGUGBJ1WUs6410WEnHqfojdT+jDsD20qi9?=
 =?us-ascii?Q?nw4+QpwBz6FF4SEXw+fISCs5QboYTt518xrhOf5oK0EC6EXtLtomy4TTRAh+?=
 =?us-ascii?Q?PsNbE4hIjbJ2Jm1qWQW3BPte10opOjpt14w9X4k1uvHunm3/veeIMncDbDkT?=
 =?us-ascii?Q?dD2KK9qCGCJ7WdmHRpJWiDvbZVX/jITRaXC4O0vGrqRF9FAbLg3KrVOn0cuA?=
 =?us-ascii?Q?rvhpnRBtAwSj1EmsaWKCPwDsUymDXtcBHpsiiedGSpn/xbX43bVBTOE3sjd9?=
 =?us-ascii?Q?Rdr1/0Imt+v1tC/jI6TeposMoZrwe7u9vO5NUYXuu4WyufFdI2C0FgA3kVIa?=
 =?us-ascii?Q?6+wKbo8E0pjmU/RsPywCGKf1XHP6GhSc/k06ZqMF?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5081685-f5fc-4c83-0f70-08db60ac326a
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3023.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 01:21:30.4933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8d/mf9Teis7iadEAdP6vtxM6okTeK9wN8kvCItx7en2ikj+F16EOGnPfh3a5NJZA430Dac8VlXhBteC0SBtQeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6273
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The NULL return of 'd_splice_alias' dosen't mean error. Thus the
successful case will also return NULL, which makes the tracepoint always
print 'err=-ENOENT'.

Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 fs/f2fs/namei.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 77a71276ecb1..0c5e4c424eab 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -576,8 +576,9 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry,
 	}
 #endif
 	new = d_splice_alias(inode, dentry);
-	err = PTR_ERR_OR_ZERO(new);
-	trace_f2fs_lookup_end(dir, dentry, ino, !new ? -ENOENT : err);
+	if (IS_ERR(new))
+		err = PTR_ERR(new);
+	trace_f2fs_lookup_end(dir, new ? new : dentry, ino, err);
 	return new;
 out_iput:
 	iput(inode);
-- 
2.35.3