Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230529073845.2859178-1-guoren@kernel.org> <20230529-jasmine-amigo-6d01f6852b35@wendy>
In-Reply-To: <20230529-jasmine-amigo-6d01f6852b35@wendy>
From:   Guo Ren <guoren@kernel.org>
Date:   Tue, 30 May 2023 10:59:14 +0800
Message-ID: <CAJF2gTRSoZbexqka=_7nf4+dHZW2FGf++BiTMypfTbeoGAbUiA@mail.gmail.com>
Subject: Re: [PATCH] riscv: vector: Fixup modules compile error
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     greentime.hu@sifive.com, vincent.chen@sifive.com,
        andy.chiu@sifive.com, paul.walmsley@sifive.com,
        palmer@rivosinc.com, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 29, 2023 at 9:43=E2=80=AFPM Conor Dooley <conor.dooley@microchi=
p.com> wrote:
>
> On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@kernel.org wrote:
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > Some .ko also need the riscv_v_user_allowed symbol.
> >
> > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko]
> > undefined!
> > make[3]: ***
> > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136:
> > Module.symvers] Error 1
> >
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@kernel.org>
> > ---
> >  arch/riscv/kernel/vector.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c
> > index 1c4ac821e008..3ae08816d608 100644
> > --- a/arch/riscv/kernel/vector.c
> > +++ b/arch/riscv/kernel/vector.c
> > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void)
> >  {
> >       return riscv_v_get_cur_ctrl(current) =3D=3D PR_RISCV_V_VSTATE_CTR=
L_ON;
> >  }
> > +EXPORT_SYMBOL(riscv_v_user_allowed);
>
> Is there a reason that this should not be EXPORT_SYMBOL_GPL()?
Good question, but I just follow our arch/riscv habbit, maybe we
should change all of that in another patch.

=E2=9E=9C  linux-s64ilp32 git:(s64ilp32) =E2=9C=97 grep EXPORT_SYMBOL  arch=
/riscv -r | wc -l
66
=E2=9E=9C  linux-s64ilp32 git:(s64ilp32) =E2=9C=97 grep EXPORT_SYMBOL_GPL  =
arch/riscv -r | wc -l
15

>
> I figure Andy will roll this into this next revision.
>
> Cheers,
> Conor.


--=20
Best Regards
 Guo Ren