Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ratheesh Kannoth <rkannoth@marvell.com>
To:     <starmiku1207184332@gmail.com>, <ast@kernel.org>,
        <daniel@iogearbox.net>, <john.fastabend@gmail.com>,
        <andrii@kernel.org>, <martin.lau@linux.dev>, <song@kernel.org>,
        <yhs@fb.com>, <kpsingh@kernel.org>, <sdf@google.com>,
        <haoluo@google.com>, <jolsa@kernel.org>, <davem@davemloft.net>,
        <kuba@kernel.org>, <hawk@kernel.org>
CC:     <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>
Subject: [PATCH] kernel: bpf: syscall: fix a possible sleep-in-atomic bug in __bpf_prog_put()
Date:   Tue, 30 May 2023 10:24:09 +0530
Message-ID: <20230530045409.440958-1-rkannoth@marvell.com>
In-Reply-To: <20230529155327.585056-1-starmiku1207184332@gmail.com>
References: <20230529155327.585056-1-starmiku1207184332@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

From: starmiku1207184332@gmail.com

>
>+			// safely calling vfree() under any context
do we need this comment as code is self explanatory.

> 			INIT_WORK(&aux->work, bpf_prog_put_deferred);
> 			schedule_work(&aux->work);
> 		} else {
>+			// depending on the vfree_atomic() branch in vfree()
same as above.

> 			bpf_prog_put_deferred(&aux->work);
> 		}
> 	}
>--
>2.25.1